Issue 2867 in reviewboard: allow reporter to resolve issues

2013-01-16 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2867 by matthew@kitware.com: allow reporter to resolve issues
http://code.google.com/p/reviewboard/issues/detail?id=2867

What version are you running?
RB 1.7.1

What's the URL of the page this enhancement relates to, if any?
any request with issues I created

Describe the enhancement and the motivation for it.
Sometimes authors don't mark issues 'fixed' (or maybe don't want to until  
verified 'fixed' by the reporter), or an issue reporter realizes on further  
thought/discussion that something opened as an issue isn't and should be  
dropped. It would be useful if the reporter of an issue was also allowed to  
resolve issues, not just the request author.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2868 in reviewboard: allow closing issues when updating request

2013-01-16 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2868 by matthew@kitware.com: allow closing issues when  
updating request

http://code.google.com/p/reviewboard/issues/detail?id=2868

What version are you running?
RB 1.7.1

What's the URL of the page this enhancement relates to, if any?
any draft update to a request with issues

Describe the enhancement and the motivation for it.
It would be useful if the process of publishing an updated request could  
also resolve open issues. Basically, below the 'describe the changes' box,  
have a list of issues with a check box to mark that issue 'fixed' on  
publishing the new diff. (An additional widget to check all the boxes would  
also be nice.)


Long term, having the 'new diff' message in the reviews list note what  
issues were closed would be nice, but short term, just being able to  
combine uploading the new diff and closing issues would be helpful  
(especially to remind authors to close issues when updating a request; I'm  
finding some of my users tend to forget otherwise).



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2860 in reviewboard: GCC_4.2.0 version not found

2013-01-16 Thread reviewboard


Comment #3 on issue 2860 by chip...@gmail.com: GCC_4.2.0 version not found
http://code.google.com/p/reviewboard/issues/detail?id=2860

If it's not showing up in the reviewboard.log, then we don't have any  
additional logging that would help here.


It can occur at many points, though. The one you're likely hitting is when  
we check to verify the repository exists and is reachable, which calls out  
to pysvn's info2() function ('svn info'), providing the repository path.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2713 in reviewboard: Reviewer, not author, should mark issues as resolved/reopened

2013-01-16 Thread reviewboard


Comment #5 on issue 2713 by trowb...@gmail.com: Reviewer, not author,  
should mark issues as resolved/reopened

http://code.google.com/p/reviewboard/issues/detail?id=2713

Issue 2867 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2867 in reviewboard: allow reporter to resolve issues

2013-01-16 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 2713

Comment #1 on issue 2867 by trowb...@gmail.com: allow reporter to resolve  
issues

http://code.google.com/p/reviewboard/issues/detail?id=2867

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2713 in reviewboard: Reviewer, not author, should mark issues as resolved/reopened

2013-01-16 Thread reviewboard


Comment #6 on issue 2713 by matthew@kitware.com: Reviewer, not author,  
should mark issues as resolved/reopened

http://code.google.com/p/reviewboard/issues/detail?id=2713

A three-stage flow would work. It's a little inconvenient (and also odd)  
for the author to not be able to indicate that an issue is resolved. I'd be  
okay if there was a site policy to disallow authors resolving issues, but  
I'm not sure it is the best way in general. As long as a reporter can  
reopen an issue if they disagree with the author that it was suitably  
addressed (the aforementioned way for the reviewer to indicate whether an  
issue has been properly addressed or not), I don't have a problem with the  
author being able to resolve issues.


For me, it's more important that the reporter have the *ability* to resolve  
issues (e.g. if the author forgets, or if they realize something they  
thought was an issue actually isn't, or even just made a mistake, etc.).  
I'd be inclined to call that a separate issue, which would be a dependency  
of this.


FWIW, most bug tracking tools allow reporters to close their own issues,  
and commiters (i.e. privileged users) to close any issue (in this case,  
equivalent to authors closing issues with their requests).


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.