Issue 3012 in reviewboard: Manual line-alignment in diff
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3012 by vlov...@gmail.com: Manual line-alignment in diff http://code.google.com/p/reviewboard/issues/detail?id=3012 What version are you running? 1.7.9 What's the URL of the page this enhancement relates to, if any? http://purpleslam-reviewboard.apple.com/r/review #/diff/ Describe the enhancement and the motivation for it. It would be nice if there was a manual line-alignment option like in kdiff3. The reason is that often times the automatically generated diff will misalign lines it would help the reviewer be able to adjust that to make the review easier to read. The manual alignment can be persisted so that others benefit. It should be visible where there is a manual alignment. It should be possible to remove a single manual alignment all manual alignments. What operating system are you using? What browser? OSX, Chrome 27.0 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3013 in reviewboard: Deleting a file attachment does not delete comments about it from issue summary table
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3013 by ilacknor...@gmail.com: Deleting a file attachment does not delete comments about it from issue summary table http://code.google.com/p/reviewboard/issues/detail?id=3013 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? 1.7.7.1 What's the URL of the page containing the problem? It occurs also on the 1.8 alpha 0 demo page. Refer to this review: http://demo.reviewboard.org/r/11702/ What steps will reproduce the problem? 1. Add a file 2. Publish comments on the file. You'll see it show up on the issue summary 3. Now delete the file 4. You'll STILL see the comment from step 2 as Open in the issue summary table. What is the expected output? What do you see instead? I think keeping the comment history in the Reviews section is very valuable, but in terms of the Issue Summary Table, I expect to either see 1.) the comment doesn't show up in the issue summary table at all or 2.) the status of that comment should either be Dropped or Deleted (though this does require a new status) What operating system are you using? What browser? Mac OSX Lion. Chrome Version 27.0.1453.110 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3013 in reviewboard: Deleting a file attachment does not delete comments about it from issue summary table
Updates: Status: NotABug Comment #1 on issue 3013 by trowb...@gmail.com: Deleting a file attachment does not delete comments about it from issue summary table http://code.google.com/p/reviewboard/issues/detail?id=3013 This is expected behavior. People often remove file attachments in favor of a new version of the same file, but we don't want to erase all discussion that happened before. Just close the issue if it no longer applies. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3012 in reviewboard: Manual line-alignment in diff
Updates: Status: Duplicate Mergedinto: 839 Comment #1 on issue 3012 by trowb...@gmail.com: Manual line-alignment in diff http://code.google.com/p/reviewboard/issues/detail?id=3012 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #21 on issue 839 by trowb...@gmail.com: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 Issue 3012 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3012 in reviewboard: Manual line-alignment in diff
Comment #2 on issue 3012 by vlov...@gmail.com: Manual line-alignment in diff http://code.google.com/p/reviewboard/issues/detail?id=3012 This isn't a duplicate of the issue. That deals with tab/space stuff. This is about being able to say that two files are aligned differently. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3012 in reviewboard: Manual line-alignment in diff
Updates: Status: New Mergedinto: Comment #3 on issue 3012 by trowb...@gmail.com: Manual line-alignment in diff http://code.google.com/p/reviewboard/issues/detail?id=3012 Oh, I understand now what you mean. You're not satisfied with the sequence alignment that the diff algorithm chooses. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3013 in reviewboard: Deleting a file attachment does not delete comments about it from issue summary table
Comment #2 on issue 3013 by ilacknor...@gmail.com: Deleting a file attachment does not delete comments about it from issue summary table http://code.google.com/p/reviewboard/issues/detail?id=3013 Like I mentioned earlier, I think it is valuable to keep all discussions in the review updates below (I'm not suggesting that), but I don't think the comment should be listed as an Open Issue on the Issue Summary Table when in fact the file attachment no longer exists. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3013 in reviewboard: Deleting a file attachment does not delete comments about it from issue summary table
Comment #3 on issue 3013 by chip...@gmail.com: Deleting a file attachment does not delete comments about it from issue summary table http://code.google.com/p/reviewboard/issues/detail?id=3013 I can see an argument for that, but there's another argument that I believe requires that we keep behavior as-is. Say I upload a screenshot, and people make comments on it. I may, as part of a subsequent update, replace that screenshot with a newer version, without addressing their concerns. For example, maybe I tweaked the look of something, but I didn't fix a typo they found. By altering this behavior to erase those issues from the removed screenshot, I lose very valuable feedback that may still be very relevant. I don't want to do that. Just because a file attachment (or diff) was replaced, doesn't mean the previous feedback has been addressed. What *should* be done is that the owner of the review request should close the issues once they are fixed. Reviews should *never* disappear. It's up to the owner to respond to any open issues, and having the system auto-close them is asking for trouble. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3013 in reviewboard: Deleting a file attachment does not delete comments about it from issue summary table
Comment #4 on issue 3013 by ilacknor...@gmail.com: Deleting a file attachment does not delete comments about it from issue summary table http://code.google.com/p/reviewboard/issues/detail?id=3013 The submitter is still allowed to mark the comment as Fixed or Dropped. That makes sense. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
