Issue 3394 in reviewboard: Problem with upgrade from 1.7.22 to 2.0.1. Django evolution fails

2014-06-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3394 by rafal.wo...@gmail.com: Problem with upgrade from 1.7.22  
to 2.0.1. Django evolution fails

http://code.google.com/p/reviewboard/issues/detail?id=3394

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!


What version are you running?
1.7.22

What's the URL of the page containing the problem?
N/A

What steps will reproduce the problem?
1. Install RB 2.0.1
2. Run rb-site upgrade /path/to/my/board
3. Run once again rb-site upgrade /path/to/my/board

What is the expected output? What do you see instead?

After the first run of the upgrade command, rb-site upgrade /path/ I get:
Rebuilding directory structure
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

-- begin log output --
Creating tables ...
Upgrading Review Board from 1.7.22 to 2.0.1
There are unapplied evolutions for auth.
There are unapplied evolutions for contenttypes.
There are unapplied evolutions for accounts.
There are unapplied evolutions for attachments.
There are unapplied evolutions for changedescs.
There are unapplied evolutions for diffviewer.
There are unapplied evolutions for hostingsvcs.
There are unapplied evolutions for reviews.
There are unapplied evolutions for scmtools.
Adding baseline version for new models
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
Evolution successful.
--- end log output ---

Resetting in-database caches.

Upgrade complete!


If the command is run the second time, it ends with error message:

Rebuilding directory structure
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

-- begin log output --
Creating tables ...
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
The stored evolutions do not completely resolve all model changes.

Run `./manage.py evolve --hint` to see a suggestion for the changes  
required.


The following are the changes that could not be resolved:
The application markup has been deleted
In model changedescs.ChangeDescription:
Field 'rich_text' has been added
In model attachments.FileAttachment:
Field 'added_in_filediff' has been added
Field 'repository' has been added
Field 'repo_revision' has been added
Field 'repo_path' has been added
In model auth.Permission:
Meta property 'unique_together' has changed
In model reviews.Comment:
Field 'rich_text' has been added
Field 'extra_data' has been added
In model reviews.Group:
Field 'extra_data' has been added
In field 'mailing_list':
Property 'max_length' has changed
Meta property 'unique_together' has changed
In model reviews.FileAttachmentComment:
Field 'diff_against_file_attachment' has been added
Field 'rich_text' has been added
In model reviews.Review:
Field 'rich_text' has been added
Field 'extra_data' has been added
In model reviews.ReviewRequestDraft:
Field 'commit_id' has been added
Field 'extra_data' has been added
Field 'rich_text' has been added
In model reviews.ReviewRequest:
Field 'issue_dropped_count' has been added
Field 'extra_data' has been added
Field 'commit_id' has been added
Field 'issue_resolved_count' has been added
Field 'issue_open_count' has been added
Field 'rich_text' has been added
Meta property 'unique_together' has changed
In model reviews.ScreenshotComment:
Field 'rich_text' has been added
Field 'extra_data' has been added
In model contenttypes.ContentType:
Meta property 'unique_together' has changed
In model accounts.Profile:
Field 'show_closed' has been added
Field 'show_submitted' has been deleted
In model accounts.ReviewRequestVisit:
Meta property 'unique_together' has changed
In model accounts.LocalSiteProfile:
Meta property 'unique_together' has changed
In model scmtools.Repository:
Meta property 'unique_together' has changed
In model diffviewer.DiffSet:
Field 'extra_data' has been added
In model diffviewer.FileDiffData:
Field 'extra_data' has been added
In model diffviewer.DiffSetHistory:
Field 'extra_data' has been added
In model diffviewer.FileDiff:
Field 'extra_data' has been added
CommandError: Your models contain changes that Django Evolution cannot  
resolve automatically.



What operating system are you using? What browser?
Ubuntu 

Re: Issue 3394 in reviewboard: Problem with upgrade from 1.7.22 to 2.0.1. Django evolution fails

2014-06-02 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 3394 by chip...@gmail.com: Problem with upgrade from  
1.7.22 to 2.0.1. Django evolution fails

http://code.google.com/p/reviewboard/issues/detail?id=3394

This is almost always due to upgrading, then downgrading, then upgrading  
again. Or, a previously failed upgrade attempt due to some other error  
(often a MyISAM vs. InnoDB table difference).


Can you show me the output of:

rb-site manage /path/to/site list-evolutions

Also, was this the very first upgrade attempt?

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3394 in reviewboard: Problem with upgrade from 1.7.22 to 2.0.1. Django evolution fails

2014-06-02 Thread reviewboard


Comment #2 on issue 3394 by rafal.wo...@gmail.com: Problem with upgrade  
from 1.7.22 to 2.0.1. Django evolution fails

http://code.google.com/p/reviewboard/issues/detail?id=3394

It is the very first attempt to upgrade this 1.7.22 version to 2.0.1. I am  
trying to test new 2.0.1 in testing environment separated from my 1.7.22  
production instance. I can migrate the database from production with  
mysqldump or restore the whole environment from backup but the error stops  
me every time and I do not know what could be wrong. This production  
instance was upgraded many times but never downgraded.



Applied evolutions for 'auth':
auth_delete_message
auth_unique_together_baseline

Applied evolutions for 'contenttypes':
contenttypes_unique_together_baseline

Applied evolutions for 'sessions':
session_expire_date_db_index

Applied evolutions for 'accounts':
is_private
timezone
open_an_issue
extra_data
timezone_length_30
localsiteprofile_permissions
unique_together_baseline
profile_show_closed

Applied evolutions for 'attachments':
file_attachment_orig_filename
file_attachment_file_max_length_512
file_attachment_repo_info
file_attachment_repo_path_no_index
file_attachment_repo_revision_max_length_64

Applied evolutions for 'changedescs':
fields_changed_longtext
rich_text

Applied evolutions for 'diffviewer':
add_parent_diffs
filediff_filenames_1024_chars
diffset_basedir
filediff_status
add_diff_hash
diffsethistory_diff_updated
diffset_base_commit_id
filediffdata_line_counts
filediffdata_extra_data
all_extra_data

Applied evolutions for 'hostingsvcs':
account_hosting_url
account_hosting_url_max_length_255
account_unique_together_baseline

Applied evolutions for 'reviews':
change_descriptions
last_review_timestamp
shipit_count
default_reviewer_repositories
null_repository
localsite
group_incoming_request_count
group_invite_only
group_visible
default_reviewer_local_site
add_issues_to_comments
file_attachments
file_attachment_comment_extra_data
review_request_last_review_activity_timestamp
review_request_depends_on
commit_id
file_attachment_comment_diff_id
rich_text
base_comment_extra_data
unique_together_baseline
extra_data
review_request_issue_counts
group_mailing_list_charfield
review_request_draft_commit_id

Applied evolutions for 'scmtools':
bugzilla_url_charfield
repository_raw_file_url
repository_visible
repository_path_length_255
localsite
repository_access_control
group_site
repository_hosting_accounts
repository_extra_data_null
unique_together_baseline

Applied evolutions for 'site':
localsite_public



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3394 in reviewboard: Problem with upgrade from 1.7.22 to 2.0.1. Django evolution fails

2014-06-02 Thread reviewboard


Comment #3 on issue 3394 by rafal.wo...@gmail.com: Problem with upgrade  
from 1.7.22 to 2.0.1. Django evolution fails

http://code.google.com/p/reviewboard/issues/detail?id=3394

After few more tries I managed to finish rb-site upgrade without any  
errors :) Unfortunately I cannot tell what I did wrong and what solved the  
problem, sorry.


At the moment I have another problem with formatting in review request  
window (please see attached image). Text areas seem to be badly formatted  
and too wide. It occurs only for migrated review requests. Newly created  
review requests look well, as it should.


I confirmed the formatting problem in chromium-browser, firefox and IE8.

Could it be upgrading/evolution related issue?

Attachments:
review_problem.png  21.9 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3395 in reviewboard: Password reset unsuccessful

2014-06-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3395 by ipe...@gmail.com: Password reset unsuccessful
http://code.google.com/p/reviewboard/issues/detail?id=3395

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!


What version are you running?
2.0.1

What's the URL of the page containing the problem?
https://reviews.reviewboard.org/account/reset/MzAxMDE-3s4-b1fd01d35d993ad1b3aa/

What steps will reproduce the problem?
1. Request a password reset
2. Click on the email link
3. Password reset unsuccessful.

What is the expected output? What do you see instead?
I expect a password reset form. Instead a message is displayed:
The password reset link was invalid, either because it expired or has  
already been used. Please request a new one here.


What operating system are you using? What browser?
Linux Mint 16, Chrome  33.0.1750.149

Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3396 in reviewboard: No logging in RB 1.7.25 - instead getting apache error

2014-06-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3396 by alexkb...@gmail.com: No logging in RB 1.7.25 - instead  
getting apache error

http://code.google.com/p/reviewboard/issues/detail?id=3396

What version are you running?
Review Board 1.7.25 on Centos 6.5 with Apache 2.2.15; Python 2.6. As best I  
can tell, I'm using Django 1.4.11 and Djblets 0.7.29.


What's the URL of the page containing the problem?
Running on local network (no public url)

What steps will reproduce the problem?
1. From web ui, create new review request assigned to self, with summary,  
description, and all other fields left blank

2. Publish request
3a. Navigate to admin panel  Server Log
3b. From ssh tunnel to server: list the contents of the error log directory  
(as specified from the web ui config pane under Admin  Logging)


What is the expected output? What do you see instead?
Expected to see something logged in the web ui; expected to see a log file  
in the log file directory. Log file from ui and log file directory are both  
empty. Instead, the apache error log contains:

[Mon Jun 02 17:32:53 2014] [error] Traceback (most recent call last):
[Mon Jun 02 17:32:53 2014] [error]
File /usr/lib64/python2.6/logging/__init__.py, line 776, in emit

[Mon Jun 02 17:32:53 2014] [error] msg = self.format(record)
[Mon Jun 02 17:32:53 2014] [error]
File /usr/lib64/python2.6/logging/__init__.py, line 654, in format

[Mon Jun 02 17:32:53 2014] [error] return fmt.format(record)
[Mon Jun 02 17:32:53 2014] [error]
File /usr/lib64/python2.6/logging/__init__.py, line 439, in format

[Mon Jun 02 17:32:53 2014] [error] s = self._fmt % record.__dict__
[Mon Jun 02 17:32:53 2014] [error] KeyError: 'request_info'

See below for additional details.

What operating system are you using? What browser?
See version section. Not browser related.

Please provide any additional information below.
Bug report requested by Christian Hammond after an email exchange, included  
below:


From: Christian Hammond chip...@chipx86.com
Subject: Re: 1.5 to 1.7 DB Migration
Date: May 30, 2014 at 3:45:40 PM MDT
To: alexkb...@gmail.com
Cc: reviewbo...@googlegroups.com reviewbo...@googlegroups.com

It's more likely to be a bug than a configuration issue. This code is old,  
though. I'm surprised people are starting to report issues here.


I need more of the traceback. Can you show me the entire trace, along with  
the exact repro case?


In fact, would you mind filing a bug with this information, so we can track  
it?


Christian

--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Fri, May 30, 2014 at 2:20 PM, alexkb...@gmail.com wrote:
I'm having a very similar problem to schmi...@gmail.com. I'm running Review  
Board 1.7.25 on Centos 6.5 with Apache 2.2.15; Python 2.6. As best I can  
tell, I'm using Django 1.4.11 and Djblets 0.7.29. (I found this by looking  
at __init__.py from the /usr/lib/python2.6/site-packages/djblets  
and ...django.) This is a new install of RB, not a migration from a  
previous version.


I have not been able to get the RB logging to do anything. I changed the  
settings from the admin panel as documented - nothing. (empty log files,  
nothing on the web ui Server Log.) I checked the ownership of the logging  
directory - apache user has write permissions. I know from some other  
debugging that the Apache server is running as the 'apache' user. To be  
really sure it wasn't a permission issue, I set the logging directory to  
/tmp - still nothing there and nothing from the web ui.


Next step was the apache error logs, which led me to this discussion. I am  
getting errors from /usr/lib64/python2.6/logging/__init__.py


I noticed that they at a different line number from schmi...@gmail.com's  
post, and that I'm using python 2.6 instead of 2.7.


Here is the apache error log snippet:
[Fri May 30 00:01:24 2014] [error] Traceback (most recent call last):
[Fri May 30 00:01:24 2014] [error]
File /usr/lib64/python2.6/logging/__init__.py, line 776, in emit

[Fri May 30 00:01:24 2014] [error] msg = self.format(record)
[Fri May 30 00:01:24 2014] [error]
File /usr/lib64/python2.6/logging/__init__.py, line 654, in format

[Fri May 30 00:01:24 2014] [error] return fmt.format(record)
[Fri May 30 00:01:24 2014] [error]
File /usr/lib64/python2.6/logging/__init__.py, line 439, in format

[Fri May 30 00:01:24 2014] [error] s = self._fmt % record.__dict__
[Fri May 30 00:01:24 2014] [error] KeyError: 'request_info'

A note on versions/install:
following the review board install instructions:  
http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/

Python: it says 2.5 or newer is acceptable , so I'm fine on that front.
CentOS: it supports it, but requires the EPEL package repository, which I  
have


However, I was not the one who installed RB, so I can't confirm that the  
install procedure was 

Re: Issue 3394 in reviewboard: Problem with upgrade from 1.7.22 to 2.0.1. Django evolution fails

2014-06-02 Thread reviewboard

Updates:
Status: SetupIssue

Comment #4 on issue 3394 by chip...@gmail.com: Problem with upgrade from  
1.7.22 to 2.0.1. Django evolution fails

http://code.google.com/p/reviewboard/issues/detail?id=3394

Can you please file a separate bug for the text areas? We keep bug reports  
to one incident per report.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3396 in reviewboard: No logging in RB 1.7.25 - instead getting apache error

2014-06-02 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 3396 by chip...@gmail.com: No logging in RB 1.7.25 -  
instead getting apache error

http://code.google.com/p/reviewboard/issues/detail?id=3396

Can you tell me what your web server configuration is like?

In particular, are you using mod_wsgi, or something else?

Are you using the worker MPM or the prefork MPM?

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3396 in reviewboard: No logging in RB 1.7.25 - instead getting apache error

2014-06-02 Thread reviewboard


Comment #2 on issue 3396 by alexkb...@gmail.com: No logging in RB 1.7.25 -  
instead getting apache error

http://code.google.com/p/reviewboard/issues/detail?id=3396

We're using prefork MPM and mod_wsgi

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.