Re: Issue 3397 in reviewboard: Wrong review request window formatting after upgrading from 1.7.22 to 2.0.1
Comment #2 on issue 3397 by rafal.wo...@gmail.com: Wrong review request window formatting after upgrading from 1.7.22 to 2.0.1 http://code.google.com/p/reviewboard/issues/detail?id=3397 I spent some time on investigating this issue and I already know how to reproduce it. Please have another look on the screen shoot attached to my previous post. I think the reviewers group is longer than usual, so this part of the form had to be expanded. Anyway, it is definitely caused by longer content of the review groups field. I've made another review request, brand new on Review Board 2.0.1 (attached) and the issue is reproduced with a very long name of reviewers group. Attachments: review_problem.png 18.3 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3398 in reviewboard: Error displaying this diff
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3398 by hith...@gmail.com: Error displaying this diff http://code.google.com/p/reviewboard/issues/detail?id=3398 What version are you running? 2,0,1 What's the URL of the page containing the problem? r/218/diff/# What steps will reproduce the problem? 1. Manually upload a diff 2. Go to diff section in review request 3. See There was an error displaying this diff. Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py, line 236, in get renderer = self.create_renderer(context, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/reviews/views.py, line 1102, in create_renderer *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py, line 326, in create_renderer self.diff_file = self._get_requested_diff_file() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/views.py, line 367, in _get_requested_diff_file request=self.request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 373, in populate_diff_chunks chunks = generator.get_chunks() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 148, in get_chunks large_data=True) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8-py2.7.egg/djblets/cache/backend.py, line 109, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 147, in lambda lambda: list(self._get_chunks_uncached()), File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py, line 155, in _get_chunks_uncached new = get_patched_file(old, self.filediff, self.request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 201, in get_patched_file return patch(diff, buffer, filediff.dest_file, request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.1-py2.7.egg/reviewboard/diffviewer/diffutils.py, line 139, in patch 'output': stderr, Exception: The patch to 'python/biicode/client/test/integration/publish/simple_publish_test.py' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.eEHskq' for debugging purposes. `patch` returned: What is the expected output? What do you see instead? The diff I uploaded, as it is What operating system are you using? Ubuntu 12.04 for the server, accessing from Mac or win What browser? Chrome -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3398 in reviewboard: Error displaying this diff
Comment #1 on issue 3398 by chip...@gmail.com: Error displaying this diff http://code.google.com/p/reviewboard/issues/detail?id=3398 You'll need to talk to your administrator about this. There's nothing we can do without the diff. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3398 in reviewboard: Error displaying this diff
Comment #2 on issue 3398 by hith...@gmail.com: Error displaying this diff http://code.google.com/p/reviewboard/issues/detail?id=3398 I'm my administrator, I don't know whats speciall about that diff and is happening with others as well -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3398 in reviewboard: Error displaying this diff
Comment #3 on issue 3398 by chip...@gmail.com: Error displaying this diff http://code.google.com/p/reviewboard/issues/detail?id=3398 Okay, my apologies. We get these questions a lot on here and they're usually from general users on a server. First thing to check is the files in the temp directory provided in that error. See if the diff looks correct, and whether the source file looks correct. Check the .rej file to see what failed to patch. You can also copy those files and attempt to patch the source file with the patch in the directory and see what patch says. These issues are often things like mixed line endings or some strangely generated patch, or sometimes an issue with what's returned from the repository (depending on how it's accessed and what type of repository). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3339 in reviewboard: 2.0RC3: ldap.open() is deprecated - use ldap.initialize() instead
Comment #2 on issue 3339 by bruce.c...@gmail.com: 2.0RC3: ldap.open() is deprecated - use ldap.initialize() instead http://code.google.com/p/reviewboard/issues/detail?id=3339 Should this have been fixed in 2.0.x? It appears it's only in master (https://github.com/reviewboard/reviewboard/blob/release-2.0.x/reviewboard/accounts/backends.py). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3371 in reviewboard: Minor UI bug on review request page with long field text
Updates: Summary: Minor UI bug on review request page with long field text Comment #2 on issue 3371 by trowb...@gmail.com: Minor UI bug on review request page with long field text http://code.google.com/p/reviewboard/issues/detail?id=3371 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3397 in reviewboard: Wrong review request window formatting after upgrading from 1.7.22 to 2.0.1
Updates: Status: Duplicate Mergedinto: 3371 Comment #3 on issue 3397 by trowb...@gmail.com: Wrong review request window formatting after upgrading from 1.7.22 to 2.0.1 http://code.google.com/p/reviewboard/issues/detail?id=3397 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3371 in reviewboard: Minor UI bug on review request page with long field text
Comment #3 on issue 3371 by trowb...@gmail.com: Minor UI bug on review request page with long field text http://code.google.com/p/reviewboard/issues/detail?id=3371 Issue 3397 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3399 in reviewboard: v2.0.1, RB throws LookupError in convert_to_unicode for ISO-8859 with CRLF file
Comment #1 on issue 3399 by bruce.c...@gmail.com: v2.0.1, RB throws LookupError in convert_to_unicode for ISO-8859 with CRLF file http://code.google.com/p/reviewboard/issues/detail?id=3399 The file contains a section symbol 'ยง' which is probably causing the problem, since it's non-ascii. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3339 in reviewboard: 2.0RC3: ldap.open() is deprecated - use ldap.initialize() instead
Comment #3 on issue 3339 by chip...@gmail.com: 2.0RC3: ldap.open() is deprecated - use ldap.initialize() instead http://code.google.com/p/reviewboard/issues/detail?id=3339 I just copied this to the 2.0 branch. It'll be part of the 2.0.2. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3399 in reviewboard: v2.0.1, RB throws LookupError in convert_to_unicode for ISO-8859 with CRLF file
Comment #2 on issue 3399 by bruce.c...@gmail.com: v2.0.1, RB throws LookupError in convert_to_unicode for ISO-8859 with CRLF file http://code.google.com/p/reviewboard/issues/detail?id=3399 Overriding the encoding to be utf-8 appears to have fixed (worked around?) the problem. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 921 in reviewboard: Add post-commit review submission to post-review for perforce
Comment #7 on issue 921 by erik.l...@gmail.com: Add post-commit review submission to post-review for perforce http://code.google.com/p/reviewboard/issues/detail?id=921 I don't think this change actually solves the problem. When you list a single CLN, it appears to treat it as a range of CLN-1 and CLN. In Perforce (unlike git) this is not the correct behavior as the two change lists can be completely unrelated. It looks like if you run the code with rbt post CLN CLN, it tries to do the right thing but for some reason isn't generating a diff for edit files, only added files (which p4 describe fails to do). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3400 in reviewboard: Unable to Download Diff
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3400 by davwill...@gmail.com: Unable to Download Diff http://code.google.com/p/reviewboard/issues/detail?id=3400 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? 1.7.24 What's the URL of the page containing the problem? https://hopper.rose.hp.com/r/7691/ What steps will reproduce the problem? 1. Click Download Diff 2. 3. What is the expected output? What do you see instead? Usually this downloads the .diff file, instead this is trying to download a .pl.patch file What operating system are you using? What browser? Windows Firefox 29.0.1 Please provide any additional information below. See attachmet Attachments: rbBug.png 188 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3400 in reviewboard: Unable to Download Diff
Updates: Status: NotABug Comment #1 on issue 3400 by trowb...@gmail.com: Unable to Download Diff http://code.google.com/p/reviewboard/issues/detail?id=3400 If a diff was uploaded by hand, the filename that it downloads from Download Diff will be whatever it was when the author uploaded it. It looks like they just used the .patch name instead of .diff, but it's the same file format. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
