Re: Issue 1636 in reviewboard: unterminated string literal JS error prevents loading diff lines corresponding to comments containing newlines

2010-05-06 Thread reviewboard

Updates:
Status: Fixed
Owner: chipx86
	Labels: -Priority-Medium Priority-Critical Milestone-Release1.5  
Component-Reviews


Comment #1 on issue 1636 by chipx86: unterminated string literal JS error  
prevents loading diff lines corresponding to comments containing newlines

http://code.google.com/p/reviewboard/issues/detail?id=1636

Committed to master (046ba74)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1609 in reviewboard: Add BitKeeper as a repository

2010-05-06 Thread reviewboard

Updates:
Labels: -Milestone-Release1.5

Comment #2 on issue 1609 by chipx86: Add BitKeeper as a repository
http://code.google.com/p/reviewboard/issues/detail?id=1609

Someone's going to need to write support for this. I don't have BitKeeper  
or any

BitKeeper experience.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1458 in reviewboard: User View on site button has broken path

2010-05-06 Thread reviewboard

Updates:
Status: UnableToReproduce

Comment #3 on issue 1458 by chipx86: User View on site button has broken  
path

http://code.google.com/p/reviewboard/issues/detail?id=1458

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1519 in reviewboard: Ignore emails for a review

2010-05-06 Thread reviewboard

Updates:
Labels: -Milestone-Release1.5

Comment #2 on issue 1519 by chipx86: Ignore emails for a review
http://code.google.com/p/reviewboard/issues/detail?id=1519

Someday, but probably will need a patch. The TODO list for the next couple  
releases

are quite busy.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 292 in reviewboard: Email should be asynchronous.

2010-05-06 Thread reviewboard


Comment #5 on issue 292 by assafla...@gmail.com: Email should be  
asynchronous.

http://code.google.com/p/reviewboard/issues/detail?id=292

I'm adding a vote to fix this: the fact that Publish takes a long time (5-7  
seconds)
means people press the button twice and get multiple posts. It's also a  
major annoyance
and it's hindering the adoption of this fantastic tool in the organization.  
I hope it

gets fixed sooner than 2.0...


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1281 in reviewboard: Adding comments in diff viewer can delete or overwrite existing comments.

2010-05-06 Thread reviewboard

Updates:
Status: Fixed
Owner: chipx86
Labels: Milestone-Release1.0.x

Comment #4 on issue 1281 by chipx86: Adding comments in diff viewer can  
delete or overwrite existing comments.

http://code.google.com/p/reviewboard/issues/detail?id=1281

Fixed on release-1.0.x and master.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1569 in reviewboard: Code review linebreaks are not preserved in all views (i.e. mail)

2010-05-06 Thread reviewboard

Updates:
Status: Fixed
Owner: chipx86

Comment #6 on issue 1569 by chipx86: Code review linebreaks are not  
preserved in all views (i.e. mail)

http://code.google.com/p/reviewboard/issues/detail?id=1569

Fixed on master (fc85106)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1610 in reviewboard: Some viewtype informations is glue to description when using ClearCase

2010-05-06 Thread reviewboard

Updates:
Status: Fixed
Owner: chipx86
Labels: Component-RBTools Milestone-RBTools-Release1.0

Comment #1 on issue 1610 by chipx86: Some viewtype informations is glue to  
description when using ClearCase

http://code.google.com/p/reviewboard/issues/detail?id=1610

Fixed on master (990d99e)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 292 in reviewboard: Email should be asynchronous.

2010-05-06 Thread reviewboard


Comment #8 on issue 292 by chipx86: Email should be asynchronous.
http://code.google.com/p/reviewboard/issues/detail?id=292

That's awfully slow for that few users. It might be worth putting some  
logging in
place to see where the slow part is (both analyzing the traffic to/from  
Exchange and

just logging around the mail sending code using log_timed).

We use Review Board with thousands of developers on a very busy Exchange  
server and
haven't hit slowdowns like this, so I'm really curious as to what's going  
on.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1640 in reviewboard: one-click Ship It button

2010-05-06 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 1640 by assafla...@gmail.com: one-click Ship It button
http://code.google.com/p/reviewboard/issues/detail?id=1640

*NOTE: If you have a patch, please submit it to
http://reviews.reviewboard.org/


What version are you running?
1.0.6

What's the URL of the page this enhancement relates to, if any?
Review request page.

Describe the enhancement and the motivation for it.
When a change passes review I need to click on Review, then check Ship it
and then click on publish (which is annoyingly slow, but that's beside the
point). This means 3 clicks, and I do this over and over.

I suggest a dedicated button Ship It right beside the Review button.
Clicking on it immediately publishes the review with Ship it status. I
think it's not very risky if you can revert any mistaken click. But it
would save me tons of clicks.

What operating system are you using? What browser?


Please provide any additional information below.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1437 in reviewboard: ReviewBoard Installation failed on Windows XP SP2 VMWare.

2010-05-06 Thread reviewboard


Comment #7 on issue 1437 by chipx86: ReviewBoard Installation failed on  
Windows XP SP2 VMWare.

http://code.google.com/p/reviewboard/issues/detail?id=1437

What you an do right now is run easy_install on another server with the -b
/path/to/download/location option. I believe this works, but this is just  
from

reading the docs.

We have someone working on a new installer that hopefully be available in a  
few
months. One of the goals is to make it easier to download everything that's  
needed so

it can be easily installed elsewhere.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1637 in reviewboard: Review Board + perforce can not upload diff

2010-05-06 Thread reviewboard


Comment #3 on issue 1637 by chipx86: Review Board + perforce can not upload  
diff

http://code.google.com/p/reviewboard/issues/detail?id=1637

Sorry, still want --debug in there. I need to see everything that hte debug  
output
says (though you can mask the domain names if you want). All the paths and  
everything

else must be there in the debug log though.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1613 in reviewboard: G8

2010-05-06 Thread reviewboard

Updates:
Status: Invalid

Comment #1 on issue 1613 by trowbrds: G8
http://code.google.com/p/reviewboard/issues/detail?id=1613

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.