Re: Issue 1133 in reviewboard: API to obtain the logged in user's name.

2010-06-14 Thread reviewboard

Updates:
Status: Fixed

Comment #7 on issue 1133 by chipx86: API to obtain the logged in user's  
name.

http://code.google.com/p/reviewboard/issues/detail?id=1133

Added a new /api/session/ resource, which points to the logged in user.

Committed to master (66b2f8c)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1536 in reviewboard: Enabling Active Directory causes complete lockout (even local superuser cannot log back in)

2010-06-14 Thread reviewboard

Updates:
Status: NeedInfo
Labels: Component-Accounts

Comment #3 on issue 1536 by chipx86: Enabling Active Directory causes  
complete lockout (even local superuser cannot log back in)

http://code.google.com/p/reviewboard/issues/detail?id=1536

I don't know if you ever found a good solution to this problem or if it's  
happened since, but the only cases I've found where this would happen is  
when the Active Directory server had an entry for the admin user you're  
trying to log in as, which would take precedence and prevent the login from  
the built-in user database. That would also explain the lack of log  
messages, because as far as the auth backend is concerned, the user *does*  
exist and the password was simply wrong. There's nothing we can do about  
this.


Any way you can check if this is indeed the problem?

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1541 in reviewboard: Multibyte characters in diff fragments are broken with syntax highlighting.

2010-06-14 Thread reviewboard

Updates:
Status: Fixed
Owner: chipx86

Comment #7 on issue 1541 by chipx86: Multibyte characters in diff fragments  
are broken with syntax highlighting.

http://code.google.com/p/reviewboard/issues/detail?id=1541

Committed to master (2720c7d)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it

2010-06-14 Thread reviewboard


Comment #14 on issue 394 by msbcode: if a diff includes a file that has  
been cvs remove'd, reviewboard won't accept it

http://code.google.com/p/reviewboard/issues/detail?id=394

As mentioned above I seem to be having this same issue with ReviewBoard  
1.0.8 and a CVS project.


Please let me know if I should file this as a separate issue.

Attached is the output from running post-review with the --output-diff  
switch. Note I've edited out the empty output from CVS like cvs diff:  
Diffing web/css for directories in which there were no change. The diff  
should show that I removed one file (build.properties) and edited two  
others.


The output from attempting to upload this change to reviewboard with  
post-review is:


HTTP POSTing to  
http://localhost/reviewboard/api/json/reviewrequests/new/:  
{'repository_path': 'cvshost:/cvsroot/gotoaudio'}

Review request created
Attempting to set field 'summary' to 'g2atest 2' for review request '32'
HTTP POSTing to  
http://localhost/reviewboard/api/json/reviewrequests/32/draft/set/:  
{'summary': 'g2atest 2'}

Uploading diff, size: 14196
HTTP POSTing to  
http://localhost/reviewboard/api/json/reviewrequests/32/diff/new/: {}
Got API Error 207 (HTTP code 200): The file was not found in the  
repository
Error data: {u'stat': u'fail', u'file': u'build.properties', u'err':  
{u'msg': u'The file was not found in the repository', u'code': 207},  
u'revision': u'1.8'}


Error uploading diff

Your review request still exists, but the diff is not attached.


Is there any other data I could supply which would be useful to help  
troubleshoot this?


Attachments:
diff.txt  2.3 KB

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1587 in reviewboard: Some lines don't word-wrap correctly on IE/Chrome

2010-06-14 Thread reviewboard


Comment #3 on issue 1587 by seagle0128: Some lines don't word-wrap  
correctly on IE/Chrome

http://code.google.com/p/reviewboard/issues/detail?id=1587

Please refer to the attachments.

Attachments:
ie.PNG  100 KB
firefox.PNG  148 KB

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it

2010-06-14 Thread reviewboard

Updates:
Status: Confirmed
Labels: -PendingReview Milestone-Release1.5

Comment #15 on issue 394 by chipx86: if a diff includes a file that has  
been cvs remove'd, reviewboard won't accept it

http://code.google.com/p/reviewboard/issues/detail?id=394

Looks like we need to make sure when we see the +++ /dev/null line that  
we should mark the file as deleted and not attempt to open it.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.