Issue 1719 in reviewboard: post-review should support subversion changelists.
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1719 by phil.cornelius: post-review should support subversion changelists. http://code.google.com/p/reviewboard/issues/detail?id=1719 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? 1.0.5.1 What's the URL of the page this enhancement relates to, if any? Describe the enhancement and the motivation for it. Subversion v1.5 and above support changelists for associating files. This is supported in the svn diff command with --changelist option. It should be supported by post-review to allow the user to post a new review with the diffs from only those files identified by a provided changelist name. This would make the post-review tool much more useful in a subversion environment. What operating system are you using? What browser? Mac OS X, Safari Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #10 on issue 839 by paul.dubois: Option to convert tabs in the diff
to (n) spaces
http://code.google.com/p/reviewboard/issues/detail?id=839
Same issue as max9219. We modified PerforceClient in postreview.py to do
tab-expansion before diffing, and got patch failures after/upon upload.
chipx86, when you suggest do[ing] it in postreview was there a
corresponding server-side change you had in mind to get around the patch
failure?
I can confirm that adding
pre {
-moz-tab-size: 4;
-o-tab-size: 4;
}
to diffviewer.css gives reasonable results in opera; moz4 is untested.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1720 in reviewboard: Submitters does not work
Comment #1 on issue 1720 by eduardo.macalinao: Submitters does not work http://code.google.com/p/reviewboard/issues/detail?id=1720 My mistake. Internal server issue. Please close this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1720 in reviewboard: Submitters does not work
Comment #2 on issue 1720 by eduardo.macalinao: Submitters does not work http://code.google.com/p/reviewboard/issues/detail?id=1720 My mistake. This was an internal server issue. Could you please close (preferably delete) this issue? Thanks. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1720 in reviewboard: Submitters does not work
Updates: Status: SetupIssue Comment #3 on issue 1720 by trowbrds: Submitters does not work http://code.google.com/p/reviewboard/issues/detail?id=1720 Sure thing. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
