Re: Issue 1939 in reviewboard: .sj Files are being displayed as binary files (despite being text format files) in review board

2011-03-14 Thread reviewboard


Comment #2 on issue 1939 by rahulrst...@gmail.com: .sj Files are being  
displayed as binary files (despite being text format files) in review board

http://code.google.com/p/reviewboard/issues/detail?id=1939

Yes. The repository looks fine to me. We use perforce as the  
repository...


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 629 in reviewboard: Allow users to create/manage their own groups in addition to the admin groups

2011-03-14 Thread reviewboard


Comment #8 on issue 629 by vignesh@gmail.com: Allow users to  
create/manage their own groups in addition to the admin groups

http://code.google.com/p/reviewboard/issues/detail?id=629

This could be a great feature, as I always work on different features of a  
product and I want different people from different team ( already created  
as Review board groups ) to review my code. Now I have a text file to  
organize this with list of names and whenever I submit the code I copy  
paste it to the People text box.


But I was wondering if requesting new groups to be added by Admin could be  
a better idea in this scenario, as with the help of such group I try to  
organize myself and getting Admin involved in this could be an overhead


I hope this could be a simple personal distribution list kind of thing,  
where I could add / delete a list and add / delete members to it.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1939 in reviewboard: .sj Files are being displayed as binary files (despite being text format files) in review board

2011-03-14 Thread reviewboard


Comment #3 on issue 1939 by chip...@gmail.com: .sj Files are being  
displayed as binary files (despite being text format files) in review board

http://code.google.com/p/reviewboard/issues/detail?id=1939

Review Board itself doesn't make the determination as to whether it's a  
text file or binary file, so it's definitely coming from your repository or  
your diff tool.


You can verify this with 'post-review --output-diff changenum

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1222 in reviewboard: Set static FROM address for e-mails

2011-03-14 Thread reviewboard


Comment #2 on issue 1222 by szim...@szimano.org: Set static FROM address  
for e-mails

http://code.google.com/p/reviewboard/issues/detail?id=1222

I would like to vote for reopening, as sometimes the smtp server blocks all  
emails outside it's realm to be used as from so If not all users are on  
the same domain (which happens often) then the emails are blocked.


It's better to have the threading broken, then not getting any emails at  
all IMO ;-)


Please think about it again.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1939 in reviewboard: .sj Files are being displayed as binary files (despite being text format files) in review board

2011-03-14 Thread reviewboard


Comment #4 on issue 1939 by rahulrst...@gmail.com: .sj Files are being  
displayed as binary files (despite being text format files) in review board

http://code.google.com/p/reviewboard/issues/detail?id=1939

I just verfied it..
Looks like there is a problem in the diff tool.
The tool which we are using to generate the diff is P5.
diff file doesn't contain the text for .sj files


Thanks for the clarification..

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2024 in reviewboard: MultipleObjectsReturned: get() returned more than one ReviewRequest

2011-03-14 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2024 by m.milbr...@gmail.com: MultipleObjectsReturned: get()  
returned more than one ReviewRequest

http://code.google.com/p/reviewboard/issues/detail?id=2024

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.5.4


What's the URL of the page containing the problem?
https://reviewboard_host/r/new/


What steps will reproduce the problem?
I'm just receiving the errors so am not positive of the exact steps to  
reproduce but as indicated in an email thread in  
reviewbo...@googlegroups.com is most likely using the creation form.



What is the expected output? What do you see instead?


What operating system are you using? What browser?
Linux/Chrome


Please provide any additional information below.

2011-03-14 09:28:19,338 - ERROR - Exception thrown for user X
at https:///r/new/

get() returned more than one ReviewRequest -- it returned 4! Lookup
parameters were {'changenum': 18332}
Traceback (most recent call last):
  
File /build/toolchain/noarch/django-1.2.5/lib/python2.6/site-packages/django/core/handlers/base.py,

line 100, in get_response
   response = callback(request, *callback_args, **callback_kwargs)
  
File /build/toolchain/noarch/Djblets-0.6.7/lib/python2.6/site-packages/Djblets-0.6.7-py2.6.egg/djblets/auth/util.py,

line 46, in _checklogin
   return view_func(request, *args, **kwargs)
  
File /build/toolchain/noarch/reviewboard-1.5.4.1/ReviewBoard-1.5.4.1-py2.6.egg/reviewboard/reviews/views.py,

line 68, in new_review_request
   parent_diff_file=request.FILES.get('parent_diff_path'))
  
File /build/toolchain/noarch/reviewboard-1.5.4.1/ReviewBoard-1.5.4.1-py2.6.egg/reviewboard/reviews/forms.py,

line 166, in create
   review_request = ReviewRequest.objects.get(changenum=changenum)
  
File /build/toolchain/noarch/django-1.2.5/lib/python2.6/site-packages/django/db/models/manager.py,

line 132, in get
   return self.get_query_set().get(*args, **kwargs)
  
File /build/toolchain/noarch/django-1.2.5/lib/python2.6/site-packages/django/db/models/query.py,

line 349, in get
   % (self.model._meta.object_name, num, kwargs))
MultipleObjectsReturned: get() returned more than one ReviewRequest --
it returned 4! Lookup parameters were {'changenum': 18332}

mysql select id, submitter_id, repository_id, changenum from
reviews_reviewrequest where changenum = 18332;
++--+---+---+
| id | submitter_id | repository_id | changenum |
++--+---+---+
|  18284 |   28 | 2 | 18332 |
|  24555 | 1158 |10 | 18332 |
| 216485 | 3484 |14 | 18332 |
| 128542 |  767 |25 | 18332 |
++--+---+---+


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2005 in reviewboard: IE support broken in 1.6beta1

2011-03-14 Thread reviewboard


Comment #2 on issue 2005 by d...@n-cube.org: IE support broken in 1.6beta1
http://code.google.com/p/reviewboard/issues/detail?id=2005

Yes, I'm logged in. In fact, it does appear as if I am not logged in for  
the review, though since none of the fields are editable. The top status  
line shows I am logged in and the green bar is available to publish the  
review request.


I tested this with a fresh devserver, and it did not reproduce the problem,  
so it seems it's not quite so simple.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2005 in reviewboard: IE support broken in 1.6beta1

2011-03-14 Thread reviewboard


Comment #3 on issue 2005 by d...@n-cube.org: IE support broken in 1.6beta1
http://code.google.com/p/reviewboard/issues/detail?id=2005

I've cleared all cookies so that's not the issue. I've narrowed down the  
problem to somehow be related to having the site in the local intranet  
zone. If I remove it, the edit icons magically appear next to the fields.  
If I put it back into the zone, they go away. I'm trying to get the request  
headers to compare, but wireshark isn't cooperating with decoding the  
ssl... I also tried changing the security settings to match the internet  
zone without any behavior change.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2005 in reviewboard: IE support broken in 1.6beta1

2011-03-14 Thread reviewboard


Comment #4 on issue 2005 by trowb...@gmail.com: IE support broken in  
1.6beta1

http://code.google.com/p/reviewboard/issues/detail?id=2005

It sounds like it's probably having trouble loading some of the javascript  
files. Does IE8 have any debugging tools that can show you what's loading  
and what's not?


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.