Issue 2059 in reviewboard: Enhancement of expanding hidden lines

2011-04-06 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2059 by jianjun@gmail.com: Enhancement of expanding hidden  
lines

http://code.google.com/p/reviewboard/issues/detail?id=2059

*NOTE: If you have a patch, please submit it to
http://reviews.reviewboard.org/


What version are you running?
1.5.4.1

What's the URL of the page this enhancement relates to, if any?


Describe the enhancement and the motivation for it.
The reviewboard will hide a number of lines between the diff lines, from  
several to thousands of lines depending on the code change, users have only  
one option to Expand all the hidden line even if there are thousands of,  
then have to go back to find where they were before. It's could be fine if  
we design a Expand 100 lines for the big hidden blocks, then users will  
find it easy to go back the diff lines and have a better context review.


What operating system are you using? What browser?
Not OS related, Firefox is used.

Please provide any additional information below.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2060 in reviewboard: Not possible to send 2nd revision for a code review

2011-04-06 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2060 by alexande...@gmail.com: Not possible to send 2nd revision  
for a code review

http://code.google.com/p/reviewboard/issues/detail?id=2060

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.0

What's the URL of the page containing the problem?
http://codereview.nimone.com/api/json/reviewrequests/23307/update_from_changenum/.HTTP  
Error  
500: INTERNAL SERVER ERROR



What steps will reproduce the problem?
1. send a changelist for review
2. send the same changelist again

What is the expected output? What do you see instead?
Unable to access  
http://codereview.nimone.com/api/json/reviewrequests/23307/update_from_changenum/.  
The host path may be invalid

HTTP Error 500: INTERNAL SERVER ERROR


What operating system are you using? What browser?
Tried on both Win and Linux.


Please provide any additional information below.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2062 in reviewboard: Clicking on links changes to edit mode instead of opening the link in the browser

2011-04-06 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2062 by the...@gmail.com: Clicking on links changes to edit mode  
instead of opening the link in the browser

http://code.google.com/p/reviewboard/issues/detail?id=2062

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.5.4

What's the URL of the page containing the problem?
rb/r/X

What steps will reproduce the problem?
Putting a url, etc in the summary creates a link.  If you're looking at a  
review that you have permission to edit (either because you're an admin or  
because you created the review), clicking on the link switches the summary  
box to edit mode.


What is the expected output? What do you see instead?
Expect the browser to follow the link, instead of editing the summary.


What operating system are you using? What browser?
See this for both firefox  chromium on linux.  In chromium, middle click  
to open tab ALSO displays this behavior (doesn't open new tab, just moves  
into edit mode).  In both, right click on the link allows to open in new  
tab/window.


Please provide any additional information below.

seems related, but not quite the same as issue 1893

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 342 in reviewboard: Allow incremental expansion of collapsed code blocks

2011-04-06 Thread reviewboard


Comment #12 on issue 342 by trowb...@gmail.com: Allow incremental expansion  
of collapsed code blocks

http://code.google.com/p/reviewboard/issues/detail?id=342

Issue 2059 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1893 in reviewboard: Fields shouldn't become editable when selecting text or clicking hyperlinks

2011-04-06 Thread reviewboard


Comment #9 on issue 1893 by trowb...@gmail.com: Fields shouldn't become  
editable when selecting text or clicking hyperlinks

http://code.google.com/p/reviewboard/issues/detail?id=1893

Issue 2062 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2062 in reviewboard: Clicking on links changes to edit mode instead of opening the link in the browser

2011-04-06 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 1893

Comment #1 on issue 2062 by trowb...@gmail.com: Clicking on links changes  
to edit mode instead of opening the link in the browser

http://code.google.com/p/reviewboard/issues/detail?id=2062

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1893 in reviewboard: Fields shouldn't become editable when selecting text or clicking hyperlinks

2011-04-06 Thread reviewboard

Updates:
	Summary: Fields shouldn't become editable when selecting text or clicking  
hyperlinks


Comment #8 on issue 1893 by trowb...@gmail.com: Fields shouldn't become  
editable when selecting text or clicking hyperlinks

http://code.google.com/p/reviewboard/issues/detail?id=1893

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2061 in reviewboard: can not view diff and post-review

2011-04-06 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 2061 by trowb...@gmail.com: can not view diff and  
post-review

http://code.google.com/p/reviewboard/issues/detail?id=2061

How was this review request created? It sounds like a patch was updated  
that wasn't based off of the code in your github repository.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.