Re: Issue 2118 in reviewboard: Posting reviewrequest using post-review getting error

2011-06-02 Thread reviewboard


Comment #3 on issue 2118 by nileshj...@gmail.com: Posting reviewrequest  
using post-review getting error

http://code.google.com/p/reviewboard/issues/detail?id=2118

Thank your for your prompt response.

We don't use P4PASSWD, for user it creates p4tickets. which contains the  
user id and its ticket for respective user.


I got stuck now.

Also in the reviewboard administration section

Home › Scmtools › Repositories › pf-sa-1666

Where the details of respository hosting is present does it requires any  
configuration i have added.


Hosting service: custom
Repository type:Perforce
Path: pf-sa.shsho.com:1666

Mirror Path:

Username: njaiswal

Password:
Does it requires anything else which i am missing.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2122 in reviewboard: Allow for flexibility in LDAP name auto population

2011-06-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2122 by j...@gmail.com: Allow for flexibility in LDAP name auto  
population

http://code.google.com/p/reviewboard/issues/detail?id=2122

What version are you running?
1.6beta2.1

What's the URL of the page this enhancement relates to, if any?
http://reviews.zynga.com/admin/settings/authentication/


Describe the enhancement and the motivation for it.
Allow for more flexibility in which fields should be used as first and last  
names for LDAP.  While the RFCs and most standard setups have a standard  
set of attributes (sn and givenName), this is not mandated and should be  
flexible.



What operating system are you using? What browser?
NA

Please provide any additional information below.
Proposed change submitted:
* http://reviews.reviewboard.org/r/2389/

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2123 in reviewboard: Support for Multiple SSH Keys

2011-06-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2123 by phil.or...@gmail.com: Support for Multiple SSH Keys
http://code.google.com/p/reviewboard/issues/detail?id=2123

What version are you running?
1.5.5

What's the URL of the page this enhancement relates to, if any?
/admin/db/scmtools/repository/

Describe the enhancement and the motivation for it.
Prior to the addition of rbssh, administrators were able to set per-host  
SSH keys via ~/.ssh/config.


What operating system are you using? What browser?
Server is running CentOS 5.  Browser is irrelevant for this.

Please provide any additional information below.
In the reviewboard user's .ssh/config file, one could add:

  Host svn.example.com
IdentityFile ~/.ssh/svn.example.com.key

to set a custom key for a particular server, while still allowing the  
default .ssh/id_dsa key for other hosts.  Paramiko appears to support SSH  
config files, and should allow rbssh to use the .ssh/config file.   
Unfortunately, sshutils doesn't seem to really support the idea of having  
keys listed other than id_dsa and id_rsa.


Some options:

* Modify sshutils and rbssh to properly use the .ssh/config.
* Modify the repository definition tables to allow a per-repository ssh key.
* Allow users to bypass rbssh to use the system ssh, which will honor  
the .ssh/config.


I'll be working on the first item for the moment.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2098 in reviewboard: Add image to comments

2011-06-02 Thread reviewboard


Comment #2 on issue 2098 by da.s...@gmail.com: Add image to comments
http://code.google.com/p/reviewboard/issues/detail?id=2098

Sorry! I reported this request twice, thanks for merging.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2123 in reviewboard: Support for Multiple SSH Keys

2011-06-02 Thread reviewboard


Comment #1 on issue 2123 by phil.or...@gmail.com: Support for Multiple SSH  
Keys

http://code.google.com/p/reviewboard/issues/detail?id=2123

Posted a patch and a review request, http://reviews.reviewboard.org/r/2391/

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2124 in reviewboard: Add search functionality to the user and group pages.

2011-06-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2124 by josh.hamacher: Add search functionality to the user and  
group pages.

http://code.google.com/p/reviewboard/issues/detail?id=2124

What version are you running?
1.5

What's the URL of the page this enhancement relates to, if any?
https://.../users/
https://.../groups/

Describe the enhancement and the motivation for it.
We have a fairly large installation, with about 170 pages of users and 130  
pages of groups.


Needless to say, the large number of groups makes it extremely impractical  
to find a group to follow; since they're ordered, you can usually guess  
about what page a group would fall on, but there are still a lot of  
clicks.  Adding a search box would definitely ease this process for us.


It seems like the user page should get a search box as well, although this  
is a less common task for us.  Generally we only have to look up a user  
when someone joins our team and needs admin privileges.


What operating system are you using? What browser?
Red Hat Enterprise Linux on the server, although that shouldn't matter.

Please provide any additional information below.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1431 in reviewboard: Need support for TortoiseSVN diffs

2011-06-02 Thread reviewboard


Comment #13 on issue 1431 by ben.al...@gmail.com: Need support for  
TortoiseSVN diffs

http://code.google.com/p/reviewboard/issues/detail?id=1431

We use ReviewBoard with TortoiseSVN and have found that TSVN gives you  
multiple ways to produce a diff, but only one produces a unified diff in  
the correct format for ReviewBoard.


In general, any way of creating a diff through the TortoiseMerge utility  
(which is the default utility for viewing diffs in Tortoise) resulted in a  
diff that was not formatted correctly for ReviewBoard.  It appears that  
TortoiseMerge's diff treats the two files as simply files on your hard  
drive (not as a working copy and a pristine copy, like the svn diff  
command does) and doesn't create the header with the information that  
ReviewBoard needs.  I suspect that many other diff programs will have this  
same problem.


Instead, if you right click - TortoiseSVN submenu - Create Patch...,  
this WILL create a diff in the unified diff format expected by  
ReviewBoard.  This command appears to use the svn diff command to create  
the diff (instead of doing the comparison itself), which is what  
ReviewBoard is expecting.


In case it's important, we're using ReviewBoard 1.6beta2 and TortoiseSVN  
1.6.15



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2125 in reviewboard: Page elements overlap when review request summary is too long

2011-06-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2125 by ben.al...@gmail.com: Page elements overlap when review  
request summary is too long

http://code.google.com/p/reviewboard/issues/detail?id=2125

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.6beta2

What's the URL of the page containing the problem?
reviews.oursite.com/admin/db/reviews/review/

What steps will reproduce the problem?
1. Create a review request with a really long name (ours was ~150  
characters)

2. Visit the admin page at /admin/db/reviews/review/

What is the expected output? What do you see instead?
The Filter box on the right-hand side of the page is floating on top of  
the last column of the table (see attached screenshot).  If you zoom the  
page out far enough, the table will display correctly.


The problem seems to be that the CSS for the td elements in the table is  
specifying white-space:nowrap;.  Either the text should be allowed to  
wrap, or the page should truncate the summary after a certain point (like  
the /admin/db/reviews/comment/ page does for comments).



What operating system are you using? What browser?
Windows 7 64-bit with Firefox 4.0.1, also confirmed in IE9


Please provide any additional information below.
See attached screenshot

Attachments:
admin_page_screenshot.png  102 KB

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.