Issue 2624 in reviewboard: Restaurants Restoration P2 code patch review

2012-06-05 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2624 by z...@tripadvisor.com: Restaurants Restoration P2 code  
patch review

http://code.google.com/p/reviewboard/issues/detail?id=2624

The requirements in this project are
1. modify restaurant search listing page style like as hotel listing page
2. add a restaurant tab in search page
3. add a restaurant link in city search page
4. remove 'DaRen'
5. add operation time and cuisine in restaurant detail page.

Attachments:
7701_restaurant-p2-trsrc.patch  3.1 KB
7701_restaurant-p2-daodao.patch  25.9 KB

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2624 in reviewboard: Restaurants Restoration P2 code patch review

2012-06-05 Thread reviewboard


Comment #1 on issue 2624 by z...@tripadvisor.com: Restaurants Restoration  
P2 code patch review

http://code.google.com/p/reviewboard/issues/detail?id=2624

sorry, goole.
I am a new user of review board.
This not the bug of your product.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2624 in reviewboard: Restaurants Restoration P2 code patch review

2012-06-05 Thread reviewboard


Comment #2 on issue 2624 by chip...@gmail.com: Restaurants Restoration P2  
code patch review

http://code.google.com/p/reviewboard/issues/detail?id=2624

We host the bug tracker on Google, but Review Board is unrelated to Google.

I'll go ahead and delete your report.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2625 in reviewboard: Database evolution fails from 1.6.6 to 1.6.7 on mysql

2012-06-05 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2625 by frank.he...@sinnerschrader.com: Database evolution fails  
from 1.6.6 to 1.6.7 on mysql

http://code.google.com/p/reviewboard/issues/detail?id=2625

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.6.6 upgrading to 1.6.7

What steps will reproduce the problem?
1. rb-site upgrade 
2.
3.

What is the expected output? What do you see instead?
I expected the evolution to succeed, but i get an error:
Error: Error applying evolution: (1101, BLOB/TEXT column 'extra_data'  
can't have a default value)


What operating system are you using? What browser?
Debian 6.0
Linux revboard01 2.6.32-5-xen-amd64 #1 SMP Sun May 6 08:57:29 UTC 2012  
x86_64 GNU/Linux


Please provide any additional information below.
Python 2.6.6 (r266:84292, Dec 26 2010, 22:31:48)
mysql 5.1.61-0+squeeze1
both debian packages


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2625 in reviewboard: Database evolution fails from 1.6.6 to 1.6.7 on mysql

2012-06-05 Thread reviewboard

Updates:
Status: Fixed
Owner: chip...@gmail.com
Labels: -Priority-Medium Priority-Critical Milestone-Release1.6.x

Comment #1 on issue 2625 by chip...@gmail.com: Database evolution fails  
from 1.6.6 to 1.6.7 on mysql

http://code.google.com/p/reviewboard/issues/detail?id=2625

Looks like this fails with certain versions of MySQL. I've put in a fix and  
am doing a 1.6.7.1. release right now. You should be able to upgrade in 5  
minutes. Thanks for reporting this.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2626 in reviewboard: Something broke! (Error 500)

2012-06-05 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2626 by cmni...@gmail.com: Something broke! (Error 500)
http://code.google.com/p/reviewboard/issues/detail?id=2626

What version are you running?
1.5.1

What's the URL of the page containing the problem?

Error Code: 500

Error Text: Internal Server Error

Request URL: /api/json/reviewrequests/634/diff/2/file/3187/line/1/comments/

Request Data: action=setnum_lines=1text=Test


What steps will reproduce the problem?
1. Error produces when commenting a source code during the code review
2.
3.

What is the expected output? What do you see instead?


DoesNotExist at  
/api/json/reviewrequests/634/diff/2/file/3187/line/1/comments/


Review matching query does not exist.

Request Method: POST
Request URL: 	 
http://192.168.2.5/api/json/reviewrequests/634/diff/2/file/3187/line/1/comments/

Django Version: 1.2.4
Exception Type: DoesNotExist
Exception Value:

Review matching query does not exist.

Exception Location: 	 
/usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/django/db/models/query.py  
in get, line 347

Python Executable:  /usr/bin/python
Python Version: 2.6.5
Python Path: 	 
['/var/www/reviews.nucore.com/conf', '/usr/local/lib/python2.6/dist-packages/python_memcached-1.47-py2.6.egg', '/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.1-py2.6.egg', '/usr/local/lib/python2.6/dist-packages/recaptcha_client-1.0.5-py2.6.egg', '/usr/local/lib/python2.6/dist-packages/pytz-2010o-py2.6.egg', '/usr/local/lib/python2.6/dist-packages/python_dateutil-1.5-py2.6.egg', '/usr/local/lib/python2.6/dist-packages/paramiko-1.7.6-py2.6.egg', '/usr/local/lib/python2.6/dist-packages/flup-1.0.3.dev_20100525-py2.6.egg', '/usr/local/lib/python2.6/dist-packages/Pygments-1.3.1-py2.6.egg', '/usr/local/lib/python2.6/dist-packages/Djblets-0.6.6-py2.6.egg', '/usr/local/lib/python2.6/dist-packages/django_evolution-0.6.2-py2.6.egg', '/usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg', '/usr/local/lib/python2.6/dist-packages/pycrypto-2.3-py2.6-linux-x86_64.egg', '/usr/local/lib/python2.6/dist-packages/PIL-1.1.6-py2.6-linux-x86_64.egg', '/usr/lib/python2.6', '/usr/lib/python2.6/plat-linux2', '/usr/lib/python2.6/lib-tk', '/usr/lib/python2.6/lib-old', '/usr/lib/python2.6/lib-dynload', '/usr/lib/python2.6/dist-packages', '/usr/lib/pymodules/python2.6', '/usr/lib/pymodules/python2.6/gtk-2.0', '/usr/local/lib/python2.6/dist-packages']

Server time:Tue, 5 Jun 2012 22:10:11 -0700
Traceback Switch to copy-and-paste view

 
/usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/django/core/handlers/base.py  
in get_response

response = callback(request, *callback_args, **callback_kwargs) ...
▶ Local vars
 
/usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/django/views/decorators/cache.py  
in _wrapped_view_func

response = view_func(request, *args, **kwargs) ...
▶ Local vars
 
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.1-py2.6.egg/reviewboard/webapi/decorators.py  
in _view

response = view_func(*args, **kwargs) ...
▶ Local vars
 
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.1-py2.6.egg/reviewboard/webapi/decorators.py  
in _check

return webapi_login_required(view_func)(*args, **kwargs) ...
▶ Local vars
 
/usr/local/lib/python2.6/dist-packages/Djblets-0.6.6-py2.6.egg/djblets/webapi/decorators.py  
in _checklogin

response = view_func(*args, **kwargs) ...
▶ Local vars
 
/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.1-py2.6.egg/reviewboard/webapi/json.py  
in diff_line_comments

base_reply_to__isnull=True) ...
▶ Local vars
 
/usr/local/lib/python2.6/dist-packages/Djblets-0.6.6-py2.6.egg/djblets/util/db.py  
in get_or_create

return self.get(**kwargs) ...
▶ Local vars
 
/usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/django/db/models/manager.py  
in get

return self.get_query_set().get(*args, **kwargs) ...
▶ Local vars
 
/usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/django/db/models/query.py  
in get

if self.query.can_filter():
clone = clone.order_by()
num = len(clone)
if num == 1:
return clone._result_cache[0]
if not num:
raise self.model.DoesNotExist(%s matching query does not exist.
% self.model._meta.object_name) ...
raise self.model.MultipleObjectsReturned(get() returned more than  
one %s -- it returned %s! Lookup parameters were %s

% (self.model._meta.object_name, num, kwargs))
def create(self, **kwargs):

Creates a new object with the given kwargs, saving it to the  
database

▶ Local vars

Request information
GET

No GET data
POST
VariableValue
action  
u'set'
text
u'Test'
api_format  
u'json'
num_lines   
u'1'
FILES

No FILES data
COOKIES
Variable