Issue 2760 in reviewboard: Diffviewer produces error String incdices must be integers, not str

2012-10-05 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2760 by robert.suij...@gmail.com: Diffviewer produces  
error String incdices must be integers, not str

http://code.google.com/p/reviewboard/issues/detail?id=2760

What version are you running? 1.6.13


What's the URL of the page containing the problem?
http://server/r/2476/diff/#index_header

What steps will reproduce the problem?
1. Upgrade from 1.6.9 to 1.6.13 (used pip and easy_install, makes no  
difference)
2. During upgrade database upgrade partially failed, but fixed with info  
from: http://www.mail-archive.com/reviewboard@googlegroups.com/msg09591.html

3. Open a review
4. Click View Diff
5. Stack trace (see below)

What is the expected output? What do you see instead?
The posted diff(s)

What operating system are you using? What browser?
Server is running Ubuntu 10.04.4 server edition. Client Windows 7 with  
Chrome.


Please provide any additional information below.

string indices must be integers, not str

Traceback (most recent call last):
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/ReviewBoard-1.6.13-py2.6.egg/reviewboard/diffviewer/views.py,  
line 270, in view_diff

'diffviewer/diff_file_fragment.html')
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/ReviewBoard-1.6.13-py2.6.egg/reviewboard/diffviewer/views.py,  
line 159, in build_diff_fragment

return cache_memoize(key, func)
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/djblets/util/misc.py,  
line 164, in cache_memoize

data = lookup_callable()
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/ReviewBoard-1.6.13-py2.6.egg/reviewboard/diffviewer/views.py,  
line 148, in lambda

RequestContext(request, context))
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/loader.py,  
line 183, in render_to_string

return t.render(Context(dictionary))
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/base.py,  
line 123, in render

return self._render(context)
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/base.py,  
line 117, in _render

return self.nodelist.render(context)
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/base.py,  
line 744, in render

bits.append(self.render_node(node, context))
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/base.py,  
line 757, in render_node

return node.render(context)
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/defaulttags.py,  
line 311, in render

return self.nodelist_true.render(context)
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/base.py,  
line 744, in render

bits.append(self.render_node(node, context))
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/base.py,  
line 757, in render_node

return node.render(context)
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/defaulttags.py,  
line 313, in render

return self.nodelist_false.render(context)
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/base.py,  
line 744, in render

bits.append(self.render_node(node, context))
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/base.py,  
line 757, in render_node

return node.render(context)
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/defaulttags.py,  
line 313, in render

return self.nodelist_false.render(context)
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/base.py,  
line 744, in render

bits.append(self.render_node(node, context))
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/base.py,  
line 757, in render_node

return node.render(context)
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/defaulttags.py,  
line 227, in render

nodelist.append(node.render(context))
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/defaulttags.py,  
line 313, in render

return self.nodelist_false.render(context)
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/base.py,  
line 744, in render

bits.append(self.render_node(node, context))
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/base.py,  
line 757, in render_node

return node.render(context)
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/defaulttags.py,  
line 285, in render

return self.nodelist_true.render(context)
   
File /var/virtual-env/reviewboard/lib/python2.6/site-packages/django/template/base.py,  
line 744, in render

bits.append(self.render_node(node, context))
   
File 

Re: Issue 2760 in reviewboard: Diffviewer produces error String incdices must be integers, not str

2012-10-05 Thread reviewboard

Updates:
Status: Started
	Labels: -Priority-Medium Priority-Critical Milestone-Release1.6.x  
Component-DiffViewer


Comment #1 on issue 2760 by chip...@gmail.com: Diffviewer produces  
error String incdices must be integers, not str

http://code.google.com/p/reviewboard/issues/detail?id=2760

I'll look at it and get a release out tonight.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2760 in reviewboard: Diffviewer produces error String incdices must be integers, not str

2012-10-05 Thread reviewboard

Updates:
Status: NeedInfo

Comment #2 on issue 2760 by chip...@gmail.com: Diffviewer produces  
error String incdices must be integers, not str

http://code.google.com/p/reviewboard/issues/detail?id=2760

Actually, can you clear your memory cache? This looks like it may be a  
stale cache issue.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2760 in reviewboard: Diffviewer produces error String incdices must be integers, not str

2012-10-05 Thread reviewboard


Comment #3 on issue 2760 by robert.suij...@gmail.com: Diffviewer produces  
error String incdices must be integers, not str

http://code.google.com/p/reviewboard/issues/detail?id=2760

Yes, that was it! Thank you very much!

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.




Re: Issue 2760 in reviewboard: Diffviewer produces error String incdices must be integers, not str

2012-10-05 Thread reviewboard


Comment #4 on issue 2760 by robert.suij...@gmail.com: Diffviewer produces  
error String incdices must be integers, not str

http://code.google.com/p/reviewboard/issues/detail?id=2760

for others:

restart memcached (sudo service memcached restart)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2760 in reviewboard: Diffviewer produces error String incdices must be integers, not str

2012-10-05 Thread reviewboard

Updates:
Status: SetupIssue
Labels: -Priority-Critical Priority-Medium

Comment #5 on issue 2760 by chip...@gmail.com: Diffviewer produces  
error String incdices must be integers, not str

http://code.google.com/p/reviewboard/issues/detail?id=2760

Glad to hear :) Thanks.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2761 in reviewboard: Publish review without triggering an email update

2012-10-05 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2761 by mudass...@gmail.com: Publish review without triggering an  
email update

http://code.google.com/p/reviewboard/issues/detail?id=2761

*NOTE: If you have a patch, please submit it to
http://reviews.reviewboard.org/


What version are you running?
1.6.10

What's the URL of the page this enhancement relates to, if any?


Describe the enhancement and the motivation for it.

- Sometimes I have to make some cosmetic changes to the review request like  
updating the data that I inserted while creating the review request. The  
changes may be as small as adding or removing a bug number. However I do  
not want an email to be sent to the reviewers for such changes. Sending a  
review request may waste the reviewers time if they go through the changes  
only to find out there was actually no update.


What operating system are you using? What browser?

-Red Hat Enterprise Linux Server release 6.2 (Santiago)
-Google Chrome

Please provide any additional information below.

A solution could be to add a flag to the publish dialog, checking this box  
will not send an email or have a separate publish button which does not  
trigger email update.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.