Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Comment #23 on issue 2445 by ramesh.s...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 I am on RhodeCode 1.7.1 and Review Board 1.7.9. I applied the patches referred in #17 above (had to hand-edit it for Review Board, and RhodeCode didn't have the line that was modified (@LoginRequired...). Now the View Diff command shows the diff of the login page! I have attached a screenshot of the Diff Viewer. Appreciate any help! Attachments: 2013-07-03 09_12_30-adding a line before last line _ Diff Viewer _ Review Board.png 16.1 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3030 in reviewboard: Once logged in, "power" icon in upper right sometimes conflicts with browser extensions
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3030 by one.eric...@gmail.com: Once logged in, "power" icon in upper right sometimes conflicts with browser extensions http://code.google.com/p/reviewboard/issues/detail?id=3030 I tried this both on your demo site (1.8.0 alpha 0), and on my work install of 1.7.7.1. I see that the demo instance shows the problem here: http://demo.reviewboard.org/dashboard/ The "power" icon appears to be loaded from http://www.gravatar.com/avatar/abb249055208c7af4d35568e422dfd63?s=32 ... however, my work instance does not use gravatars, and if someone has a browser plugin that blocks certain kinds of cross-site requests (see RequestPolicy), then no icon shows here. Is there any way that this icon can be defaulted to something actually installed on the reviewboard server, instead of being loaded from a remote site? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3028 in reviewboard: Unable to post review using firefox.
Updates: Status: NeedInfo Comment #1 on issue 3028 by trowb...@gmail.com: Unable to post review using firefox. http://code.google.com/p/reviewboard/issues/detail?id=3028 What version of firefox? Are you seeing an error in the web UI? Can you get detailed error information either from the pop-up in the UI or from the reviewboard log file? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3024 in reviewboard: Enhance Review Board RBTools (rbt) to support svn tree (or file copy)
Comment #3 on issue 3024 by chip...@gmail.com: Enhance Review Board RBTools (rbt) to support svn tree (or file copy) http://code.google.com/p/reviewboard/issues/detail?id=3024 Thanks, but we require that all patches go up for review at http://reviews.reviewboard.org/ -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3024 in reviewboard: Enhance Review Board RBTools (rbt) to support svn tree (or file copy)
Comment #2 on issue 3024 by sudhir.s...@gmail.com: Enhance Review Board RBTools (rbt) to support svn tree (or file copy) http://code.google.com/p/reviewboard/issues/detail?id=3024 This patch fixes other clients from breaking due to svn client change. --- 0.5.1.1/utils/diffs.py (revision 408105) +++ 0.5.1.1/utils/diffs.py (working copy) @@ -1,14 +1,24 @@ -def get_diff(scmtool, repository_info, revision_range=None, - svn_changelist=None, files=[]): +def get_diff(scmtool, repository_info, svn_show_copies_as_adds=None, + revision_range=None, svn_changelist=None, files=[]): """Returns a diff as a string.""" if revision_range: -diff, parent_diff = scmtool.diff_between_revisions( -revision_range, -files, -repository_info) +if scmtool.name == 'Subversion': +diff, parent_diff = scmtool.diff_between_revisions( +revision_range, +files, +repository_info, +svn_show_copies_as_adds) +else: +diff, parent_diff = scmtool.diff_between_revisions( +revision_range, +files, +repository_info) elif svn_changelist: -diff, parent_diff = scmtool.diff_changelist(svn_changelist) +diff, parent_diff = scmtool.diff_changelist(svn_changelist, + svn_show_copies_as_adds) else: -diff, parent_diff = scmtool.diff(files) - +if scmtool.name == 'Subversion': +diff, parent_diff = scmtool.diff(files, svn_show_copies_as_adds) +else: +diff, parent_diff = scmtool.diff(files) return diff, parent_diff Attachments: patch 7.0 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3029 in reviewboard: Active Directory authentication support for multiple domains
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3029 by mus...@gmail.com: Active Directory authentication support for multiple domains http://code.google.com/p/reviewboard/issues/detail?id=3029 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this enhancement request! What version are you running? 1.7.11 What's the URL of the page this enhancement relates to, if any? admin/settings/authentication/ Describe the enhancement and the motivation for it. Larger organizations may have multiple domains with users belonging to each. If the domain names are added with a delimiter, they can be split and users authenticated against each until success (or failure). This is a similarly supported feature in the Jenkins AD add-in. What operating system are you using? What browser? Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2932 in reviewboard: Login to SCM server failed - But where to specify SVN credentials in review board?
Comment #3 on issue 2932 by shivaramaraju: Login to SCM server failed - But where to specify SVN credentials in review board? http://code.google.com/p/reviewboard/issues/detail?id=2932 Admin credentials got Changed. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3028 in reviewboard: Unable to post review using firefox.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3028 by gerald.w...@gmail.com: Unable to post review using firefox. http://code.google.com/p/reviewboard/issues/detail?id=3028 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? 1.7.11 & version 1.6.13 What's the URL of the page containing the problem? Posting a review http://myreviewboard.com/reviewboard/r/2/# What steps will reproduce the problem? 1. posted a draft review using rbt tools 2. login to reviewboard with firefox 3. publish the review, or try and add a file. What is the expected output? What do you see instead? review is expected to be published. Error: Error Code: 0 Error Text: error Request URL: http://myreviewboard.com:9680/reviewboard/api/review-requests/2/file-attachments/ Request Data: (none) Information from Web Console on FireFox. Publish Review Attempt Error Code: 0 Error Text: error Request URL: http://myreviewboard.com:9680/reviewboard/api/review-requests/2/draft/ Request Data: public=1 What operating system are you using? What browser? Linux & Windows same issue Firefox V21.0 Please provide any additional information below. Issue doesn't seem to occur in IE9 on windows.. -- [09:46:49.355] OPTIONS http://myreviewboard.com:9680/reviewboard/api/review-requests/2/draft/ [HTTP/1.1 405 METHOD NOT ALLOWED 18ms] -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
