Issue 3497 in reviewboard: rbt tools not posting deleted files for perforce
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3497 by jco...@gmail.com: rbt tools not posting deleted files for
perforce
http://code.google.com/p/reviewboard/issues/detail?id=3497
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.
What version are you running?
1.7.22
What's the URL of the page containing the problem?
Private system.
What steps will reproduce the problem?
1. Submit a perforce change containing one or more deleted files
2. Run rbt post change list no (where the change list no is the one
submitted in step 1)
3. On the generate review you will see that the deleted files are NOT
present.
What is the expected output? What do you see instead?
The deleted files should be present in the diff report.
What operating system are you using? What browser?
Linux on the server, Windows 7 on the client with Firefox
Please provide any additional information below.
I think the issue is this:-
The most recent version of the file in the submitted change list output
from perforce is the delete.
I think the issue begins in _compute_range_changes in perforce.py
What I believe happens is the code in perforce.py runs p4
filelog //...@changeno,changeno to get the list of changes from the
change list I supplied.
It iterates through the list of changes, parsing out the depot files,
action and locations.
_accumulate_range_change is called for each file. If old_action is edit,
then it decrements initialRev. This is therefore not done for a delete, so
the value of initialRev remains as the last (deleted) version of the file:-
def _accumulate_range_change(self, file_entry, change):
Compute the effects of a given change on a given file
old_action = file_entry['action']
current_action = change['action']
if old_action == 'none':
# This is the first entry for this file.
new_action = current_action
file_entry['depotFile'] = file_entry['initialDepotFile']
# If the first action was an edit, then the initial revision
# (that we'll use to generate the diff) is n-1
if current_action == 'edit':
file_entry['initialRev'] -= 1
It then iterates through the built list of files and if action is delete,
does this:-
elif action == 'delete':
try:
old_file, new_file = self._extract_delete_files(
initial_depot_file, initial_rev)
except ValueError:
logging.warning('Skipping file %s: %s', depot_file, e)
continue
diff_lines += self._do_diff(
old_file, new_file, initial_depot_file, initial_rev,
depot_file, 'D', ignore_unmodified=True)
In this case the value passed to extract_delete_files is the deleted
revision of the file (I.E. the version output from p4 filelog).
def _extract_delete_files(self, depot_file, revision):
Extract the 'old' and 'new' files for a delete operation.
Returns a tuple of (old filename, new filename). This can raise a
ValueError if extraction fails.
# Get the old version out of perforce
old_filename = make_tempfile()
self._write_file('%s#%s' % (depot_file, revision), old_filename)
# Make an empty tempfile for the new file
new_filename = make_tempfile()
return old_filename, new_filename
The _write_file method then causes it to execute this command:-
p4 print -o /tmp/tmp-9Bncr -q //depot//DeletedFile#2 (where #2 is the
deleted revision of the file)
In this case if the temp file did not already exist, perforce does not
create it. But it was already created by make_tempfile (and was empty). So
the result is we still have an empty file. The new file is also created
with make_tempfile and hence is empty.
This means that when the diff is run, it ends up comparing two empty files.
It then of course says there is no change and so the file that is deleted
ends up NOT getting included in the diff that rbt uploads. I think this is
an error and in the old_filename code above the depot revision needs to be
decreased by 1. This will cause p4 print to output the old version of the
file (prior to the delete). Then when the diff runs, it compares the old
(pre
Issue 3498 in reviewboard: Command line configuration dump/restore
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3498 by blueazsk...@gmail.com: Command line configuration dump/restore http://code.google.com/p/reviewboard/issues/detail?id=3498 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this enhancement request! What version are you running? 1.7.24 What's the URL of the page this enhancement relates to, if any? N/A Describe the enhancement and the motivation for it. It would be nice to enable Active Directory from a chef install script rather than a gui page. That leads to dumping/restoring the configuration from the command line. What operating system are you using? What browser? Linux Ubuntu 12.04, Firefox Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3498 in reviewboard: Command line configuration dump/restore
Comment #1 on issue 3498 by trowb...@gmail.com: Command line configuration dump/restore http://code.google.com/p/reviewboard/issues/detail?id=3498 While there's no explicit dump/restore, you can use the list-siteconfig, get-siteconfig and set-siteconfig management commands to do this from your chef configuration. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3498 in reviewboard: Command line configuration dump/restore
Comment #2 on issue 3498 by andrewm@gmail.com: Command line configuration dump/restore http://code.google.com/p/reviewboard/issues/detail?id=3498 I'm not 100% sure, but this might be related: https://groups.google.com/forum/#!topic/reviewboard-dev/ZWJsfyJz_nw -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3402 in reviewboard: Include revision of the commits shown in the repository listing of a branch
Updates: Status: PendingReview Owner: trowb...@gmail.com Comment #2 on issue 3402 by trowb...@gmail.com: Include revision of the commits shown in the repository listing of a branch http://code.google.com/p/reviewboard/issues/detail?id=3402 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3383 in reviewboard: Upload file form doesn't detect errors
Updates: Status: Fixed Comment #2 on issue 3383 by trowb...@gmail.com: Upload file form doesn't detect errors http://code.google.com/p/reviewboard/issues/detail?id=3383 Fixed in release-2.0.x (76caaa7). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2445 in reviewboard: Unable to 'View Diff' when using with RhodeCode for mercurial repositories
Updates: Status: ThirdParty Comment #28 on issue 2445 by trowb...@gmail.com: Unable to 'View Diff' when using with RhodeCode for mercurial repositories http://code.google.com/p/reviewboard/issues/detail?id=2445 Until RhodeCode supports the necessary APIs, there's nothing we can do here. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3311 in reviewboard: Not able to integrate LDAP with Review Board
Updates: Status: SetupIssue Comment #1 on issue 3311 by trowb...@gmail.com: Not able to integrate LDAP with Review Board http://code.google.com/p/reviewboard/issues/detail?id=3311 I believe that this is just a misconfiguration. The LDAP config UI in 2.0.x is much less confusing. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3436 in reviewboard: Clicking and dragging on linenumbers in diffviewer doesn't allow user to comment
Updates: Status: Fixed Comment #2 on issue 3436 by trowb...@gmail.com: Clicking and dragging on linenumbers in diffviewer doesn't allow user to comment http://code.google.com/p/reviewboard/issues/detail?id=3436 Backed out change in 8bfbcf0. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3470 in reviewboard: Unable to set groups/people on a review request
Updates: Status: Fixed Comment #3 on issue 3470 by trowb...@gmail.com: Unable to set groups/people on a review request http://code.google.com/p/reviewboard/issues/detail?id=3470 This is fixed in djblets (85eb686), which you should get if you upgrade to the latest Review Board 2.0.x -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 1556 in reviewboard: Add the ability to pass SVN username and password on post-review command line
Updates: Labels: EasyFix Comment #6 on issue 1556 by trowb...@gmail.com: Add the ability to pass SVN username and password on post-review command line http://code.google.com/p/reviewboard/issues/detail?id=1556 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2733 in reviewboard: Avoid review creation if diff upload fails
Comment #3 on issue 2733 by trowb...@gmail.com: Avoid review creation if diff upload fails http://code.google.com/p/reviewboard/issues/detail?id=2733 This is quite doable now that we have the diff validation resource. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 46 in reviewboard: 80-column indicator in diff view
Comment #19 on issue 46 by trowb...@gmail.com: 80-column indicator in diff
view
http://code.google.com/p/reviewboard/issues/detail?id=46
Mike has some CSS that works for this:
table.sidebyside tr[line] td:before {
content: '';
position: absolute;
transform: translateX(80ch);
border-left: 1px solid red;
height: 18px;
}
We'll have to figure out the best way to expose this.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Re: Issue 46 in reviewboard: 80-column indicator in diff view
Comment #20 on issue 46 by chip...@gmail.com: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 A few notes on the CSS, after playing with it, that we'll need to address: 1. The red lines end up overflowing from the left-hand side to the right-hand side. This can be sort of prevented by adding 'position: relative; overflow: hidden;' to the parent td, but I'm not sure that fully worked. 2. If your window width isn't wide enough to show two columns of 80 characters, you'll never see red lines and never have any indication where the wrap point is. 3. Similarly, if text wraps due to being too long to show the full block of text (such as a long variable name) on the first line, and that text hits the 80 column boundary, then it'll wrap and you won't see where the red line was supposed to be within that text. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3462 in reviewboard: Ability to take back a ship-it.
Comment #2 on issue 3462 by trowb...@gmail.com: Ability to take back a ship-it. http://code.google.com/p/reviewboard/issues/detail?id=3462 I'm curious if this is fixed by the new ship-it column in 2.0.x. If you add a new review that has issues, the ship-it won't be shown, and instead the issue count will be. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3318 in reviewboard: Allow rbt to post from previously submitted changes without a perforce client
Updates: Summary: Allow rbt to post from previously submitted changes without a perforce client Labels: Project-RBTools Component-RBTools Comment #1 on issue 3318 by trowb...@gmail.com: Allow rbt to post from previously submitted changes without a perforce client http://code.google.com/p/reviewboard/issues/detail?id=3318 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 1570 in reviewboard: Diff-Upload UI: Usability Enhancement
Comment #4 on issue 1570 by fbeach...@gmail.com: Diff-Upload UI: Usability Enhancement http://code.google.com/p/reviewboard/issues/detail?id=1570 Thanks to the RB team for thorough and patient attention to this report. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3462 in reviewboard: Ability to take back a ship-it.
Comment #3 on issue 3462 by vlov...@gmail.com: Ability to take back a ship-it. http://code.google.com/p/reviewboard/issues/detail?id=3462 Not really. A review may have larger issues (e.g. architectural) that are not issues related to any specific line. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3462 in reviewboard: Ability to take back a ship-it.
Comment #4 on issue 3462 by vlov...@gmail.com: Ability to take back a ship-it. http://code.google.com/p/reviewboard/issues/detail?id=3462 Also, someone may mark all the single line issues as fixed/dropped without addressing larger issues that may be raised that invalidate the ship-it. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3499 in reviewboard: on submitting the RB request, i am seeing internal server error 500 (my username sushilk)
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3499 by sushilku...@gmail.com: on submitting the RB request, i am seeing internal server error 500 (my username sushilk) http://code.google.com/p/reviewboard/issues/detail?id=3499 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? What's the URL of the page containing the problem? What steps will reproduce the problem? 1. 2. 3. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
