Issue 3507 in reviewboard: Bad Request

2014-07-30 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3507 by onion.to...@gmail.com: Bad Request
http://code.google.com/p/reviewboard/issues/detail?id=3507

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
2.05


What's the URL of the page containing the problem?
root document


What steps will reproduce the problem?
1.install all software
2.
3.

What is the expected output? What do you see instead?
the main page of reviewboard

What operating system are you using? What browser?
Ubuntu
Firfox

Please provide any additional information below.
I followed all the steps mentioned on reviewboard site.
when I am trying to access reviewboard url, Its always displaying
Bad Request (400) message

If I deny the conf of wsgi, the web site work right

What's the problem of me?

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3505 in reviewboard: Empty drafts can be submitted

2014-07-30 Thread reviewboard


Comment #2 on issue 3505 by anhi...@cisco.com: Empty drafts can be submitted
http://code.google.com/p/reviewboard/issues/detail?id=3505

I agree that it's not a regression. Could we make it a feature request? I'd  
like to be able to specify validation steps to move between states.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3508 in reviewboard: Post Reivew allows you to update a review request draft to a commit ID that is already present in another review.

2014-07-30 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3508 by thom.ger...@gmail.com: Post Reivew allows you to update a  
review request draft to a commit ID that is already present in another  
review.

http://code.google.com/p/reviewboard/issues/detail?id=3508

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?

Triggered the exception on https://reviews.reviewboard.org/ at sometime  
around July 30, 2014 1:30 PM PT .



What's the URL of the page containing the problem?

https://reviews.reviewboard.org/api/review-requests/6169/draft/

What steps will reproduce the problem?
1. Create a review request (# 6168) for commit  
09263fedc72b1dd34b7ce11d7e9238664d3316ed .  It need not be published.
2. Create a review request (# 6169) for commit  
9419d95630f1d455ceaf8932fdf793faee03543b .
3. Update the second review request with the same SHA as the first `rbt  
post -r6169 09263fedc72b1dd34b7ce11d7e9238664d3316ed`
   -  This should get rejected because a review request exists already for  
this ID but it is not currently.

4. Attempt to publish Request #6169 from the web ui or rbt post -p
   - Trigger 500 error for Integrity Error.

What is the expected output? What do you see instead?

Step #3 should not be be possible.  Step #4 should give a better error  
message if you get to this state somehow.


What operating system are you using? What browser?

Chrome, Firefox, rbt post on linux.


Please provide any additional information below.

Stack trace of the Integrity Error from a Reviewboard 2.0.3 server:

Traceback (most recent call last):

  File Django-1.6.5-py2.7.egg/django/core/handlers/base.py, line 112, in  
get_response

response = wrapped_callback(request, *callback_args, **callback_kwargs)

  File Django-1.6.5-py2.7.egg/django/views/decorators/cache.py, line 52,  
in _wrapped_view_func

response = view_func(request, *args, **kwargs)

  File Django-1.6.5-py2.7.egg/django/views/decorators/vary.py, line 19,  
in inner_func

response = func(*args, **kwargs)

  File Djblets-0.8.6-py2.7.egg/djblets/webapi/resources.py, line 494, in  
__call__

request, method, view, api_format=api_format, *args, **kwargs)

  File Djblets-0.8.6-py2.7.egg/djblets/webapi/resources.py, line 565, in  
call_method_view

return view(request, *args, **kwargs)

  File Djblets-0.8.6-py2.7.egg/djblets/webapi/resources.py, line 753, in  
put

return self.update(request, *args, **kwargs)

  File Djblets-0.8.6-py2.7.egg/djblets/webapi/decorators.py, line 117, in  
_call

return view_func(*args, **kwargs)

  File ReviewBoard-2.0.3-py2.7.egg/reviewboard/webapi/decorators.py, line  
110, in _check

return view_func(*args, **kwargs)

  File Djblets-0.8.6-py2.7.egg/djblets/webapi/decorators.py, line 117, in  
_call

return view_func(*args, **kwargs)

  File Djblets-0.8.6-py2.7.egg/djblets/webapi/decorators.py, line 138, in  
_checklogin

return view_func(*args, **kwargs)

  File Djblets-0.8.6-py2.7.egg/djblets/webapi/decorators.py, line 117, in  
_call

return view_func(*args, **kwargs)

  File Djblets-0.8.6-py2.7.egg/djblets/webapi/decorators.py, line 287, in  
_validate

return view_func(*args, **new_kwargs)

   
File ReviewBoard-2.0.3-py2.7.egg/reviewboard/webapi/resources/review_request_draft.py,  
line 394, in update

review_request.publish(user=request.user)

   
File ReviewBoard-2.0.3-py2.7.egg/reviewboard/reviews/models/review_request.py,  
line 716, in publish

changes = draft.publish(self, send_notification=False)

   
File ReviewBoard-2.0.3-py2.7.egg/reviewboard/reviews/models/review_request_draft.py,  
line 318, in publish

review_request.save()

   
File ReviewBoard-2.0.3-py2.7.egg/reviewboard/reviews/models/review_request.py,  
line 581, in save

super(ReviewRequest, self).save(**kwargs)

   
File ReviewBoard-2.0.3-py2.7.egg/reviewboard/reviews/models/base_review_request_details.py,  
line 258, in save

super(BaseReviewRequestDetails, self).save(**kwargs)

  File Django-1.6.5-py2.7.egg/django/db/models/base.py, line 545, in save
force_update=force_update, update_fields=update_fields)

  File Django-1.6.5-py2.7.egg/django/db/models/base.py, line 573, in  
save_base
updated = self._save_table(raw, cls, force_insert, force_update, using,  
update_fields)


  File Django-1.6.5-py2.7.egg/django/db/models/base.py, line 635, in  

Re: Issue 3505 in reviewboard: Empty drafts can be submitted

2014-07-30 Thread reviewboard

Updates:
Labels: -Type-Defect Type-Enhancement

Comment #3 on issue 3505 by trowb...@gmail.com: Empty drafts can be  
submitted

http://code.google.com/p/reviewboard/issues/detail?id=3505

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3507 in reviewboard: Bad Request

2014-07-30 Thread reviewboard

Updates:
Status: SetupIssue

Comment #1 on issue 3507 by trowb...@gmail.com: Bad Request
http://code.google.com/p/reviewboard/issues/detail?id=3507

You should be able to get some information out of the apache error logs.

I'd suggest following up on the reviewboard mailing list, since this is a  
set-up issue, and not a bug.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 1026 in reviewboard: RFE: Add ability to ignore files in a patch

2014-07-30 Thread reviewboard


Comment #10 on issue 1026 by fel...@cypriano.me: RFE: Add ability to ignore  
files in a patch

http://code.google.com/p/reviewboard/issues/detail?id=1026

I'd love this feature. My use case is an iOS project that uses CocoaPods to  
handle dependencies and we commit the dependencies, so we'd like to exclude  
the dependencies source code from reviews. Would be something like  
`--exclude Pods/**/*`.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 1026 in reviewboard: RFE: Add ability to ignore files in a patch

2014-07-30 Thread reviewboard


Comment #11 on issue 1026 by chip...@gmail.com: RFE: Add ability to ignore  
files in a patch

http://code.google.com/p/reviewboard/issues/detail?id=1026

This came up today with someone on RBCommons. There's definitely work we'd  
have to do to filter changes from diffs, but we should add an option for  
this and perhaps a .rbtignore file.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3487 in reviewboard: Authentication error when connecting to svn without public access

2014-07-30 Thread reviewboard


Comment #1 on issue 3487 by alexisde...@gmail.com: Authentication error  
when connecting to svn without public access

http://code.google.com/p/reviewboard/issues/detail?id=3487

Fixed in 2.0.5

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3487 in reviewboard: Authentication error when connecting to svn without public access

2014-07-30 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 3487 by trowb...@gmail.com: Authentication error when  
connecting to svn without public access

http://code.google.com/p/reviewboard/issues/detail?id=3487

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3509 in reviewboard: Collapse multi line comment in repository

2014-07-30 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 3509 by alexisde...@gmail.com: Collapse multi line comment in  
repository

http://code.google.com/p/reviewboard/issues/detail?id=3509

What version are you running?
2.0.5

What's the URL of the page this enhancement relates to, if any?
Internal

Describe the enhancement and the motivation for it.
Merge all the commit log lines in the New Review Request for Committed  
Change. It currently only shows the first line of the commit log. We use  
the first line to identified the issue related to the checkin and the  
description on a new line so the New Review Request only shows the issue  
the commit is related to and none of the comments.


Also, collapse the commit log in the summary so it shows meaningful subject  
on the summary screen.


What operating system are you using? What browser?
Windows 7 x64. Chrome


Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3510 in reviewboard: Make Automatically `rbt post` automatically detect the tracking branch

2014-07-30 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 3510 by fel...@cypriano.me: Make Automatically `rbt post`  
automatically detect the tracking branch

http://code.google.com/p/reviewboard/issues/detail?id=3510

What version are you running?
RBCommons + RBTools 0.6.2

Describe the enhancement and the motivation for it.

Based on the documentation  
(https://github.com/reviewboard/rbtools/blob/master/docs/rbtools/rbt/configuration.rst#tracking_branch)  
`rbt post` under Git assumes the closes remote branch is `master` and you  
need to use `--tracking-branch` to change it if the tracking branch is not  
master.


The way I use branches is that all feature branches come from master, I  
commit and push feature branches to origin/feature-branch-name so that our  
CI can grab the changes and run the tests; after everything is green  
(including code review) the branch is merged into master. So if I  
understood correctly TRACKING_BRANCH is `origin/feature-branch-name` and  
BRANCH is `master`.


My suggestion is to make `rbt post` smarter under Git. We can get the name  
of the tracking branch and use it:


```
git for-each-ref --format='%(upstream:short)' $(git symbolic-ref -q HEAD)
```

or

```
git rev-parse --abbrev-ref --symbolic-full-name @{u}
```

So `rbt post` could get the result from one of those commands and use it as  
the tracking branch if there's no --tracking-branch option nor  
TRACKING_BRANCH in .reviewboardrc file.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3510 in reviewboard: Make Automatically `rbt post` automatically detect the tracking branch

2014-07-30 Thread reviewboard


Comment #1 on issue 3510 by fel...@cypriano.me: Make Automatically `rbt  
post` automatically detect the tracking branch

http://code.google.com/p/reviewboard/issues/detail?id=3510

(I'd love to edit the title and get rid of the wrong automatically but I  
can't see a way to edit an issue in Google Code. GH Issues ❤️)


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 1026 in reviewboard: RFE: Add ability to ignore files in a patch

2014-07-30 Thread reviewboard


Comment #12 on issue 1026 by rajas...@gmail.com: RFE: Add ability to ignore  
files in a patch

http://code.google.com/p/reviewboard/issues/detail?id=1026

Would it be possible to add it as a repository level setting (in the admin  
menu). The server can look at the repository setting for excludes and then  
remove those from doing a diff. This allows people who upload or pull from  
existing commits or rbt.


I can look at doing a patch if it helps.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3486 in reviewboard: Upgrade 2.0 to 2.0.3 fails

2014-07-30 Thread reviewboard


Comment #7 on issue 3486 by rick...@gmail.com: Upgrade 2.0 to 2.0.3 fails
http://code.google.com/p/reviewboard/issues/detail?id=3486

Got the same issue when upgrading from 2.0.1 to 2.0.5. Manually fixed with  
Abhishek's commands.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.