Issue 3681 in reviewboard: Disabling email notifications for my own activity causes server 500 error

2014-11-25 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3681 by sararayb...@gmail.com: Disabling email notifications for  
my own activity causes server 500 error

https://code.google.com/p/reviewboard/issues/detail?id=3681

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
2.0.11

What's the URL of the page containing the problem?
http://reviewboard.cctechnol.com/r/4712/

What steps will reproduce the problem?
1. In My Account-Settings, uncheck both get e-mail notification options.
2. Create a new review request, click publish
3.

What is the expected output? What do you see instead?
Expected output: Review request is published with no error
Actual output: HTTP 500 error, but when you go back to the dashboard, the  
request was published. I also receive an error email from the server.


What operating system are you using? What browser?
Happens both with Windows 7/Firefox and with Fedora 20 Firefox 33.1


Please provide any additional information below.

There are no errors in the developer console. The email and the  
reviewboard.log include the same traceback.

Contents of error email:

Traceback (most recent call last):

   
File /usr/lib/python2.6/site-packages/Django-1.6.7-py2.6.egg/django/core/handlers/base.py,  
line 112, in get_response

response = wrapped_callback(request, *callback_args, **callback_kwargs)

   
File /usr/lib/python2.6/site-packages/Django-1.6.7-py2.6.egg/django/views/decorators/cache.py,  
line 52, in _wrapped_view_func

response = view_func(request, *args, **kwargs)

   
File /usr/lib/python2.6/site-packages/Django-1.6.7-py2.6.egg/django/views/decorators/vary.py,  
line 19, in inner_func

response = func(*args, **kwargs)

   
File /usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.egg/djblets/webapi/resources.py,  
line 496, in __call__

request, method, view, api_format=api_format, *args, **kwargs)

   
File /usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.egg/djblets/webapi/resources.py,  
line 567, in call_method_view

return view(request, *args, **kwargs)

   
File /usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.egg/djblets/webapi/resources.py,  
line 764, in put

return self.update(request, *args, **kwargs)

   
File /usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.egg/djblets/webapi/decorators.py,  
line 117, in _call

return view_func(*args, **kwargs)

   
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.11-py2.6.egg/reviewboard/webapi/decorators.py,  
line 110, in _check

return view_func(*args, **kwargs)

   
File /usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.egg/djblets/webapi/decorators.py,  
line 117, in _call

return view_func(*args, **kwargs)

   
File /usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.egg/djblets/webapi/decorators.py,  
line 138, in _checklogin

return view_func(*args, **kwargs)

   
File /usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.egg/djblets/webapi/decorators.py,  
line 117, in _call

return view_func(*args, **kwargs)

   
File /usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.egg/djblets/webapi/decorators.py,  
line 117, in _call

return view_func(*args, **kwargs)

   
File /usr/lib/python2.6/site-packages/Djblets-0.8.12-py2.6.egg/djblets/webapi/decorators.py,  
line 287, in _validate

return view_func(*args, **new_kwargs)

   
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.11-py2.6.egg/reviewboard/webapi/resources/review_request_draft.py,  
line 439, in update

review_request.publish(user=request.user)

   
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.11-py2.6.egg/reviewboard/reviews/models/review_request.py,  
line 792, in publish

changedesc=changes)

   
File /usr/lib/python2.6/site-packages/Django-1.6.7-py2.6.egg/django/dispatch/dispatcher.py,  
line 185, in send

response = receiver(signal=self, sender=sender, **named)

   
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.11-py2.6.egg/reviewboard/notifications/email.py,  
line 46, in review_request_published_cb

mail_review_request(review_request, changedesc)

   
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.11-py2.6.egg/reviewboard/notifications/email.py,  
line 347, in mail_review_request

extra_context)

   
File 

Issue 3682 in reviewboard: Cannot copy text in diff viewer of newly created file

2014-11-25 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3682 by freea...@gmail.com: Cannot copy text in diff viewer of  
newly created file

https://code.google.com/p/reviewboard/issues/detail?id=3682



What version are you running?

  2.0.11

What's the URL of the page containing the problem?

  r/review_id/diff/#

What steps will reproduce the problem?
  1. Create a new file in git repository
  2. Upload review using rbt
  3. Try to select text to copy from the diff viewer of the new file

What is the expected output? What do you see instead?

  Should be able to copy the text but you cannot

What operating system are you using? What browser?

  Mac OS 10.9.5, Firefox 33.1.1 and Safari 7.1

Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3680 in reviewboard: Diff viewer does not indent code properly.

2014-11-25 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 3680 by trowb...@gmail.com: Diff viewer does not indent  
code properly.

https://code.google.com/p/reviewboard/issues/detail?id=3680

We don't have access to your private server, but this code is quite well  
tested. Perhaps you have a mix of tabs and spaces?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3661 in reviewboard: Unable to select text in a new file when viewing the text of a New File

2014-11-25 Thread reviewboard


Comment #6 on issue 3661 by trowb...@gmail.com: Unable to select text in a  
new file when viewing the text of a New File

https://code.google.com/p/reviewboard/issues/detail?id=3661

Issue 3682 has been merged into this issue.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3682 in reviewboard: Cannot copy text in diff viewer of newly created file

2014-11-25 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 3661

Comment #1 on issue 3682 by trowb...@gmail.com: Cannot copy text in diff  
viewer of newly created file

https://code.google.com/p/reviewboard/issues/detail?id=3682

This is already fixed in git and will ship with 2.0.12

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3682 in reviewboard: Cannot copy text in diff viewer of newly created file

2014-11-25 Thread reviewboard


Comment #2 on issue 3682 by freea...@gmail.com: Cannot copy text in diff  
viewer of newly created file

https://code.google.com/p/reviewboard/issues/detail?id=3682

Thank you. I had searched using diff viewer and did not see the dup

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.