Re: Issue 3834 in reviewboard: Support SlikSVN version on Windows environment

2015-04-15 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 3834 by bar...@beanbaginc.com: Support SlikSVN version  
on Windows environment

https://code.google.com/p/reviewboard/issues/detail?id=3834

This bug has been fixed on the release-0.7.x branch as commit 4db748d. It  
will be in the next minor RBTools release (0.7.3).


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3846 in reviewboard: Request for adding a new field to review board called Impact to code coverage

2015-04-15 Thread reviewboard


Comment #2 on issue 3846 by adogr...@gmail.com: Request for adding a new  
field to review board called Impact to code coverage

https://code.google.com/p/reviewboard/issues/detail?id=3846

Thanks for the response. Could you please provide some more info on the
'Extensions' that you are recommending for us to use?

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3847 in reviewboard: Last logged in date for users is useless

2015-04-15 Thread reviewboard


Comment #1 on issue 3847 by jamesd...@gmail.com: Last logged in date for  
users is useless

https://code.google.com/p/reviewboard/issues/detail?id=3847

(Er, the version of Review Board we're using (and where I first noticed  
this) is 2.0.10, but this behavior is also present in demo.reviewboard.org,  
which is running 2.5 beta 2.)


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3846 in reviewboard: Request for adding a new field to review board called Impact to code coverage

2015-04-15 Thread reviewboard


Comment #4 on issue 3846 by adogr...@gmail.com: Request for adding a new  
field to review board called Impact to code coverage

https://code.google.com/p/reviewboard/issues/detail?id=3846

These are good references. A few questions, would appreciate your response.
1. Would the extension only apply to certain reviews?  Or certain groups?   
Or the whole reviewboard server?


2. Where would it be installed? The eng reviewboard server? Or are you  
saying we get our own reviewboard server and extend that?  Whats the  
rationale behind denying addition of new field but encourage writing an  
extension to do the same thing.



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3847 in reviewboard: Last logged in date for users is useless

2015-04-15 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3847 by jamesd...@gmail.com: Last logged in date for users is  
useless

https://code.google.com/p/reviewboard/issues/detail?id=3847

What version are you running?
2.0.10


What's the URL of the page containing the problem?
http://demo.reviewboard.org/users/chipx86/

What steps will reproduce the problem?
1. Visit http://demo.reviewboard.org/users/chipx86/
2. Note the Last logged in date along the left-hand side.


What is the expected output? What do you see instead?
As of writing, the Last logged in date for chipx86 on  
demo.reviewboard.org is May 28, 2014.  I'm presuming that he's visited  
demo.reviewboard.org within the past year.


I suspect that the Last logged in date shown is the last time that the  
user had to explicitly log in by supplying credentials.  This is useless:  
why would anyone care about that information?  Worse, the information is  
misleading.


It would be better if Review Board showed the last time that the user  
visited the Review Board instance or if it didn't bother showing anything  
at all.



What operating system are you using? What browser?
Firefox 37.0.1 on Windows 7 x64 SP1.


Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3819 in reviewboard: 500 Internal Server Error (AttributeError, specifically) in /admin

2015-04-15 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 3819 by bar...@beanbaginc.com: 500 Internal Server  
Error (AttributeError, specifically) in /admin

https://code.google.com/p/reviewboard/issues/detail?id=3819

The fix for this has landed on the release-2.0.x branch as commit 0e7315.  
It will be included in the next minor Review Board 2.0.x release (2.0.16)  
and all future releases.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3831 in reviewboard: InvalidExtensionError when enabling on ReviewBoard 2.0.15

2015-04-15 Thread reviewboard

Updates:
Status: UnableToReproduce

Comment #2 on issue 3831 by bar...@beanbaginc.com: InvalidExtensionError  
when enabling on ReviewBoard 2.0.15

https://code.google.com/p/reviewboard/issues/detail?id=3831

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3846 in reviewboard: Request for adding a new field to review board called Impact to code coverage

2015-04-15 Thread reviewboard


Comment #5 on issue 3846 by trowb...@gmail.com: Request for adding a new  
field to review board called Impact to code coverage

https://code.google.com/p/reviewboard/issues/detail?id=3846

1. So extensions typically apply to the entire Review Board server. It's  
possible within a field definition to make it show up for only certain  
conditions, depending on how it's written.


2. This bug tracker is about the upstream, open-source Review Board  
project. The particular server(s) running inside VMware aren't under our  
control.



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3829 in reviewboard: Upload Attachment View - Submit form without specifying a file

2015-04-15 Thread reviewboard

Updates:
Status: Fixed

Comment #1 on issue 3829 by bar...@beanbaginc.com: Upload Attachment View -  
Submit form without specifying a file

https://code.google.com/p/reviewboard/issues/detail?id=3829

The fix for this bug landed on the release-2.5.x branch as commit eace550.  
It will be included in the 2.5.0 release.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3846 in reviewboard: Request for adding a new field to review board called Impact to code coverage

2015-04-15 Thread reviewboard


Comment #3 on issue 3846 by trowb...@gmail.com: Request for adding a new  
field to review board called Impact to code coverage

https://code.google.com/p/reviewboard/issues/detail?id=3846

Review Board has a powerful extension framework that allows third parties  
to add functionality:


https://www.reviewboard.org/docs/manual/2.0/extending/

In particular, additional fields can be added to the review request via  
this hook:


https://www.reviewboard.org/docs/manual/2.0/extending/extensions/hooks/review-request-fields-hook/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3819 in reviewboard: 500 Internal Server Error (AttributeError, specifically) in /admin

2015-04-15 Thread reviewboard


Comment #1 on issue 3819 by bar...@beanbaginc.com: 500 Internal Server  
Error (AttributeError, specifically) in /admin

https://code.google.com/p/reviewboard/issues/detail?id=3819

Issue 3835 has been merged into this issue.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3835 in reviewboard: AttributeError: 'NoneType' object has no attribute 'get' in reviewboard\admin\views.py, line 39

2015-04-15 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 3819

Comment #1 on issue 3835 by bar...@beanbaginc.com:  
AttributeError: 'NoneType' object has no attribute 'get' in  
reviewboard\admin\views.py, line 39

https://code.google.com/p/reviewboard/issues/detail?id=3835

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 2794 in reviewboard: Display changes corresponded to comment regions in the code when the diff is updated

2015-04-15 Thread reviewboard


Comment #2 on issue 2794 by trowb...@gmail.com: Display changes  
corresponded to comment regions in the code when the diff is updated

https://code.google.com/p/reviewboard/issues/detail?id=2794

Issue 3845 has been merged into this issue.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3846 in reviewboard: Request for adding a new field to review board called Impact to code coverage

2015-04-15 Thread reviewboard

Updates:
Status: WontFix

Comment #1 on issue 3846 by trowb...@gmail.com: Request for adding a new  
field to review board called Impact to code coverage

https://code.google.com/p/reviewboard/issues/detail?id=3846

This request is pretty specific to one use case, and as such is something  
that we will not be adding to the core product (if we added every field  
that everybody wanted then we'd end up with something that looked like  
JIRA). Extensions can add new fields relatively easily, so I suggest  
pursuing that route.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3846 in reviewboard: Request for adding a new field to review board called Impact to code coverage

2015-04-15 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 3846 by adogr...@gmail.com: Request for adding a new field to  
review board called Impact to code coverage

https://code.google.com/p/reviewboard/issues/detail?id=3846

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this enhancement request!


What version are you running?
2.0.10

What's the URL of the page this enhancement relates to, if any?
https://reviewboard.eng.vmware.com

Describe the enhancement and the motivation for it.
Request is for adding a new field called Impact to code coverage which is  
a text field meant for users to provide quantitative as well as qualitative  
data. The intent is to promote engineering best practices within the team,  
especially to raise awareness and to track code coverage.


What operating system are you using? What browser?


Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3845 in reviewboard: When reviewing the updated diff, original comments should be visible for verification

2015-04-15 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 2794

Comment #1 on issue 3845 by trowb...@gmail.com: When reviewing the updated  
diff, original comments should be visible for verification

https://code.google.com/p/reviewboard/issues/detail?id=3845

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.