Review Board Ticket #4423: Download Diff always downloads latest diff regardless of currently selected revision

2016-06-03 Thread Griffin Myers
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4423/
--

New ticket #4423 by gmyers
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
Download Diff always downloads latest diff regardless of currently selected 
revision
==

# What version are you running?
3.0 alpha 0 at https://reviews.reviewboard.org

# What's the URL of the page containing the problem?
/r/{id}/diff/{N}/   when N is less than the latest revision number, R

# What steps will reproduce the problem?
1. Click Download Diff
2. 
3. 


# What is the expected output? What do you see instead?
Diff for revision R is downloaded, whereas diff for revision N is expected.

# What operating system are you using? What browser?
Windows 7, Firefox 46.0.1

# Please provide any additional information below.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Review Board Ticket #4422: Duplicate "This file contains only whitespace changes."

2016-06-03 Thread Keith Moyer
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4422/
--

New ticket #4422 by KeithMoyer
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
Duplicate "This file contains only whitespace changes."
==

# What version are you running?
2.5.3

# What's the URL of the page containing the problem?
/r/#/diff/#-#/

# What steps will reproduce the problem?
1. Create a review request with code changes
2. Create a new revision where a file only has whitespace changes from the 
previous revision
3. Open the interdiff between those revisions
4. Expand or collapse sections in the file


# What is the expected output? What do you see instead?
When it expands or collapses, it does that fine.  However, it also creates a 
duplicate "This file contains only whitespace changes." line at the top of the 
file.  If you expand or collapse multiple times, you get one duplicate line 
added each time.

# What operating system are you using? What browser?
Windows 7, Firefox

# Please provide any additional information below.
I was going to attempt to recreate on the demo.reviewboard.org site to see if 
it is an issue in 3.0.  However, the demo site is currently erroring out with a 
"Something broke! (Error 500)" any time I try to log in...

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.