Re: Djblets Ticket #4526: Tool to generate package.json prior to executing `setup.py install`

2017-02-28 Thread Barret Rennie
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4526/
--

New update by sgallagh
For Beanbag, Inc. > Djblets > Ticket #4526


Assigned to:
- chipx86
+ brennie

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Djblets Ticket #4526: Tool to generate package.json prior to executing `setup.py install`

2017-02-28 Thread Christian Hammond
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4526/
--

New update by sgallagh
For Beanbag, Inc. > Djblets > Ticket #4526


Status:
- New
+ Confirmed


Milestones:
+ Release-0.10.x
+ Release-0.9.x
+ Release-2.5.x


Tags:
+ Component:Deployment


Assigned to:
+ chipx86

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Djblets Ticket #4526: Tool to generate package.json prior to executing `setup.py install`

2017-02-28 Thread Stephen Gallagher
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4526/
--

New ticket #4526 by sgallagh
For Beanbag, Inc. > Djblets

Status: New
Tags: Priority:Medium, Type:Enhancement


--
Tool to generate package.json prior to executing `setup.py install`
==

# What version are you using?
Djblets 0.9.6

# Which module(s) does this relate to?
Building the package

# Describe the enhancement and the motivation for it.
I maintain the EPEL (Extra Packages for Enterprise Linux) packages. One of the 
constraints there is that we cannot have network access during builds (in order 
to ensure reproducibility). As a result, we need to include all build 
dependencies in packages.

Because of the way that Node NPMs are packaged in EPEL, we need to be able to 
read the package.json that is created dynamically /before/ we start the 
`setup.py install` phase, or we cannot properly symlink things into the correct 
place.

# Please provide any additional information below.

This is blocking the packaging of Djblets 0.9.6 in EPEL (and by extension, 
ReviewBoard 2.5.9).

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4371: Diff move detection incorrectly matches source and target

2017-02-28 Thread Piotr Zalewa
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4371/
--

New update by smacleod
For Beanbag, Inc. > Review Board > Ticket #4371


Reply:

The problem is within algorithm of detecting a group move.
From opcode_generator.py#~350

   # The way we do that is to find each removed line that matches
   # this inserted line, and for each of those find out if there's
   # an existing move range that the found removed line
   # immediately follows. If there is, we update the existing
   # range.

If there is a MoveRange which starts with the same (2+) lines of code last 
choice is prefered.
I think that the solution could work along the following lines: 
  * create a temp MoveRange
  * continue adding to it until the following lines are the same
  * if the range is longer than existing one replace them entirely.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.