Re: Review Board Ticket #4537: Support for kotlin

2017-05-12 Thread Christian Hammond
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4537/
--

New update by pschiffer
For Beanbag, Inc. > Review Board > Ticket #4537


Reply:

The support for showing the current class/method is part of Review Board. 
We don't have Kotlin support in there, but it shouldn't be hard to add if you 
want to try throwing together a patch. These are all defined in 
`reviewboard/diffviewer/filetypes.py` as a list of regexes that match a 
suitable line, grouped by file extension.

The red box does mean an error in the syntax, as determined by Pygments. If 
most of the file is highlighted right, then this _usually_ means that the lexer 
doesn't support some aspect of the language (they rely heavily on 
user-contributed patches). What I'd do is try to create a small file that 
exhibits this behavior in Review Board and then see if it has the same problem 
on http://pygments.org/demo/. If so, then you'd need to file a bug or a patch 
against Pygments. If it's only in Review Board, and we can see the test file, 
I'll take a look and see what may be tripping things up.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4537: Support for kotlin

2017-05-12 Thread Christian Hammond
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4537/
--

New update by pschiffer
For Beanbag, Inc. > Review Board > Ticket #4537


Reply:

Can you verify the version of Pygments you have installed?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4537: Support for kotlin

2017-05-12 Thread Christian Hammond
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4537/
--

New update by pschiffer
For Beanbag, Inc. > Review Board > Ticket #4537


Reply:

What file extension are you using? Looking at Pygments it maps `*.kt` files 
to Kotlin, but not `*.kts`. There are no other lexers claiming `*.kt`, and we 
do filename-based matching, so if you're using `*.kt`, it _should_ be working.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4537: Support for kotlin

2017-05-12 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4537/
--

New update by pschiffer
For Beanbag, Inc. > Review Board > Ticket #4537


Reply:

We're here, but very busy. This isn't a particularly high priority issue 
given our workload right now, and so failing a deeper analysis of what's 
failing (which would speed up the fix), it's probably going to sit for a while.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.