Re: Review Board Ticket #4626: Adding Gitlab Hosting account fails since Gitlab 10.2.0 (2017-11-22)

2018-01-08 Thread Christian Hammond 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4626/
--

New update by hboomsma
For Beanbag, Inc. > Review Board > Ticket #4626


Reply:

We make use of /api/v3/session, not /api/v4/session. That URL, last we saw, 
_should_ be there still. We are working on API v4 support, and have an initial 
change up for review at the moment that will conditionally use the API, but I 
want to figure out first what you're seeing exactly. Does /api/v3/session show 
anything on your install?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4626: Adding Gitlab Hosting account fails since Gitlab 10.2.0 (2017-11-22)

2018-01-08 Thread Hidde Boomsma 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4626/
--

New ticket #4626 by hboomsma
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * Screenshot from 2018-01-09 08:34:50.png
   

 * Screenshot from 2018-01-09 08:32:26.png
   



--
Adding Gitlab Hosting account fails since Gitlab 10.2.0 (2017-11-22)
==

# What version are you running?
3.0.1

# What's the URL of the page containing the problem?
https://reviewboard.example.com/admin/db/scmtools/repository/add/

# What steps will reproduce the problem?
1. Login to reviewboard as an administrator
2. Click your username in the upper right corner
3. Click "Admin"
4. Click "Add" on the repositories line on the left of the screen in the Manage 
block
5. Fill in the name field
6. Choose gitlab as Hosting service
7. Select "" for Account
8. Put service URL on "https://gitlab.com;
9. Fill in a username and password of a valid gitlab.com account
10. Fill in a repository name in this gitlab account
11. 11 Click save

# What is the expected output? What do you see instead?
Have the page close and the repository be added. Now I get:

"Unknown error when linking the account: A GitLab server was not found at the 
provided URL.. The details of the failure are in the Review Board log file."

# What operating system are you using? What browser?
Ubuntu 14.04 with Google Chrome 62

# Please provide any additional information below.
Reviewboard makes use of a removed feature of Gitlab. The "/api/v4/session" 
endpoint is used in: 
https://github.com/reviewboard/reviewboard/blob/c3b5f2d2f94f72caad7f7d23646589aa8a140c1e/reviewboard/hostingsvcs/gitlab.py#L242
 But it was removed in Gitlab version 10.2.0. See changelog 
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md#1020-2017-11-22.
 If your gitlab instance was already connected the Hosting service will 
continue to operate. There also is a way around the problem by generating an 
access token by hand in gitlab interface (this is currently not possible 
through the API) and encypting it and adding the hosting account directly under 
"Hosting Accounts"

The code I used to encrypt my token and add it by hand is below. A screenshot 
with the apropiate json structure is attached. The secret can be found in your
`settings.local.py` file.

```python
import sys
from reviewboard.scmtools.crypto_utils import (decrypt_password,
   encrypt_password)
non_encrypt_token = sys.argv[1]
first_16_characters_of_secret = sys.argv[2]

encrypted = encrypt_password(non_encrypt_token, first_16_characters_of_secret)

print encrypted

```

Since gitlab has no option to add "access tokens" using the API (at least at 
the time of writing), I think the best approach whould be te remove the 
username/password fields, and replace them with an "Access Token" field. If 
need more information, please feel free to contact me.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.