Re: Review Board Ticket #4612: Email notifications generate incorrect URLs when SITE_ROOT is not '/'

2018-07-02 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4612/
--

New update by jhominal
For Beanbag, Inc. > Review Board > Ticket #4612


Reply:

This was fixed in 3.0.2.


Status:
- PendingReview
+ Fixed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4712: Internal Error when getting status updates when a previous status update is error.

2018-07-02 Thread Joshua Cannon
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4712/
--

New update by jcannon
For Beanbag, Inc. > Review Board > Ticket #4712


Reply:

Not on me, the issue is at 
https://github.com/reviewboard/reviewboard/blob/master/reviewboard/reviews/models/status_update.py#L154
Simple logic bug of using `is` instead of `==` for string comparison.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4712: Internal Error when getting status updates when a previous status update is error.

2018-07-02 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4712/
--

New update by jcannon
For Beanbag, Inc. > Review Board > Ticket #4712


Reply:

Do you have a traceback from the log file?


Status:
- New
+ NeedInfo

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Review Board Ticket #4712: Internal Error when getting status updates when a previous status update is error.

2018-07-02 Thread Joshua Cannon
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4712/
--

New ticket #4712 by jcannon
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
Internal Error when getting status updates when a previous status update is 
error.
==

# What version are you running?
3.0

# What's the URL of the page containing the problem?
http://192.168.79.134/api/review-requests/3/status-updates/

# What steps will reproduce the problem?
1. Post a status update with the state "error"
2. Query for all status updates
3. Notice internal error


# What is the expected output? What do you see instead?
Expected the list of status updates, got internal error (500).

# What operating system are you using? What browser?
Hosting -> CentOS 7
Browsing -> Windows 10, Chrome

# Please provide any additional information below.


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


RBTools Ticket #4711: "putch() argument 1 must be char, not unicode" when authenticating

2018-07-02 Thread 'Angel Cascarino' via reviewboard-issues
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4711/
--

New ticket #4711 by ACascarino
For Beanbag, Inc. > RBTools

Status: New
Tags: Priority:Medium, Type:Defect


--
"putch() argument 1 must be char, not unicode" when authenticating
==

# What version are you running?
RBTools 1.0, Python 3.6.5

# What steps will reproduce the problem?
1. Delete .rbtools-cookies
2. Run rbt post
3. Enter username 


# What is the expected output? What do you see instead?
Expected output would be prompting to enter password.
Actual output is "putch() argument 1 must be char, not unicode"

# What operating system are you using?
Windows 7

# Attach the debug out from the command.

```
C:\eclipse_workspace>rbt post -o --debug
>>> RBTools 1.0
>>> Python 2.7.15 (v2.7.15:ca079a3ea3, Apr 30 2018, 16:22:17) [MSC v.1500 32 bit
 (Intel)]
>>> Running on Windows-7-6.1.7601-SP1
>>> Home = C:\Users\cascara01\AppData\Roaming
>>> Current directory = C:\eclipse_workspace
>>> Command line: rbt post -o --debug
>>> Running: tf vc help
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> Repository info: Path: http://visualsvn.{company}.co.uk/svn/280, Base path: 
>>> /t
runk, Supports changesets: False
>>> Making HTTP GET request to https://reviewboard.{company}.co.uk/api/

Please log in to the Review Board server at reviewboard.{company}.co.uk.
Username: CascarA01
Traceback (most recent call last):
  File "C:\Program Files (x86)\RBTools\bin..\Python27\Scripts\rbt-script.py", l
ine 11, in 
load_entry_point('RBTools==1.0', 'console_scripts', 'rbt')()
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\commands\main.py", line 120, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\commands__init__.py", line 720, in run_from_argv
exit_code = self.main(*args) or 0
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\commands\post.py", line 758, in main
api_client, api_root = self.get_api(server_url)
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\commands__init__.py", line 899, in get_api
api_root = api_client.get_root()
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\api\client.py", line 21, in get_root
return self._transport.get_root(*args, **kwargs)
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\api\transport\sync.py", line 49, in get_root
return self._execute_request(HttpRequest(self.server.url))
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\api\transport\sync.py", line 86, in _execute_request
rsp = self.server.make_request(request)
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\api\request.py", line 601, in make_request
request.url, body, headers, request.method))
  File "C:\Program Files (x86)\RBTools\Python27\lib\urllib2.py", line 154, in ur
lopen
return opener.open(url, data, timeout)
  File "C:\Program Files (x86)\RBTools\Python27\lib\urllib2.py", line 435, in op
en
response = meth(req, response)
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\api\request.py", line 239, in http_response
response.info())
  File "C:\Program Files (x86)\RBTools\Python27\lib\urllib2.py", line 467, in er
ror
result = self._call_chain(*args)
  File "C:\Program Files (x86)\RBTools\Python27\lib\urllib2.py", line 407, in _c
all_chain
result = func(*args)
  File "C:\Program Files (x86)\RBTools\Python27\lib\urllib2.py", line 909, in ht
tp_error_401
url, req, headers)
  File "C:\Program Files (x86)\RBTools\Python27\lib\urllib2.py", line 887, in ht
tp_error_auth_reqed
return self.retry_http_basic_auth(host, req, realm)
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\api\request.py", line 281, in retry_http_basic_auth
response = self._do_http_basic_auth(host, request, realm)
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\api\request.py", line 289, in _do_http_basic_auth
user, password = self.passwd.find_user_password(realm, host)
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\api\request.py", line 358, in find_user_password
password=self.rb_pa