Re: RBTools Ticket #4711: "putch() argument 1 must be char, not unicode" when authenticating

2018-07-05 Thread 'Angel Cascarino' via reviewboard-issues
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4711/
--

New update by ACascarino
For Beanbag, Inc. > RBTools > Ticket #4711


Reply:

Out of interest is there documentation on the testing and release process 
for RBTools? I'm just aware that this isn't a minor bug, and indeed hits every 
new user - is there anywhere I can help at all? I've a reasonable amount of 
experience with testing strategies and CI and would be happy to dive in if 
there's somewhere I can help out :)

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


RBTools Ticket #4711: "putch() argument 1 must be char, not unicode" when authenticating

2018-07-02 Thread 'Angel Cascarino' via reviewboard-issues
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4711/
--

New ticket #4711 by ACascarino
For Beanbag, Inc. > RBTools

Status: New
Tags: Priority:Medium, Type:Defect


--
"putch() argument 1 must be char, not unicode" when authenticating
==

# What version are you running?
RBTools 1.0, Python 3.6.5

# What steps will reproduce the problem?
1. Delete .rbtools-cookies
2. Run rbt post
3. Enter username 


# What is the expected output? What do you see instead?
Expected output would be prompting to enter password.
Actual output is "putch() argument 1 must be char, not unicode"

# What operating system are you using?
Windows 7

# Attach the debug out from the command.

```
C:\eclipse_workspace>rbt post -o --debug
>>> RBTools 1.0
>>> Python 2.7.15 (v2.7.15:ca079a3ea3, Apr 30 2018, 16:22:17) [MSC v.1500 32 bit
 (Intel)]
>>> Running on Windows-7-6.1.7601-SP1
>>> Home = C:\Users\cascara01\AppData\Roaming
>>> Current directory = C:\eclipse_workspace
>>> Command line: rbt post -o --debug
>>> Running: tf vc help
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Running: diff --version
>>> Running: svn --non-interactive --version -q
>>> Repository info: Path: http://visualsvn.{company}.co.uk/svn/280, Base path: 
>>> /t
runk, Supports changesets: False
>>> Making HTTP GET request to https://reviewboard.{company}.co.uk/api/

Please log in to the Review Board server at reviewboard.{company}.co.uk.
Username: CascarA01
Traceback (most recent call last):
  File "C:\Program Files (x86)\RBTools\bin..\Python27\Scripts\rbt-script.py", l
ine 11, in 
load_entry_point('RBTools==1.0', 'console_scripts', 'rbt')()
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\commands\main.py", line 120, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\commands__init__.py", line 720, in run_from_argv
exit_code = self.main(*args) or 0
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\commands\post.py", line 758, in main
api_client, api_root = self.get_api(server_url)
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\commands__init__.py", line 899, in get_api
api_root = api_client.get_root()
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\api\client.py", line 21, in get_root
return self._transport.get_root(*args, **kwargs)
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\api\transport\sync.py", line 49, in get_root
return self._execute_request(HttpRequest(self.server.url))
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\api\transport\sync.py", line 86, in _execute_request
rsp = self.server.make_request(request)
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\api\request.py", line 601, in make_request
request.url, body, headers, request.method))
  File "C:\Program Files (x86)\RBTools\Python27\lib\urllib2.py", line 154, in ur
lopen
return opener.open(url, data, timeout)
  File "C:\Program Files (x86)\RBTools\Python27\lib\urllib2.py", line 435, in op
en
response = meth(req, response)
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\api\request.py", line 239, in http_response
response.info())
  File "C:\Program Files (x86)\RBTools\Python27\lib\urllib2.py", line 467, in er
ror
result = self._call_chain(*args)
  File "C:\Program Files (x86)\RBTools\Python27\lib\urllib2.py", line 407, in _c
all_chain
result = func(*args)
  File "C:\Program Files (x86)\RBTools\Python27\lib\urllib2.py", line 909, in ht
tp_error_401
url, req, headers)
  File "C:\Program Files (x86)\RBTools\Python27\lib\urllib2.py", line 887, in ht
tp_error_auth_reqed
return self.retry_http_basic_auth(host, req, realm)
  File "C:\Program Files (x86)\RBTools\Python27\lib\site-packages\rbtools-1.0-py
2.7.egg\rbtools\api\request.py", line 281, in retry_http_basic_auth
response = self._do_http_basic_auth(host, request, realm)
  File "C:\Program Files (x86)\RBTools\Pyth

Review Board Ticket #4553: REST API fails when updating an existing default reviewers rule with >1 group/user/repository to 0 group/user/repository.

2017-05-19 Thread 'Kyle Kelly' via reviewboard-issues
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4553/
--

New ticket #4553 by kkelly
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
REST API fails when updating an existing default reviewers rule with >1 
group/user/repository to 0 group/user/repository.
==

# What version are you running?
2.5.7

# What's the URL of the page containing the problem?
PUT on http://reviewboard.example/api/default-reviewers/$ID/ with data:
```
{
users: '',
groups: '',
repositories: '',
}
```

# What steps will reproduce the problem?
1. Create a default-reviewer rule with >1 user OR group OR repository
2. PUT to default-reviewer resource web api to set field to have no entries


# What is the expected output? What do you see instead?
I expect the PUT to update the default reviewer rule to have no users, groups, 
or repositories.

# What operating system are you using? What browser?
Server on ubuntu 14.04. Web browser Chrome 59 + macOS


# Please provide any additional information below.
The issue appears to be the `.split(',')` calls on these fields here: 
https://github.com/reviewboard/reviewboard/blob/master/reviewboard/webapi/resources/default_reviewer.py#L258

That will return `['']`, which will then be used for model lookup and fail.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3198 in reviewboard: Downloaded patch files contain hash values that don't match content

2015-11-07 Thread reviewboard


Comment #1 on issue 3198 by prog...@gmail.com: Downloaded patch files  
contain hash values that don't match content

https://code.google.com/p/reviewboard/issues/detail?id=3198

Probably a duplicate of Issue 2916

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 2916 in reviewboard: Review Board does not respect line endings

2015-11-07 Thread reviewboard


Comment #23 on issue 2916 by prog...@gmail.com: Review Board does not  
respect line endings

https://code.google.com/p/reviewboard/issues/detail?id=2916

I think issue 3198 is another duplicate of this issue

This issue issue affect me too- i need the patch to preserve the original  
CRLFs to be able to cleanly apply the patches.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 2916 in reviewboard: Review Board does not respect line endings

2015-11-07 Thread reviewboard


Comment #24 on issue 2916 by chip...@gmail.com: Review Board does not  
respect line endings

https://code.google.com/p/reviewboard/issues/detail?id=2916

This bug has moved to https://hellosplat.com/s/beanbag/tickets/2916/.  
Please post any updates there. You can use your existing Google login.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3299 in reviewboard: 500 Internal Server Error

2015-10-27 Thread reviewboard


Comment #8 on issue 3299 by farid.m@gmail.com: 500 Internal Server Error
https://code.google.com/p/reviewboard/issues/detail?id=3299

I had to do 'pip install mod_wsgi  '

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3446 in reviewboard: ReviewRequestFieldsHook and email notfications

2015-10-26 Thread reviewboard


Comment #5 on issue 3446 by ke...@keithmoyer.com: ReviewRequestFieldsHook  
and email notfications

https://code.google.com/p/reviewboard/issues/detail?id=3446

Any chance this will make it into Review Board 2.5?

Not trying to rush it; just making sure it wasn't forgotten since you  
mentioned you'd like to add this functionality.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3446 in reviewboard: ReviewRequestFieldsHook and email notfications

2015-10-26 Thread reviewboard


Comment #6 on issue 3446 by chip...@gmail.com: ReviewRequestFieldsHook and  
email notfications

https://code.google.com/p/reviewboard/issues/detail?id=3446

Hi Keith,

This bug has moved over to https://hellosplat.com/s/beanbag/tickets/3446/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 2777 in reviewboard: rbssh is very slow

2015-10-14 Thread reviewboard


Comment #2 on issue 2777 by vlad.rom...@gmail.com: rbssh is very slow
https://code.google.com/p/reviewboard/issues/detail?id=2777

Replace the contents of /usr/bin/rbssh with the following:


#!/bin/sh
EXTRA_OPTS="-o UserKnownHostsFile=$HOME/.ssh/known_hosts -o ForwardX11=no  
-o LogLevel=ERROR"

# see https://en.wikibooks.org/wiki/OpenSSH/Cookbook/Multiplexing
EXTRA_OPTS="-o ControlPath=/tmp/master-%r@%h:%p -o ControlMaster=auto -o  
ControlPersist=10m $EXTRA_OPTS"

for k in $HOME/.ssh/id_{dsa,rsa} ; do
  test -e "$k" && EXTRA_OPTS="$EXTRA_OPTS -i $k"
done
exec /usr/bin/ssh $EXTRA_OPTS "$@"


Using native ssh was about 5x faster than the default Python rbssh  
implementation.  Moreover, using the connection multiplexing feature of ssh  
further sped up things another 5x or so.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3965 in reviewboard: View diff fails for C/C++ files from unified CVS diff

2015-10-09 Thread reviewboard


Comment #2 on issue 3965 by boris.bo...@gmail.com: View diff fails for  
C/C++ files from unified CVS diff

https://code.google.com/p/reviewboard/issues/detail?id=3965

Further investigation shows that the issue with C/C++ code only appears if  
the diff is created based on two CVS revisions. If the diff is created  
based on local changes against HEAD, the diff is shown fine for C/C++ files.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3965 in reviewboard: View diff fails for C/C++ files from unified CVS diff

2015-10-09 Thread reviewboard


Comment #3 on issue 3965 by chip...@gmail.com: View diff fails for C/C++  
files from unified CVS diff

https://code.google.com/p/reviewboard/issues/detail?id=3965

Hi Boris,

This bug has moved to https://hellosplat.com/s/beanbag/tickets/3965/. You  
can log in with your Google account there and update the bug report.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3252 in reviewboard: http://downloads.reviewboard.org/nightlies/ does not exist

2015-10-07 Thread reviewboard


Comment #7 on issue 3252 by akashseo...@gmail.com:  
http://downloads.reviewboard.org/nightlies/ does not exist

https://code.google.com/p/reviewboard/issues/detail?id=3252

Thanks for all your information, Website is very nice and informative  
content.

Packers and Movers in Faridabad @
http://www.expert5th.in/packers-and-movers-faridabad/
Packers and Movers in Noida @
http://www.expert5th.in/packers-and-movers-noida/
Packers and Movers in Thane @
http://www.expert5th.in/packers-and-movers-thane/
Packers and Movers in Navi Mumbai @
http://www.expert5th.in/packers-and-movers-navimumbai/
Packers and Movers in Ghaziabad @
http://www.expert5th.in/packers-and-movers-ghaziabad/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3252 in reviewboard: http://downloads.reviewboard.org/nightlies/ does not exist

2015-10-07 Thread reviewboard


Comment #9 on issue 3252 by akashseo...@gmail.com:  
http://downloads.reviewboard.org/nightlies/ does not exist

https://code.google.com/p/reviewboard/issues/detail?id=3252


Thanks for post this helpful post - Please visit for More information about  
-

Packers and Movers in Chennai @
http://www.expert5th.in/packers-and-movers-chennai/
Packers and Movers in Hyderabad @
http://www.expert5th.in/packers-and-movers-hyderabad/
Packers and Movers in Pune @
http://www.expert5th.in/packers-and-movers-pune/
Packers and Movers in Mumbai @
http://www.expert5th.in/packers-and-movers-mumbai/
Packers and Movers India @ http://www.expert5th.in/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3252 in reviewboard: http://downloads.reviewboard.org/nightlies/ does not exist

2015-10-07 Thread reviewboard


Comment #6 on issue 3252 by akashseo...@gmail.com:  
http://downloads.reviewboard.org/nightlies/ does not exist

https://code.google.com/p/reviewboard/issues/detail?id=3252



This article is really fantastic and thanks for sharing the valuable post.
Packers and Movers in Gurgaon @
http://www.expert5th.in/packers-and-movers-gurgaon/
Packers and Movers in Delhi @
http://www.expert5th.in/packers-and-movers-delhi/
Packers and Movers in Bangalore @
http://www.expert5th.in/packers-and-movers-bangalore/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3252 in reviewboard: http://downloads.reviewboard.org/nightlies/ does not exist

2015-10-07 Thread reviewboard


Comment #4 on issue 3252 by akashseo...@gmail.com:  
http://downloads.reviewboard.org/nightlies/ does not exist

https://code.google.com/p/reviewboard/issues/detail?id=3252

Thanks for post this helpful post - Please visit for More information about  
-

Packers and Movers in Chennai @
http://www.expert5th.in/packers-and-movers-chennai/
Packers and Movers in Hyderabad @
http://www.expert5th.in/packers-and-movers-hyderabad/
Packers and Movers in Pune @
http://www.expert5th.in/packers-and-movers-pune/
Packers and Movers in Mumbai @
http://www.expert5th.in/packers-and-movers-mumbai/
Packers and Movers India @ http://www.expert5th.in/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3252 in reviewboard: http://downloads.reviewboard.org/nightlies/ does not exist

2015-10-07 Thread reviewboard


Comment #10 on issue 3252 by akashseo...@gmail.com:  
http://downloads.reviewboard.org/nightlies/ does not exist

https://code.google.com/p/reviewboard/issues/detail?id=3252



Thanks for all your information, Website is very nice and informative  
content.

Packers and Movers in Faridabad @
http://www.expert5th.in/packers-and-movers-faridabad/
Packers and Movers in Noida @
http://www.expert5th.in/packers-and-movers-noida/
Packers and Movers in Thane @
http://www.expert5th.in/packers-and-movers-thane/
Packers and Movers in Navi Mumbai @
http://www.expert5th.in/packers-and-movers-navimumbai/
Packers and Movers in Ghaziabad @
http://www.expert5th.in/packers-and-movers-ghaziabad/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3252 in reviewboard: http://downloads.reviewboard.org/nightlies/ does not exist

2015-10-07 Thread reviewboard


Comment #8 on issue 3252 by akashseo...@gmail.com:  
http://downloads.reviewboard.org/nightlies/ does not exist

https://code.google.com/p/reviewboard/issues/detail?id=3252

Thanks for post this helpful post - Please visit for More information about  
-

Packers and movers in Gurgaon @
http://www.dteller.in/packers-and-movers-gurgaon/
Packers and Movers in Bangalore @
http://www.dteller.in/packers-and-movers-bangalore/
Packers and Movers in Hyderabad @
http://www.dteller.in/packers-and-movers-hyderabad/
Packers and Movers in Pune @
http://www.dteller.in/packers-and-movers-pune/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3252 in reviewboard: http://downloads.reviewboard.org/nightlies/ does not exist

2015-10-07 Thread reviewboard


Comment #5 on issue 3252 by akashseo...@gmail.com:  
http://downloads.reviewboard.org/nightlies/ does not exist

https://code.google.com/p/reviewboard/issues/detail?id=3252

Thanks for post this helpful post - Please visit for More information about  
-

Packers and Movers in Chennai @
http://www.expert5th.in/packers-and-movers-chennai/
Packers and Movers in Hyderabad @
http://www.expert5th.in/packers-and-movers-hyderabad/
Packers and Movers in Pune @
http://www.expert5th.in/packers-and-movers-pune/
Packers and Movers in Mumbai @
http://www.expert5th.in/packers-and-movers-mumbai/
Packers and Movers India @ http://www.expert5th.in/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3252 in reviewboard: http://downloads.reviewboard.org/nightlies/ does not exist

2015-10-07 Thread reviewboard


Comment #11 on issue 3252 by akashseo...@gmail.com:  
http://downloads.reviewboard.org/nightlies/ does not exist

https://code.google.com/p/reviewboard/issues/detail?id=3252

Thanks for post this helpful post - Please visit for More information about  
-

Packers and movers in Gurgaon @
http://www.dteller.in/packers-and-movers-gurgaon/
Packers and Movers in Bangalore @
http://www.dteller.in/packers-and-movers-bangalore/
Packers and Movers in Hyderabad @
http://www.dteller.in/packers-and-movers-hyderabad/
Packers and Movers in Pune @
http://www.dteller.in/packers-and-movers-pune/


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 1125 in reviewboard: server port number is missing in review request email

2015-09-29 Thread reviewboard


Comment #12 on issue 1125 by konrad.m...@motorolasolutions.com: server port  
number is missing in review request email

https://code.google.com/p/reviewboard/issues/detail?id=1125

ReviewBoard  2.0.20 - same issue.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3184 in reviewboard: rbt status fails with perforce repository

2015-09-21 Thread reviewboard


Comment #8 on issue 3184 by aniru...@sdrc.co.in: rbt status fails with  
perforce repository

https://code.google.com/p/reviewboard/issues/detail?id=3184

I have same problem having rbt tools 0.7.4 and review Board 1.7.20


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3184 in reviewboard: rbt status fails with perforce repository

2015-09-21 Thread reviewboard


Comment #9 on issue 3184 by chip...@gmail.com: rbt status fails with  
perforce repository

https://code.google.com/p/reviewboard/issues/detail?id=3184

This bug has been moved to https://hellosplat.com/s/beanbag/tickets/3184/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 180 in reviewboard: "replying" to previous comments in the diff viewer is confusing

2015-09-18 Thread reviewboard


Comment #9 on issue 180 by busuparm...@gmail.com: "replying" to previous  
comments in the diff viewer is confusing

https://code.google.com/p/reviewboard/issues/detail?id=180

using windows xp easier than with Windows 8
http://www.goapindulgelaran.com

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 180 in reviewboard: "replying" to previous comments in the diff viewer is confusing

2015-09-18 Thread reviewboard


Comment #10 on issue 180 by busuparm...@gmail.com: "replying" to previous  
comments in the diff viewer is confusing

https://code.google.com/p/reviewboard/issues/detail?id=180

using windows xp easier than with Windows 8 from me href="http://www.goapindulgelaran.com;>Wisata Jogja


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 180 in reviewboard: "replying" to previous comments in the diff viewer is confusing

2015-09-18 Thread reviewboard


Comment #11 on issue 180 by busuparm...@gmail.com: "replying" to previous  
comments in the diff viewer is confusing

https://code.google.com/p/reviewboard/issues/detail?id=180

using windows xp easier than with Windows 8
http://www.goapindulgelaran.com

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3145 in reviewboard: Cannot add review comments to attached text files

2015-09-16 Thread reviewboard


Comment #3 on issue 3145 by khairula...@gmail.com: Cannot add review  
comments to attached text files

https://code.google.com/p/reviewboard/issues/detail?id=3145

thank you information sir
http://www.taspriaonline.com/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 773 in reviewboard: Add Bazaar (bzr) support to post-review

2015-09-16 Thread reviewboard


Comment #9 on issue 773 by khairula...@gmail.com: Add Bazaar (bzr) support  
to post-review

https://code.google.com/p/reviewboard/issues/detail?id=773

Bzr support is one of the strongest incentives for using reviewboard.
http://www.taspriaonline.com/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs

2015-09-15 Thread reviewboard


Comment #6 on issue 3966 by griffin@gmail.com: Uploading a revision to  
a CR twice before publishing creates bad partial diffs

https://code.google.com/p/reviewboard/issues/detail?id=3966

I observed the same behavior this morning with 2.0.19 and Firefox (I don't  
have the FF version in front of me right now, but it should be 40.0.3 or  
very close).  My procedure pretty much follows the one outlined above.   
Took me a little while to work through this.  I kept re-posting from  
RBTools thinking I was losing my mind!  Eventually a Ctrl-F5 to override  
the FF cache did the trick.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3967 in reviewboard: upgrade from 2.0.18 to 2.0.20 get error

2015-09-14 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3967 by shirph...@126.com: upgrade from 2.0.18 to 2.0.20 get error
https://code.google.com/p/reviewboard/issues/detail?id=3967

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
2.0.20

What's the URL of the page containing the problem?
http://shreview02

What steps will reproduce the problem?
1.sudo easy_install -U ReviewBoard
2.sudo rb-site upgrade /var/www/reviewboard
3.get the error

What is the expected output? What do you see instead?
It should be successfully, but I get the error:
Rebuilding directory structure
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

--  --
Creating tables ...
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
The stored evolutions do not completely resolve all model changes.

Run `./manage.py evolve --hint` to see a suggestion for the changes  
required.


The following are the changes that could not be resolved:
In model reviews.ReviewRequest:
Field 'description_rich_text' has been added
Field 'testing_done_rich_text' has been added
In model reviews.Review:
Field 'body_top_rich_text' has been added
Field 'body_bottom_rich_text' has been added
In model reviews.ReviewRequestDraft:
Field 'description_rich_text' has been added
Field 'testing_done_rich_text' has been added
In model accounts.Profile:
Field 'default_use_rich_text' has been added
CommandError: Your models contain changes that Django Evolution cannot  
resolve automatically.


I remember there is the same error last upgrade to 2.0.18, but I ignore it  
because I found the 2.0.18 version number when I login the reviewboard page.


What operating system are you using? What browser?
Ubuntu 12.04, chrome

yihuihu@shreview02:/var/www/dbback$ sudo rb-site manage  
/var/www/reviewboard evolve -- --hint

[sudo] password for yihuihu:
#- Evolution for accounts
from django_evolution.mutations import AddField
from django.db import models


MUTATIONS = [
AddField('Profile', 'default_use_rich_text', models.NullBooleanField,  
null=True)

]
#--
#- Evolution for reviews
from django_evolution.mutations import AddField
from django.db import models


MUTATIONS = [
AddField('ReviewRequest', 'description_rich_text', models.BooleanField,  
initial=False),
AddField('ReviewRequest', 'testing_done_rich_text',  
models.BooleanField, initial=False),
AddField('Review', 'body_top_rich_text', models.BooleanField,  
initial=False),
AddField('Review', 'body_bottom_rich_text', models.BooleanField,  
initial=False),
AddField('ReviewRequestDraft', 'description_rich_text',  
models.BooleanField, initial=False),
AddField('ReviewRequestDraft', 'testing_done_rich_text',  
models.BooleanField, initial=False)

]
#--
Trial evolution successful.
yihuihu@shreview02:/var/www/dbback$ sudo rb-site manage  
/var/www/reviewboard list-evolutions

Applied evolutions for 'auth':
auth_delete_message
auth_unique_together_baseline

Applied evolutions for 'contenttypes':
contenttypes_unique_together_baseline

Applied evolutions for 'sessions':
session_expire_date_db_index

Applied evolutions for 'accounts':
is_private
timezone
open_an_issue
extra_data
timezone_length_30
localsiteprofile_permissions
unique_together_baseline
profile_show_closed
profile_should_send_email
profile_should_send_own_updates
profile_default_use_rich_text

Applied evolutions for 'attachments':
file_attachment_orig_filename
file_attachment_file_max_length_512
file_attachment_repo_info
file_attachment_repo_path_no_index
file_attachment_repo_revision_max_length_64

Applied evolutions for 'changedescs':
fields_changed_longtext
rich_text

Applied evolutions for 'diffviewer':
add_parent_diffs
filediff_filenames_1024_chars
diffset_basedir
filediff_status
add_diff_hash
diffsethistory_diff_updated
diffset_base_commit_id
filediffdata_line_counts
filediffdata_extra_data
all_extra_data

Applied evolutions for 'hostingsvcs':
account_hosting_url
account_hosting_url_max_length_255

Re: Issue 3967 in reviewboard: upgrade from 2.0.18 to 2.0.20 get error

2015-09-14 Thread reviewboard


Comment #3 on issue 3967 by shirph...@126.com: upgrade from 2.0.18 to  
2.0.20 get error

https://code.google.com/p/reviewboard/issues/detail?id=3967

yihuihu@shreview02:/var/www$ sudo rb-site manage /var/www/reviewboard  
list-evolutions

[sudo] password for yihuihu:
Applied evolutions for 'auth':
auth_delete_message
auth_unique_together_baseline

Applied evolutions for 'contenttypes':
contenttypes_unique_together_baseline

Applied evolutions for 'sessions':
session_expire_date_db_index

Applied evolutions for 'accounts':
is_private
timezone
open_an_issue
extra_data
timezone_length_30
localsiteprofile_permissions
unique_together_baseline
profile_show_closed
profile_should_send_email
profile_should_send_own_updates
profile_default_use_rich_text

Applied evolutions for 'attachments':
file_attachment_orig_filename
file_attachment_file_max_length_512
file_attachment_repo_info
file_attachment_repo_path_no_index
file_attachment_repo_revision_max_length_64

Applied evolutions for 'changedescs':
fields_changed_longtext
rich_text

Applied evolutions for 'diffviewer':
add_parent_diffs
filediff_filenames_1024_chars
diffset_basedir
filediff_status
add_diff_hash
diffsethistory_diff_updated
diffset_base_commit_id
filediffdata_line_counts
filediffdata_extra_data
all_extra_data

Applied evolutions for 'hostingsvcs':
account_hosting_url
account_hosting_url_max_length_255
account_unique_together_baseline

Applied evolutions for 'reviews':
change_descriptions
last_review_timestamp
shipit_count
default_reviewer_repositories
null_repository
localsite
group_incoming_request_count
group_invite_only
group_visible
default_reviewer_local_site
add_issues_to_comments
file_attachments
file_attachment_comment_extra_data
review_request_last_review_activity_timestamp
review_request_depends_on
commit_id
file_attachment_comment_diff_id
rich_text
base_comment_extra_data
unique_together_baseline
extra_data
review_request_issue_counts
group_mailing_list_charfield
review_request_draft_commit_id
review_request_summary_index
review_request_summary_index_manual
split_rich_text

Applied evolutions for 'scmtools':
bugzilla_url_charfield
repository_raw_file_url
repository_visible
repository_path_length_255
localsite
repository_access_control
group_site
repository_hosting_accounts
repository_extra_data_null
unique_together_baseline
repository_archive
repository_hooks_uuid
repository_raw_password

Applied evolutions for 'site':
localsite_public

yihuihu@shreview02:/var/www$


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3967 in reviewboard: upgrade from 2.0.18 to 2.0.20 get error

2015-09-14 Thread reviewboard


Comment #5 on issue 3967 by shirph...@126.com: upgrade from 2.0.18 to  
2.0.20 get error

https://code.google.com/p/reviewboard/issues/detail?id=3967

OK , I got the result from command line:


from django_evolution.models import Version
for version in Version.objects.all(): print version

...
Hinted version, updated on 2015-02-12 02:23:19+00:00
Stored version, updated on 2015-02-12 02:23:19+00:00
Stored version, updated on 2014-11-13 01:53:34+00:00
Stored version, updated on 2014-08-08 02:26:47+00:00
Stored version, updated on 2014-06-04 08:17:08+00:00
Hinted version, updated on 2014-06-04 08:17:07+00:00
Stored version, updated on 2014-04-22 23:13:10+00:00
Stored version, updated on 2013-11-19 10:56:17+00:00



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3967 in reviewboard: upgrade from 2.0.18 to 2.0.20 get error

2015-09-14 Thread reviewboard

Updates:
Status: NeedInfo

Comment #2 on issue 3967 by chip...@gmail.com: upgrade from 2.0.18 to  
2.0.20 get error

https://code.google.com/p/reviewboard/issues/detail?id=3967

Sounds like your database is in a bad state. It needs to be repaired, or  
this will just continue to happen, and upgrades to future versions will  
most likely fail.


Can you run the following and post the output:

$ rb-site manage /path/to/site list-evolutions

$ rb-site manage /path/to/site shell
>>> from django_evolution.models import Version
>>> for version in Version.objects.all():
>>>  print version

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3967 in reviewboard: upgrade from 2.0.18 to 2.0.20 get error

2015-09-14 Thread reviewboard


Comment #1 on issue 3967 by shirph...@126.com: upgrade from 2.0.18 to  
2.0.20 get error

https://code.google.com/p/reviewboard/issues/detail?id=3967

admin --- database ---DJANGO_EVOLUTION --- versions:
Stored version, updated on 2015-02-12 02:23:19+00:00
Hinted version, updated on 2015-02-12 02:23:19+00:00
Stored version, updated on 2014-11-13 01:53:34+00:00
Stored version, updated on 2014-08-08 02:26:47+00:00
Stored version, updated on 2014-06-04 08:17:08+00:00
Hinted version, updated on 2014-06-04 08:17:07+00:00
Stored version, updated on 2014-04-22 23:13:10+00:00
Stored version, updated on 2013-11-19 10:56:17+00:00

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3967 in reviewboard: upgrade from 2.0.18 to 2.0.20 get error

2015-09-14 Thread reviewboard


Comment #4 on issue 3967 by shirph...@126.com: upgrade from 2.0.18 to  
2.0.20 get error

https://code.google.com/p/reviewboard/issues/detail?id=3967

for admin --- database --- django_evolution - versions, get the  
following list in web UI:

Stored version, updated on 2015-02-12 02:23:19+00:00
Hinted version, updated on 2015-02-12 02:23:19+00:00
Stored version, updated on 2014-11-13 01:53:34+00:00
Stored version, updated on 2014-08-08 02:26:47+00:00
Stored version, updated on 2014-06-04 08:17:08+00:00
Hinted version, updated on 2014-06-04 08:17:07+00:00
Stored version, updated on 2014-04-22 23:13:10+00:00
Stored version, updated on 2013-11-19 10:56:17+00:00
8 versions

I can not run the command with the error:
yihuihu@shreview02:/var/www$ sudo rb-site manage /var/www/reviewboard/ shell
Python 2.7.3 (default, Sep 26 2013, 20:03:06)
[GCC 4.6.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)

from django_evolution.models import Version
for version in Version.objects.all():

... print version
  File "", line 2
print version
^
IndentationError: expected an indented block


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3967 in reviewboard: upgrade from 2.0.18 to 2.0.20 get error

2015-09-14 Thread reviewboard


Comment #6 on issue 3967 by chip...@gmail.com: upgrade from 2.0.18 to  
2.0.20 get error

https://code.google.com/p/reviewboard/issues/detail?id=3967

Okay, something to try:

First, back up your database. We will be doing something that might require  
re-loading it back in.


Second, go back in the Python shell and do:

>>> from django_evolution.models import Version
>>> v = Version.objects.all()[0]
>>> print v

At that point, it should say "Hinted version, updated on 2015-02-12  
02:23:19+00:00". If it doesn't, stop, and let me know.


Then do:

>>> v.delete()

Then repeat the rb-site upgrade.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3967 in reviewboard: upgrade from 2.0.18 to 2.0.20 get error

2015-09-14 Thread reviewboard

Updates:
Status: Fixed

Comment #8 on issue 3967 by chip...@gmail.com: upgrade from 2.0.18 to  
2.0.20 get error

https://code.google.com/p/reviewboard/issues/detail?id=3967

Glad to hear it! :)

We've seen this in a couple of cases, but it's very unclear why it's  
happening.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3967 in reviewboard: upgrade from 2.0.18 to 2.0.20 get error

2015-09-14 Thread reviewboard


Comment #7 on issue 3967 by shirph...@126.com: upgrade from 2.0.18 to  
2.0.20 get error

https://code.google.com/p/reviewboard/issues/detail?id=3967

Thanks you very very very much, It works now.


from django_evolution.models import Version
v = Version.objects.all()[0]
print v

Hinted version, updated on 2015-02-12 02:23:19+00:00

v.delete()



yihuihu@shreview02:/var/www$ sudo rb-site upgrade /var/www/reviewboard/
[sudo] password for yihuihu:
Rebuilding directory structure
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

--  --
Creating tables ...
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
No evolution required.
---  ---

Resetting in-database caches.

Upgrade complete!


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3841 in reviewboard: rbtools.api.request hardcodes http return codes

2015-09-13 Thread reviewboard


Comment #6 on issue 3841 by anthonyh...@gmail.com: rbtools.api.request  
hardcodes http return codes

https://code.google.com/p/reviewboard/issues/detail?id=3841

I'll pick this up as an easy-fix bug.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3841 in reviewboard: rbtools.api.request hardcodes http return codes

2015-09-13 Thread reviewboard


Comment #7 on issue 3841 by anthonyh...@gmail.com: rbtools.api.request  
hardcodes http return codes

https://code.google.com/p/reviewboard/issues/detail?id=3841

Review Request #7625 created for this issue.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs

2015-09-11 Thread reviewboard


Comment #5 on issue 3966 by physicss...@gmail.com: Uploading a revision to  
a CR twice before publishing creates bad partial diffs

https://code.google.com/p/reviewboard/issues/detail?id=3966

It looks like once I've looked at diff/2 and diff/1-2, they get cached in a  
cookie.
When I update the request, looking at diff/2 gives me an updated diff and  
looking at diff/1-2 gives a 304 NOT MODIFIED.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing

2015-09-11 Thread reviewboard


Comment #6 on issue 3963 by paul.man...@alcatel-lucent.com: markdown in the  
field Note to Reviewers gets quoted with backslashes after editing

https://code.google.com/p/reviewboard/issues/detail?id=3963

I re-read what you wrote and changed browser URL as required and downloaded  
the payload. I can't send that to you, it contains a load of private  
information.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing

2015-09-11 Thread reviewboard


Comment #5 on issue 3963 by paul.man...@alcatel-lucent.com: markdown in the  
field Note to Reviewers gets quoted with backslashes after editing

https://code.google.com/p/reviewboard/issues/detail?id=3963

I don't have any admin rights on our server running reviewboard so I can  
only tell you what I am doing and what happens. I will ask our sysadmins if  
they can help you.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3965 in reviewboard: View diff fails for C/C++ files from unified CVS diff

2015-09-10 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3965 by boris.bo...@gmail.com: View diff fails for C/C++ files  
from unified CVS diff

https://code.google.com/p/reviewboard/issues/detail?id=3965

What version are you running?
Review Board 2.0.18

What's the URL of the page containing the problem?
http://vmreviewboard.dsa-ac.de/r/22/diff/1#index_header

What steps will reproduce the problem?
1. Upload unified diff with C/C++ implementation and header files
2. View diff

What is the expected output? What do you see instead?
Expected is a diff for C/C++ files but instead only an error is shown. Non  
C/C++ files from the same diff file (Makefile, ini files, ...) are shown  
correctly.


What operating system are you using? What browser?
Fedora 20, Chrome 45.0.2454.85

Please provide any additional information below.

--
The patch to 'app/tester/dtm/src/dtmmain.cpp' didn't apply cleanly. The  
temporary files have been left in '/tmp/reviewboard.UtdaSy' for debugging  
purposes.

`patch` returned:

 This may be a bug in the software, a temporary outage, or an issue
 with the format of your diff.

 Please try again, and if you still have trouble,
 contact support.

Details

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/views.py",  
line 265, in get

response = renderer.render_to_response(request)
   
File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py",  
line 56, in render_to_response

return HttpResponse(self.render_to_string(request))
   
File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py",  
line 74, in render_to_string

large_data=True)
  File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line  
111, in cache_memoize

data = lookup_callable()
   
File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py",  
line 73, in 

lambda: self.render_to_string_uncached(request),
   
File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py",  
line 87, in render_to_string_uncached

request=request)
   
File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/diffutils.py",  
line 422, in populate_diff_chunks

chunks = generator.get_chunks()
   
File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py",  
line 156, in get_chunks

large_data=True)
  File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line  
111, in cache_memoize

data = lookup_callable()
   
File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py",  
line 155, in 

    lambda: list(self._get_chunks_uncached()),
   
File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py",  
line 163, in _get_chunks_uncached

new = get_patched_file(old, self.filediff, self.request)
   
File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/diffutils.py",  
line 232, in get_patched_file

return patch(diff, buffer, filediff.dest_file, request)
   
File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/diffutils.py",  
line 168, in patch

'output': stderr,
Exception: The patch to 'app/tester/dtm/src/dtmmain.cpp' didn't apply  
cleanly. The temporary files have been left in '/tmp/reviewboard.UtdaSy'  
for debugging purposes.

`patch` returned:
---

The files in the tmp folder have not been created.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3965 in reviewboard: View diff fails for C/C++ files from unified CVS diff

2015-09-10 Thread reviewboard


Comment #1 on issue 3965 by boris.bo...@gmail.com: View diff fails for  
C/C++ files from unified CVS diff

https://code.google.com/p/reviewboard/issues/detail?id=3965

Correction Fedora version is 21.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing

2015-09-10 Thread reviewboard


Comment #3 on issue 3963 by paul.man...@alcatel-lucent.com: markdown in the  
field Note to Reviewers gets quoted with backslashes after editing

https://code.google.com/p/reviewboard/issues/detail?id=3963

Hi,
yes, I did publish the review with some notes-for-reviewers set, and then  
modified the field afterwards.
I can subsequently edit the field and remove the backslash and click OK and  
then the text gets re-emboldened. But when I publish the review the  
markdown gets re-enquoted into backslash hash, so the text becomes normal.



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs

2015-09-10 Thread reviewboard


Comment #4 on issue 3966 by physicss...@gmail.com: Uploading a revision to  
a CR twice before publishing creates bad partial diffs

https://code.google.com/p/reviewboard/issues/detail?id=3966

Some new info.

This appears to be a Chrome- or at least browser-related issue.

I cleared Chrome's browsing history and the data corrected itself.

It would seem Chrome thinks codereview/r/232/diff/1-2/ is a page it should  
cache, but codereview/r/232/diff/2/ is not.


So at least the reviewer will see the correct diff, even if the reviewee  
cannot.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs

2015-09-10 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3966 by physicss...@gmail.com: Uploading a revision to a CR twice  
before publishing creates bad partial diffs

https://code.google.com/p/reviewboard/issues/detail?id=3966

What version are you running?
  Reviewboard 2.0.19 and RBTools 0.7.4 for Windows
  I am using a git repository that is mounted as a directory
  on the reviewboard server.

What's the URL of the page containing the problem?
  /r/232/diff/1-2/

What steps will reproduce the problem?
  Summary: Upload and publish a CR then upload two move revisions
  before publishing the latter. The 1-2 diff will be incorrect.

  1. Create a code change with a diff (e.g. adding
 a line to a file that reads "Change #1") and run 'rbt post'
  2. Publish the review.
  3. Update the code change (e.g. change the line to
 say "Fake Change #2") and run 'rbt post -u'
  4. On reviewboard, view the diffs orig-1, orig-2 and 1-2,
 and verify that they show diffs between three versions
 of a file with a blank line, 'Change #1' and 'Fake
 Change #2', but DON'T publish.
  5. Update the code change once more (e.g. change the line
 to say 'Real Change #2) and run 'rbt post -u'
  6. On reviewboard, view the diffs once more. Verify that
 orig-2 shows that the line 'Real Change #2' has been
 added. Look at the diff 1-2 and notice that it says
 'Change #1' -> 'Fake Change #2', instead of
 'Change #1' -> 'Real Change #2'.

What is the expected output? What do you see instead?
  Expected output: All diffs accurately represent the difference
  between the respective versions of the code change.

Actual output:
  Diffs between orig and another commit are correct, but relative
  diffs (1-2) are out of date and show non-existent changes.

What operating system are you using? What browser?
  Windows 8.1 Pro 64-bit and latest Google Chrome (Version 45.0.2454.85 m)

Please provide any additional information below.
  It appears that the relative diffs between intermediate revisions
  and the latest revision are being stored at the moment that the latest
  revision is uploaded and not updated when the revision is updated
  prior to publishing it.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs

2015-09-10 Thread reviewboard


Comment #3 on issue 3966 by physicss...@gmail.com: Uploading a revision to  
a CR twice before publishing creates bad partial diffs

https://code.google.com/p/reviewboard/issues/detail?id=3966

I looked up how to flush memcached and ended up running
echo 'flush_all' | nc localhost 11211

This did not seem to fix the incorrect data.

If you give me more specific steps to check I can try those.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs

2015-09-10 Thread reviewboard

Updates:
Status: NeedInfo

Comment #2 on issue 3966 by chip...@gmail.com: Uploading a revision to a CR  
twice before publishing creates bad partial diffs

https://code.google.com/p/reviewboard/issues/detail?id=3966

As a test, what happens if you clear the server cache? Does the problem fix  
itself?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs

2015-09-10 Thread reviewboard


Comment #1 on issue 3966 by chip...@gmail.com: Uploading a revision to a CR  
twice before publishing creates bad partial diffs

https://code.google.com/p/reviewboard/issues/detail?id=3966

Thanks for the detailed reproduction steps!

We generate the changes between diffs on-the-fly by patching the source  
files for each revision with the accompanying patches, and then generating  
a side-by-side diff.


It sounds like this may be a caching issue. We've heard of such issues from  
a recent release, but haven't had a good repro case. I'll give this a try  
and see what we can see.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing

2015-09-10 Thread reviewboard


Comment #4 on issue 3963 by chip...@gmail.com: markdown in the field Note  
to Reviewers gets quoted with backslashes after editing

https://code.google.com/p/reviewboard/issues/detail?id=3963

Would you be able to get the API payloads for me at each stage? That'll  
tell me more.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3747 in reviewboard: Review images is broken

2015-09-09 Thread reviewboard


Comment #3 on issue 3747 by nano...@gmail.com: Review images is broken
https://code.google.com/p/reviewboard/issues/detail?id=3747

@david,

Is there a chance this issue also affect document (a .docx)?

on our side we've got a 500 error when displaying review request containing  
an attachement (.docx) after migration from 2.0.15 to 2.0.19, see call  
stack:


   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/reviews/templatetags/reviewtags.py",  
line 91, in file_attachment_comments

file_attachment.get_comments()))

  File "/usr/lib/python2.7/json/__init__.py", line 231, in dumps
return _default_encoder.encode(obj)

  File "/usr/lib/python2.7/json/encoder.py", line 201, in encode
chunks = self.iterencode(o, _one_shot=True)

  File "/usr/lib/python2.7/json/encoder.py", line 264, in iterencode
return _iterencode(o, 0)

  File "/usr/lib/python2.7/json/encoder.py", line 178, in default
raise TypeError(repr(o) + " is not JSON serializable")

TypeError:  is not  
JSON serializable


if confirmed, I can open another issue.

Regards,

Nicolas

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3935 in reviewboard: Auto populate branch name when creating new Review Request

2015-09-09 Thread reviewboard


Comment #2 on issue 3935 by anthonyh...@gmail.com: Auto populate branch  
name when creating new Review Request

https://code.google.com/p/reviewboard/issues/detail?id=3935

Will be working on this as my first easy fix bug.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3747 in reviewboard: Review images is broken

2015-09-09 Thread reviewboard


Comment #4 on issue 3747 by nano...@gmail.com: Review images is broken
https://code.google.com/p/reviewboard/issues/detail?id=3747

I confirm it is the same issue, and David's fix works on any kind of file  
attachment. It has solved our issue with .docx


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3809 in reviewboard: Broken .kt style in rb/css/syntax.css

2015-09-09 Thread reviewboard


Comment #1 on issue 3809 by justin.h...@gmail.com: Broken .kt style in  
rb/css/syntax.css

https://code.google.com/p/reviewboard/issues/detail?id=3809

Was able to replicate the problem and looking into it now.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3962 in reviewboard: Mercurial repositories not usable on Windows Reviewboard install when hg is installed with 'pip'

2015-09-09 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3962 by phil...@gmail.com: Mercurial repositories not usable on  
Windows Reviewboard install when hg is installed with 'pip'

https://code.google.com/p/reviewboard/issues/detail?id=3962

What version are you running?
  2.0.19

What's the URL of the page containing the problem?
  /reviewboard/r/new/

What steps will reproduce the problem?
1. Install Reviewboard on a Windows server
2. Add a Mercurial repository to Reviewboard
3. Note that the Mercurial repository does not appear in the "New Review  
Request" screen.


What is the expected output? What do you see instead?
  I expect that it be possible to create review requests against the  
repository, but the repository does not appear in the request list.


Additionally, I get this error in my Apache log:

[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952]  
ERROR:root:Error loading SCMTool for repository "Test Repository" (ID 2)
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952] Traceback  
(most recent call last):
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952]
File "c:\\reviewboard\\env\\Lib\\site-packages\\reviewboard-2.0.19-py2.7.egg\\reviewboard\\reviews\\views.py",  
line 249, in new_review_request
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952]  
scmtool = repo.get_scmtool()
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952]
File "c:\\reviewboard\\env\\Lib\\site-packages\\reviewboard-2.0.19-py2.7.egg\\reviewboard\\scmtools\\models.py",  
line 231, in get_scmtool
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952]  
return cls(self)
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952]
File "c:\\reviewboard\\env\\Lib\\site-packages\\reviewboard-2.0.19-py2.7.egg\\reviewboard\\scmtools\\hg.py",  
line 28, in __init__
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952] raise  
ImportError
[Wed Sep 09 15:01:14.473213 2015] [wsgi:error] [pid 1752:tid 952]  
ImportError



What operating system are you using? What browser?
  Windows Server 2008 RC2 server, Windows 7 client, latest Google Chrome

Please provide any additional information below.

  On my server system, Mercurial was installed in the virtualenv which  
hosts Reviewboard. Line 25 of scmtools/hg.py attempts to check whether  
Mercurial is installed:


if not is_exe_in_path('hg'):
# This is technically not the right kind of error, but it's the
# pattern we use with all the other tools.
raise ImportError

And djblets.util.filesystem.py : is_exe_in_path(name) implements this thus:

if sys.platform == 'win32' and not name.endswith('.exe'):
name += ".exe"

for dir in os.environ['PATH'].split(os.pathsep):
if os.path.exists(os.path.join(dir, name)):
return True

return False

Clearly this will only work on Windows if the Mercurial executable is a  
true Windows executable and not a batch file or similar.


The problem is that in my virtualenv (where Mercurial was installed  
with "pip install mercurial"), the Mercurial binary *is* a batch file (in  
C:\ReviewBoard\Scripts\hg.bat).


This is not an issue if a Windows Mercurial distribution e.g. TortoiseHg is  
installed, as this includes a compiled executable to invoke Mercurial.



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3954 in reviewboard: Error 500 to some tickets

2015-09-09 Thread reviewboard


Comment #4 on issue 3954 by alder...@gmail.com: Error 500 to some tickets
https://code.google.com/p/reviewboard/issues/detail?id=3954

I,ve been hitting the same bug with CSV  files attachments (pure csv from  
php csv writter) as well as doc and docx.

it blocks the whole review when it happens, no one can look at it

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3954 in reviewboard: Error 500 to some tickets

2015-09-09 Thread reviewboard


Comment #5 on issue 3954 by alder...@gmail.com: Error 500 to some tickets
https://code.google.com/p/reviewboard/issues/detail?id=3954

(FYI 2.0.19 as well, and everything was working before)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing

2015-09-09 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3963 by paul.man...@alcatel-lucent.com: markdown in the field  
Note to Reviewers gets quoted with backslashes after editing

https://code.google.com/p/reviewboard/issues/detail?id=3963

What version are you running?

2.0.15


What's the URL of the page containing the problem?

http://reviewboard.example.com/r/2/

What steps will reproduce the problem?
1. edit the review, putting text into the "Note to reviewers" box, using  
markdown e.g.

#this is a highlighted comment

2. edit the review, changing the text in the note to reviewers box, perhaps  
adding something new


3.submit as normal

What is the expected output?

some highlighted text "this is a highlighted comment"

What do you see instead?

plain text reading "#this is a highlighted comment"

What operating system are you using?

Hosted on linux.


What browser?

Chrome on Linux (ubuntu desktop 15.04 x86-64)


Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing

2015-09-09 Thread reviewboard


Comment #2 on issue 3963 by chip...@gmail.com: markdown in the field Note  
to Reviewers gets quoted with backslashes after editing

https://code.google.com/p/reviewboard/issues/detail?id=3963

Also, did you publish between steps 1 and 2? If so, I'd be interested in  
seeing API data from both stages.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3962 in reviewboard: Mercurial repositories not usable on Windows Reviewboard install when hg is installed with 'pip'

2015-09-09 Thread reviewboard

Updates:
Status: NeedInfo
Labels: Project-Djblets OpSys-Windows

Comment #1 on issue 3962 by chip...@gmail.com: Mercurial repositories not  
usable on Windows Reviewboard install when hg is installed with 'pip'

https://code.google.com/p/reviewboard/issues/detail?id=3962

We're happy to accept patches to improve this sort of thing (please post to  
https://reviews.reviewboard.org/0, but we don't officially support Windows,  
so we aren't doing any active bug fixing there ourselves. If you can get a  
patch sent our way, we'll include it for the next release.


Seems like a good option would be to extend Djblets to support ".bat"  
extensions as well.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3964 in reviewboard: Text Overflow in Search Auto-Complete for Long Usernames / Long Review Titles

2015-09-09 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3964 by zach...@gmail.com: Text Overflow in Search Auto-Complete  
for Long Usernames / Long Review Titles

https://code.google.com/p/reviewboard/issues/detail?id=3964

What version are you running?
2.0.18

What's the URL of the page containing the problem?
Any page that search is visible on (eg: dashboard)

What steps will reproduce the problem?
1. have existing reviews that have titles > 30 characters which have been  
indexed for search

2. type in search box to match any of those review titles
3. view text overflow

What is the expected output? What do you see instead?
I would expect that the search box should truncate the text. Along with  
this, since search box is pretty small, it should probably be enlarged.
I have also noticed that this overflow occurs when users that are matched  
have long usernames.


What operating system are you using? What browser?
Windows 7 / Chrome

Please provide any additional information below.
I have attached a screenshot of the issue.

Attachments:
text-overflow-reviewboard-2_0_18.png  2.9 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing

2015-09-09 Thread reviewboard

Updates:
Status: NeedInfo
Labels: Project-ReviewBoard Component-Markdown

Comment #1 on issue 3963 by chip...@gmail.com: markdown in the field Note  
to Reviewers gets quoted with backslashes after editing

https://code.google.com/p/reviewboard/issues/detail?id=3963

Interesting. We got a similar comment from someone developing a custom  
extension just a week or two ago, but we could not reproduce it with the  
same extension or with Note to Reviewers. I'm unsure what the difference  
is...


Can you get the full payload of that review request from the API and send  
it here? (/api/review-requests//)


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3954 in reviewboard: Error 500 to some tickets

2015-09-09 Thread reviewboard


Comment #6 on issue 3954 by chip...@gmail.com: Error 500 to some tickets
https://code.google.com/p/reviewboard/issues/detail?id=3954

We'll have 2.0.20 out in just a couple days with this fix.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3961 in reviewboard: Cannot publish the reply to comments

2015-09-07 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3961 by adilcash...@gmail.com: Cannot publish the reply to  
comments

https://code.google.com/p/reviewboard/issues/detail?id=3961

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
1.7.22

What's the URL of the page containing the problem?
http://wlan-rb.sj.broadcom.com/r/69119/

What steps will reproduce the problem?
1. Reply for the comments in the review request
2. Tr to publish the comment

What is the expected output? What do you see instead?
I must be able to publish the comments, but instead, nothing happens for  
the first time I press the "Publish" button and if I press again, I am  
getting "A server error occurred." message.


What operating system are you using? What browser?
OS : Windows 7
Browser: I tried with Chrome, IE and firefox, in each browser, the behavior  
is same


Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3891 in reviewboard: Error adding new mercurial repository

2015-09-06 Thread reviewboard


Comment #10 on issue 3891 by justin.h...@gmail.com: Error adding new  
mercurial repository

https://code.google.com/p/reviewboard/issues/detail?id=3891

Was able to reproduce the error. Will look into fixing now for an  
easy-bug-fix.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3960 in reviewboard: Not able to publish the comments

2015-09-04 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3960 by adilcash...@gmail.com: Not able to publish the comments
https://code.google.com/p/reviewboard/issues/detail?id=3960

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3959 in reviewboard: Bogus "file was not found" error when moving files and changing their mode in a Git repository

2015-09-04 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3959 by vzeit...@gmail.com: Bogus "file was not found" error when  
moving files and changing their mode in a Git repository

https://code.google.com/p/reviewboard/issues/detail?id=3959

Using RBTools 0.7.4 under Cygwin from a git repository on a branch  
containing a single commit compared to origin/master results in the  
following:


% rbt post --debug

RBTools 0.7.4
Python 2.7.3 (default, Dec 18 2012, 13:50:09)

[GCC 4.5.3]

Running on CYGWIN_NT-6.1-WOW64-1.7.16-0.262-5-3-i686-32bit

...
Running: git -c core.quotepath=false -c diff.noprefix=false diff  
--no-color --full-index --ignore-submodules -M --no-ext-diff  
09fba2163dbe7787c3a152f933f218478531f354..fd634bf805d95da92214fa060b465865f88d6731
Making HTTP GET request to  
http://rbserver/review/api/review-requests/124/?only-links=diffs%2Cdraft=absolute_url%2Cbugs_closed%2Cid%2Cstatus
Making HTTP GET request to  
http://rbserver/review/api/review-requests/124/diffs/?only-fields=
Making HTTP POST request to  
http://rbserver/review/api/review-requests/124/diffs/
Got API Error 207 (HTTP code 400): The file was not found in the  
repository.
Error data: {u'stat': u'fail', u'file': u'SWIG/swig.exe', u'err':  
{u'msg': u'The file was not found in the repository.', u'code': 207},  
u'revision': u''}

Traceback (most recent call last):
  File "/usr/bin/rbt", line 9, in 
load_entry_point('RBTools==0.7.4', 'console_scripts', 'rbt')()
  File "/usr/lib/python2.7/site-packages/rbtools/commands/main.py", line  
133, in main

command.run_from_argv([RB_MAIN, command_name] + args)
  File "/usr/lib/python2.7/site-packages/rbtools/commands/__init__.py",  
line 612, in run_from_argv

exit_code = self.main(*args) or 0
  File "/usr/lib/python2.7/site-packages/rbtools/commands/post.py", line  
754, in main

(msg_prefix, e))
rbtools.commands.CommandError: Error validating diff

SWIG/swig.exe: The file was not found in the repository. (HTTP 400, API  
Error 207)


Doing "rbt diff" works just fine but running "rbt post --diff-filename"  
fails with the same error. The relevant part of the diff is:


diff --git a/SWIG/swig.exe b/3rdparty/swig/swig.exe
old mode 100644
new mode 100755
similarity index 100%
rename from SWIG/swig.exe
rename to 3rdparty/swig/swig.exe

As you can see, the file was renamed and its mode changed. Removing  
the "old mode" and "new mode" lines from the diff allows the review to go  
through, so apparently there is a problem with handling renames combined  
with mode changes.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3960 in reviewboard: Not able to publish the comments

2015-09-04 Thread reviewboard

Updates:
Status: Invalid

Comment #1 on issue 3960 by trowb...@gmail.com: Not able to publish the  
comments

https://code.google.com/p/reviewboard/issues/detail?id=3960

We need you to fill out the form in as much detail as possible or we can't  
do anything to help.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3958 in reviewboard: Unicode in user names

2015-09-04 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3958 by damien.d...@bt-ground.com: Unicode in user names
https://code.google.com/p/reviewboard/issues/detail?id=3958

What version are you running?
2.0.19

What's the URL of the page containing the problem?
There's no URL, its a mail problem happening with every reviews.


What steps will reproduce the problem?
1. Register a user with special chars in the name like Gaëtan (our one was  
coming from LDAP)

2. Create a new review, add reviewers and publish
3. Emails are not sent

What is the expected output? What do you see instead?
We should see email notifications coming in our mailboxes when any  
modification occurs on reviews.


What operating system are you using? What browser?
Reviewboard is hosted on Debian 8.0, 64 bits platform, with python 2.7 and  
Django 1.6.11.


Temporary solution:
Remove special chars in user full name.

Please provide any additional information below.
Here is the stack trace:

2015-09-03 17:00:30,387 - ERROR -  - Error sending e-mail notification with  
subject 'Re: Review Request 236: reporting: device status and errors.' on  
behalf of 'Damien <*@bt-ground.com>' to 'Eric  
<*@bt-ground.com>,Gaëtan <*@bt-ground.com>,Damien  
<*@bt-ground.com>,Olivier <*@bt-ground.com>,Franck  
<*@bt-ground.com>'

Traceback (most recent call last):
   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/notifications/email.py",  
line 632, in send_review_mail

message.send()
   
File "/usr/local/lib/python2.7/dist-packages/Django-1.6.11.1-py2.7.egg/django/core/mail/message.py",  
line 276, in send

return self.get_connection(fail_silently).send_messages([self])
   
File "/usr/local/lib/python2.7/dist-packages/Django-1.6.11.1-py2.7.egg/django/core/mail/backends/smtp.py",  
line 94, in send_messages

sent = self._send(message)
   
File "/usr/local/lib/python2.7/dist-packages/Django-1.6.11.1-py2.7.egg/django/core/mail/backends/smtp.py",  
line 110, in _send

self.connection.sendmail(from_email, recipients, message.as_bytes())
   
File "/usr/local/lib/python2.7/dist-packages/Django-1.6.11.1-py2.7.egg/django/core/mail/message.py",  
line 138, in as_string

return fp.getvalue()
  File "/usr/lib/python2.7/StringIO.py", line 271, in getvalue
self.buf += ''.join(self.buflist)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 378:  
ordinal not in range(128)
2015-09-03 17:01:36,224 - DEBUG -  - Calculated issue counts for review  
request ID 236 across 1 review(s): Resulting counts = {u'R': 0, u'D': 0,  
u'O': 0}; DB values = [{u'screenshot_comments__issue_status': None,  
u'file_attachment_comments__pk': None,  
u'screenshot_comments__issue_opened': None, u'comments__pk': None,  
u'comments__issue_opened': None, u'file_attachment_comments__issue_opened':  
None, u'screenshot_comments__pk': None, u'comments__issue_status': None,  
u'file_attachment_comments__issue_status': None}]; Field IDs =  
{u'screenshot_comments': set([]), u'comments': set([]),  
u'file_attachment_comments': set([])}
2015-09-03 17:01:36,357 - ERROR -  - Error sending e-mail notification with  
subject 'Re: Review Request 236: reporting: device status and errors.' on  
behalf of 'Gaëtan <*@bt-ground.com>' to 'Eric  
<*@bt-ground.com>,Gaëtan <gmo...@bt-ground.com>,Damien  
<*@bt-ground.com>,Olivier <*@bt-ground.com>,Franck  
<*@bt-ground.com>''

Traceback (most recent call last):
   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/notifications/email.py",  
line 632, in send_review_mail

message.send()
   
File "/usr/local/lib/python2.7/dist-packages/Django-1.6.11.1-py2.7.egg/django/core/mail/message.py",  
line 276, in send

return self.get_connection(fail_silently).send_messages([self])
   
File "/usr/local/lib/python2.7/dist-packages/Django-1.6.11.1-py2.7.egg/django/core/mail/backends/smtp.py",  
line 94, in send_messages

sent = self._send(message)
   
File "/usr/local/lib/python2.7/dist-packages/Django-1.6.11.1-py2.7.egg/django/core/mail/backends/smtp.py",  
line 110, in _send

self.connection.sendmail(from_email, recipients, message.as_bytes())
   
File "/usr/local/lib/python2.7/dist-packages/Django-1.6.11.1-py2.7.egg/django/core/mail/message.py",  
line 138, in as_string

return fp.getvalue()
  File "/usr/lib/python2.7/StringIO.py", line 271, in getvalue
self.buf += ''.join(self.buflist)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 385:  
ordinal not in range(128)



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/ho

Re: Issue 3956 in reviewboard: review requests with file attachments get 500 errors after upgrade to 2.0.19

2015-09-03 Thread reviewboard


Comment #2 on issue 3956 by chip...@gmail.com: review requests with file  
attachments get 500 errors after upgrade to 2.0.19

https://code.google.com/p/reviewboard/issues/detail?id=3956

We're planning to release 2.0.20 this weekend, which will fix this.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3956 in reviewboard: review requests with file attachments get 500 errors after upgrade to 2.0.19

2015-09-03 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 3954

Comment #3 on issue 3956 by chip...@gmail.com: review requests with file  
attachments get 500 errors after upgrade to 2.0.19

https://code.google.com/p/reviewboard/issues/detail?id=3956

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3954 in reviewboard: Error 500 to some tickets

2015-09-03 Thread reviewboard


Comment #3 on issue 3954 by chip...@gmail.com: Error 500 to some tickets
https://code.google.com/p/reviewboard/issues/detail?id=3954

Issue 3956 has been merged into this issue.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3957 in reviewboard: Issue updating reviews with RB tools 0.7.4, ReviewBoard 2.5 RC1 and Perforce

2015-09-03 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3957 by ramia...@gmail.com: Issue updating reviews with RB tools  
0.7.4, ReviewBoard 2.5 RC1 and Perforce

https://code.google.com/p/reviewboard/issues/detail?id=3957

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
2.5 rc1

What's the URL of the page containing the problem?
None

What steps will reproduce the problem?
1. Using latest rb tools 0.7.4 and a perforce scm
2. Post a review
3. Update the review

What is the expected output? What do you see instead?
Review posts successfully. Review fails with error commit id already in use.

What operating system are you using? What browser?
Windows 8

Please provide any additional information below.
Using RB Tools 0.6.3 issue does not occur.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3955 in reviewboard: circular dependency between reviews makes review request un-updatable (500 errors)

2015-09-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3955 by christop...@delphix.com: circular dependency between  
reviews makes review request un-updatable (500 errors)

https://code.google.com/p/reviewboard/issues/detail?id=3955

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?

2.0.19

What's the URL of the page containing the problem?

https://reviews.csiden.org/r/236/

What steps will reproduce the problem?
1. Create a new review request.
2. In the 'Depends On' field input the id of the review request itself  
(e.g. in the above link request 236 'depends on' request 236.

3. Publish the review (this works fine).
4. Try to update the description of the review after publishing, or upload  
a new diff and try to publish the new diff by pressing 'Publish Changes',  
neither works.


NOTE: The issue seems to occur with any circular dependency between review  
requests, e.g. if 237 'depends on' 238 and 238 'depends on' 237, the same  
issue occurs when publishing updates to both 237 and 238.


What is the expected output? What do you see instead?

I expect the review to be published, instead the page hangs until I  
navigate to a different page or reload, looking at the webservice requests  
via chrome developer tools I see that I got back a 500 internal error:


Request  
URL:https://reviews.csiden.org/api/review-requests/236/draft/?api_format=json=html=raw=depends_on%2Ctarget_people%2Ctarget_groups

Request Method:GET
Status Code:500 INTERNAL SERVER ERROR

But the web page does not indicate that an error occured. If I try to  
discard the draft I also get an error.


Also no log message is printed to the logs about the 500 error.

What operating system are you using? What browser?

Chrome on linux, linux server.

Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3956 in reviewboard: review requests with file attachments get 500 errors after upgrade to 2.0.19

2015-09-02 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3956 by christop...@delphix.com: review requests with file  
attachments get 500 errors after upgrade to 2.0.19

https://code.google.com/p/reviewboard/issues/detail?id=3956

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?

2.0.19 recently upgraded from 2.0.16

What's the URL of the page containing the problem?

http:///r/12359/

What steps will reproduce the problem?
1. Try to load the review request.

What is the expected output? What do you see instead?

Instead of loading the page displays a 500 error. The error log shows:

2015-09-03 02:03:51,984 - ERROR -  - Exception thrown for user chris at  
http:///r/12359/


 is not JSON serializable
Traceback (most recent call last):
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/core/handlers/base.py",  
line 112, in get_response

response = wrapped_callback(request, *callback_args, **callback_kwargs)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/accounts/decorators.py",  
line 23, in _check

return view_func(*args, **kwargs)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/site/decorators.py",  
line 35, in _check

return view_func(request, local_site=local_site, *args, **kwargs)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/reviews/views.py",  
line 721, in review_detail

RequestContext(request, context_data))
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/shortcuts/__init__.py",  
line 29, in render_to_response
return HttpResponse(loader.render_to_string(*args, **kwargs),  
**httpresponse_kwargs)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/loader.py",  
line 164, in render_to_string

return t.render(Context(dictionary))
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 140, in render

return self._render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 134, in _render

return self.nodelist.render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 840, in render

bit = self.render_node(node, context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 854, in render_node

return node.render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/loader_tags.py",  
line 123, in render

return compiled_parent._render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 134, in _render

return self.nodelist.render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 840, in render

bit = self.render_node(node, context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 854, in render_node

return node.render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/loader_tags.py",  
line 123, in render

return compiled_parent._render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 134, in _render

return self.nodelist.render(context)
   
File "/home/delphix/reviewboard/rb-1.7.22/lib/python2.7/site-packages/Django-1.6.11-py2.7.egg/django/template/base.py",  
line 840, in render

bit = self.render_node(node, context)
   
File "/home/delphix/reviewbo

Re: Issue 3956 in reviewboard: review requests with file attachments get 500 errors after upgrade to 2.0.19

2015-09-02 Thread reviewboard


Comment #1 on issue 3956 by christop...@delphix.com: review requests with  
file attachments get 500 errors after upgrade to 2.0.19

https://code.google.com/p/reviewboard/issues/detail?id=3956

I forgot to mention that I am unable to reproduce the issue after the  
upgrade (i.e. creating a new review request after the upgrade with a file  
attachment does not have the same problem).


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3915 in reviewboard: Add support for SCM Manager as a HostingService

2015-09-01 Thread reviewboard


Comment #16 on issue 3915 by aklitz...@gmail.com: Add support for SCM  
Manager as a HostingService

https://code.google.com/p/reviewboard/issues/detail?id=3915

You can see that in "rbtools/hooks/mercurial.py" with "class  
MercurialDiffer" at that review request [1] from above.


It calls MercurialClient with "NODEID^1" as it is allowed on local hg  
clients like with local git clients.


hg log -r tip^1
hg log -r tip^2
hg log -r tip^3

git log -r HEAD~1
git log -r HEAD~2
git log -r HEAD~3

[1] https://reviews.reviewboard.org/r/7100/


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3954 in reviewboard: Error 500 to some tickets

2015-08-30 Thread reviewboard

Updates:
Status: NeedInfo

Comment #2 on issue 3954 by chip...@gmail.com: Error 500 to some tickets
https://code.google.com/p/reviewboard/issues/detail?id=3954

What kind of files are attached to that review request?

We have a fix coming out in 2.0.20 (probably this week), but were under the  
assumption from our understanding of the bug that you wouldn't actually  
manage to hit this in practice. Knowing the type of uploaded files will  
help us here.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3954 in reviewboard: Error 500 to some tickets

2015-08-27 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3954 by atrubits...@eisgroup.com: Error 500 to some tickets
https://code.google.com/p/reviewboard/issues/detail?id=3954

Here is the output from admin email
Traceback (most recent call last):

  File /usr/lib/python2.7/site-packages/django/core/handlers/base.py,  
line 112, in get_response

response = wrapped_callback(request, *callback_args, **callback_kwargs)

   
File /usr/lib/python2.7/site-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/accounts/decorators.py,  
line 21, in _check

return login_required(view_func)(*args, **kwargs)

   
File /usr/lib/python2.7/site-packages/django/contrib/auth/decorators.py,  
line 22, in _wrapped_view

return view_func(request, *args, **kwargs)

   
File /usr/lib/python2.7/site-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/site/decorators.py,  
line 35, in _check

return view_func(request, local_site=local_site, *args, **kwargs)

   
File /usr/lib/python2.7/site-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard/reviews/views.py,  
line 721, in review_detail

RequestContext(request, context_data))

  File /usr/lib/python2.7/site-packages/django/shortcuts/__init__.py,  
line 29, in render_to_response
return HttpResponse(loader.render_to_string(*args, **kwargs),  
**httpresponse_kwargs)


  File /usr/lib/python2.7/site-packages/django/template/loader.py, line  
164, in render_to_string

return t.render(Context(dictionary))

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
140, in render

return self._render(context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
134, in _render

return self.nodelist.render(context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
840, in render

bit = self.render_node(node, context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
854, in render_node

return node.render(context)

  File /usr/lib/python2.7/site-packages/django/template/loader_tags.py,  
line 123, in render

return compiled_parent._render(context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
134, in _render

return self.nodelist.render(context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
840, in render

bit = self.render_node(node, context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
854, in render_node

return node.render(context)

  File /usr/lib/python2.7/site-packages/django/template/loader_tags.py,  
line 123, in render

return compiled_parent._render(context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
134, in _render

return self.nodelist.render(context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
840, in render

bit = self.render_node(node, context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
854, in render_node

return node.render(context)

  File /usr/lib/python2.7/site-packages/django/template/loader_tags.py,  
line 62, in render

result = block.nodelist.render(context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
840, in render

bit = self.render_node(node, context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
854, in render_node

return node.render(context)

  File /usr/lib/python2.7/site-packages/django/template/loader_tags.py,  
line 155, in render

return self.render_template(self.template, context)

  File /usr/lib/python2.7/site-packages/django/template/loader_tags.py,  
line 137, in render_template

output = template.render(context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
140, in render

return self._render(context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
134, in _render

return self.nodelist.render(context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
840, in render

bit = self.render_node(node, context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
854, in render_node

return node.render(context)

  File /usr/lib/python2.7/site-packages/django/template/defaulttags.py,  
line 305, in render

return nodelist.render(context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
840, in render

bit = self.render_node(node, context)

  File /usr/lib/python2.7/site-packages/django/template/base.py, line  
854, in render_node

return node.render(context)

  File /usr/lib/python2.7/site-packages/django/template/defaulttags.py,  
line 203, in render

nodelist.append(node.render(context))

  File /usr/lib/python2.7/site-packages/djblets/util/decorators.py, line  
122, in render

return self.tag_func(context, *args)

   
File /usr/lib/python2.7/site-packages/ReviewBoard-2.0.19-py2.7.egg/reviewboard

Re: Issue 3954 in reviewboard: Error 500 to some tickets

2015-08-27 Thread reviewboard


Comment #1 on issue 3954 by atrubits...@eisgroup.com: Error 500 to some  
tickets

https://code.google.com/p/reviewboard/issues/detail?id=3954

Please let me know what is the error reason and what is the way to fix it

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3953 in reviewboard: no Email on ship it action

2015-08-27 Thread reviewboard


Comment #2 on issue 3953 by bar...@beanbaginc.com: no Email on ship it  
action

https://code.google.com/p/reviewboard/issues/detail?id=3953

Can you try this on the latest release-2.0.x? I believe this was fixed in  
commit a22600574e26571f0ee31eba46322e73995531cd.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3953 in reviewboard: no Email on ship it action

2015-08-27 Thread reviewboard


Comment #1 on issue 3953 by shul...@gmail.com: no Email on ship it action
https://code.google.com/p/reviewboard/issues/detail?id=3953

Same problem here. Not just for ship it emails, but any emails that  
contain Chinese characters.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3915 in reviewboard: Add support for SCM Manager as a HostingService

2015-08-26 Thread reviewboard


Comment #13 on issue 3915 by aklitz...@gmail.com: Add support for SCM  
Manager as a HostingService

https://code.google.com/p/reviewboard/issues/detail?id=3915

update diffviewer_diffset set base_commit_id=NULL where base_commit_id  
like '%^1%';


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3915 in reviewboard: Add support for SCM Manager as a HostingService

2015-08-26 Thread reviewboard


Comment #15 on issue 3915 by bar...@beanbaginc.com: Add support for SCM  
Manager as a HostingService

https://code.google.com/p/reviewboard/issues/detail?id=3915

How exactly are you generating the diff with MercurialClient? You may be  
generating it in an incorrect way. If you generate the diff through rbt,  
does it work as intended?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3915 in reviewboard: Add support for SCM Manager as a HostingService

2015-08-26 Thread reviewboard


Comment #12 on issue 3915 by aklitz...@gmail.com: Add support for SCM  
Manager as a HostingService

https://code.google.com/p/reviewboard/issues/detail?id=3915

This introduces it:  
https://github.com/reviewboard/reviewboard/commit/6b34af11397d92ae5c396ed911840ae6b0392cfd


If in table diffviewer_diffset in column base_commit_id is already a  
NODEID^1 it is, of course, still broken for old reviews.



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3915 in reviewboard: Add support for SCM Manager as a HostingService

2015-08-26 Thread reviewboard


Comment #14 on issue 3915 by aklitz...@gmail.com: Add support for SCM  
Manager as a HostingService

https://code.google.com/p/reviewboard/issues/detail?id=3915

update diffviewer_diffset set base_commit_id=NULL where base_commit_id  
like '%^1';


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3915 in reviewboard: Add support for SCM Manager as a HostingService

2015-08-25 Thread reviewboard


Comment #11 on issue 3915 by aklitz...@gmail.com: Add support for SCM  
Manager as a HostingService

https://code.google.com/p/reviewboard/issues/detail?id=3915

Work-around:

diff --git a/rbtools/clients/mercurial.py b/rbtools/clients/mercurial.py
index ad0d1f9..2f6edc9 100644
--- a/rbtools/clients/mercurial.py
+++ b/rbtools/clients/mercurial.py
@@ -412,6 +412,9 @@ class MercurialClient(SCMClient):
 base_commit_id = revisions['base']
 parent_diff = None

+base_commit_id = self._execute(
+ ['hg', 'log', '-r', base_commit_id, '-T {node}'],  
env=self._hg_env, results_unicode=False)

+
 return {
 'diff': diff,
 'parent_diff': parent_diff,



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3915 in reviewboard: Add support for SCM Manager as a HostingService

2015-08-25 Thread reviewboard


Comment #10 on issue 3915 by aklitz...@gmail.com: Add support for SCM  
Manager as a HostingService

https://code.google.com/p/reviewboard/issues/detail?id=3915

Ok, I found the problem.

I'm using a script on server side [1] to create the diff, parent diff and  
the base commit id using MercurialClient class from rbtools 0.7.4 (tried  
5985bfc7145fc240c9e23a99d80f1e149bec355b, too).


So the reference is a NODEID^1 that will produce correct diff and parent  
diff (without ^1) but MercurialClient returns the NODEID^1 as  
base_commit_id.



[1] https://reviews.reviewboard.org/r/7100/


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3953 in reviewboard: no Email on ship it action

2015-08-25 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3953 by guillaum...@gmail.com: no Email on ship it action
https://code.google.com/p/reviewboard/issues/detail?id=3953

What version are you running?
Review Board 2.0.19

What's the URL of the page containing the problem?
http://172.16.13.193/reviewboard-lab/r/41/

What steps will reproduce the problem?
1. Create an new review request

2. Ship It

Upon ship it, an email was sent in old version but not with this new  
version.

It's works when using create or submit action

in Server Log (I have mask email address by )

18:08:20ERROR

 - Error sending e-mail notification with subject 'Re: Review Request 42:  
Task - 105402: test21 - rer' on behalf of 'at at*@***.**'  
to 'at at@***.**,gp gp*@***.**'

Traceback (most recent call last):
   
File /usr/lib/python2.6/site-packages/ReviewBoard-2.0.19-py2.6.egg/reviewboard/notifications/email.py,  
line 632, in send_review_mail

message.send()
   
File /usr/lib/python2.6/site-packages/Django-1.6.11-py2.6.egg/django/core/mail/message.py,  
line 276, in send

return self.get_connection(fail_silently).send_messages([self])
   
File /usr/lib/python2.6/site-packages/Django-1.6.11-py2.6.egg/django/core/mail/backends/smtp.py,  
line 94, in send_messages

sent = self._send(message)
   
File /usr/lib/python2.6/site-packages/Django-1.6.11-py2.6.egg/django/core/mail/backends/smtp.py,  
line 110, in _send

self.connection.sendmail(from_email, recipients, message.as_bytes())
   
File /usr/lib/python2.6/site-packages/Django-1.6.11-py2.6.egg/django/core/mail/message.py,  
line 138, in as_string

return fp.getvalue()
  File /usr/lib64/python2.6/StringIO.py, line 270, in getvalue
self.buf += ''.join(self.buflist)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 400:  
ordinal not in range(128)



What operating system are you using? What browser?
centos 2.6.32-504.23.4.el6.x86_64
Chrome Version 44.0.2403.157 m

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3952 in reviewboard: The file was not found in the repository. (HTTP 400, API Error 207)

2015-08-25 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3952 by adilicio...@gmail.com: The file was not found in the  
repository. (HTTP 400, API Error 207)

https://code.google.com/p/reviewboard/issues/detail?id=3952

What version are you running?
RBTools 0.7.2

What's the URL of the page containing the problem?
n/a

What steps will reproduce the problem?
1. Create changes in existing file
2. Commit file to git.
3. Execute rbt post

What is the expected output? What do you see instead?
Expected output is a new review board review is created and a diff is  
uploaded of the existing file and the new modified file.


Bellow is the debug log of what I see:

$ rbt post -d

RBTools 0.7.2
Python 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit  
(Intel)]

Running on Windows-7-6.1.7601-SP1
Home = C:\Users\Irnes\AppData\Roaming
Current directory = c:\Users\Irnes\git\array_self_cert\common\tests
Checking for a Subversion repository...
Unable to execute svn help: skipping SVN
Checking for a Git repository...
Running: git rev-parse --git-dir
Running: git config core.bare
Running: git rev-parse --show-toplevel
Running: git symbolic-ref -q HEAD
Running: git config --get branch.Array_SelfCert_Revamp.merge
Running: git config --get branch.Array_SelfCert_Revamp.remote
Running: git config --get remote.origin.url
repository info: Path:  
g...@gitlab.spgear.lab.emc.com:self-cert/array_self_cert.git, Base  
path: , Supports changesets: False

Making HTTP GET request to http://reviewboard.spgear.lab.emc.com/api/
Running: git rev-parse refs/heads/Array_SelfCert_Revamp
Running: git merge-base 481a6e7642acab3c788e7ec9f03fc2a2cd32a4a7  
origin/Array_SelfCert_Revamp

Running: git rev-parse 0ded2cbfa9668523df02e61ab1bb887233c825cb
Running: git status --porcelain --untracked-files=no
Running: git rev-parse --git-dir
Running: git -c core.quotepath=false -c diff.noprefix=false diff  
--no-color --full-index --ignore-submodules -M --no-ext-diff  
0ded2cbfa9668523df02e61ab1bb887233c825cb..481a6e7642acab3c788e7ec9f03fc2a2cd32a4a7
Running: git log --reverse --pretty=format:%s%n%n%b  
^0ded2cbfa9668523df02e61ab1bb887233c825cb  
481a6e7642acab3c788e7ec9f03fc2a2cd32a4a7
Making HTTP GET request to  
http://reviewboard.spgear.lab.emc.com/reviews/api/review-requests/?only-links=createonly-fields=
Making HTTP POST request to  
http://reviewboard.spgear.lab.emc.com/reviews/api/review-requests/
Making HTTP GET request to  
http://reviewboard.spgear.lab.emc.com/reviews/api/review-requests/11033/diffs/?only-fields=
Making HTTP POST request to  
http://reviewboard.spgear.lab.emc.com/reviews/api/review-requests/11033/diffs/
Got API Error 207 (HTTP code 400): The file was not found in the  
repository.
Error data: {u'stat': u'fail', u'file': u'common/packaging/install.py',  
u'err': {u'msg': u'The file was not found in the repository.', u'code':  
207}, u'revision': u'b781ddade8f04cf58c083586fe0a8358876ab4e2'}

Traceback (most recent call last):
  File c:/Program Files/RBTools/bin/../Python27/Scripts/rbt-script.py,  
line 8, in module

load_entry_point('RBTools==0.7.2', 'console_scripts', 'rbt')()
  File c:\Program  
Files\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.egg\rbtools\commands\main.py,  
line 133, in main

command.run_from_argv([RB_MAIN, command_name] + args)
  File c:\Program  
Files\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.egg\rbtools\commands\__init__.py,  
line 555, in run_from_argv

exit_code = self.main(*args) or 0
  File c:\Program  
Files\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.egg\rbtools\commands\post.py,  
line 745, in main

base_dir=base_dir)
  File c:\Program  
Files\RBTools\Python27\lib\site-packages\rbtools-0.7.2-py2.7.egg\rbtools\commands\post.py,  
line 458, in post_request

raise CommandError(u'\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff

The file was not found in the repository. (HTTP 400, API Error 207)

Your review request still exists, but the diff is not attached.

http://reviewboard.spgear.lab.emc.com/reviews/r/11033/



What operating system are you using? What browser?
Operating system: Windows 7
Browser: Chrome

Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3951 in reviewboard: [Active Directory LDAP ] Misleading info for Anonymous User Mask

2015-08-24 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Component-Docs

New issue 3951 by coronari...@gmail.com: [Active Directory LDAP ]  
Misleading info for Anonymous User Mask

https://code.google.com/p/reviewboard/issues/detail?id=3951

What's the URL of the page containing the problem?

I'm using 1.7.21:

https://www.reviewboard.org/docs/manual/1.7/admin/configuration/authentication-settings/

But it's the same in the last version:

https://www.reviewboard.org/docs/manual/2.5/admin/configuration/authentication-settings/


Describe the problem and any recommendations below.

The Anonymous User Mask says (both in inline help on the Authentication  
configuration on RB and on the docs):


The user mask string for anonymous users. This should be in the same  
format as User Mask.


However in my case I had to use the following format to make it work:

Anonymous User Mask: myusername@windows.domain
Anonymous User Password : myusernamePassword

I found the solution in this thread:

https://groups.google.com/forum/#!searchin/reviewboard/ldap$20active$20directory$20user$20mask/reviewboard/XpRvjYp7SJ4/hs-pJ0v_S4AJ

(look at the reply from Jan Koprowsky)

When I was following the hint of the documentation I was using this mask  
for the anon user mask:


sAMAccountName=myusername,cn=common.name,ou=subgroup,ou=something,ou=USERS,dc=mydomain,dc=com

...and I was getting the following error:

LDAP error: The specified object does not exist in the Directory:  
sAMAccountName=myusername


(The same error was popping up when leaving the field empty)



Please provide any additional information below.


My RB is 17.21 and installed on a Ubuntu server 12.04 LTS

I set the other fields for LDAP Active Directory like this:

LDAP Server: ldap://mydomain.com:389
LDAP Base DN: ou=something,ou=USERS,dc=mydomain,dc=com
Given Name Attribute: givenName
Surname Attribute: sn
E-Mail LDAP Attribute: mail
User Mask: sAMAccountName=%s

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3949 in reviewboard: Diffs: Distinguish between light yellow nothing changed/whitespace changes and light yellow completely different lines

2015-08-20 Thread reviewboard


Comment #4 on issue 3949 by alextfish: Diffs: Distinguish between light  
yellow nothing changed/whitespace changes and light yellow completely  
different lines

https://code.google.com/p/reviewboard/issues/detail?id=3949

Another example of the current confusing behaviour to demonstrate my point  
further. If I'm trying to follow the code flow on the right, reading the  
new code, I can see that although some of the lines are in light yellow,  
the only changes are adding the string 'NotSupported' to the contents of a  
string and a variable name. I therefore know that the basic functional flow  
of the code is unchanged.


However, then I get to lines 245-246, which are also in light yellow, but  
this does *NOT* indicate the basic functional flow is unchanged; in fact it  
indicates the code is *completely different*.


Once again, it's not clear for any given line whether light yellow  
means unchanged text or very changed text.



Attachments:
rb_yellows_2.png  50.8 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Comment on IdeasFor2_0 in reviewboard

2015-08-20 Thread reviewboard

Comment by rayt...@gmail.com:

*[http://bundaku.net Jual Jilbab Instan Online]*

For more information:
https://code.google.com/p/reviewboard/wiki/IdeasFor2_0

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3950 in reviewboard: Display filename of diffed file

2015-08-20 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 3950 by dhaum...@gmail.com: Display filename of diffed file
https://code.google.com/p/reviewboard/issues/detail?id=3950

Version: 2.0.18.

Description:
When reviewing large changes, one sometimes looses the context and does not  
remember the current file anymore, which can be confusing.


Possible solution:
Display a small overlay tooltip at the top that shows the current file if  
no file header is visible in the diff viewer, see attached screenshot.  
(Additionally, one could add some quick link buttons like goto  
next/previous chunk (currently 'n' and 'p' shortcuts) or similar, if it  
makes sense.)


Attachments:
overlay.png  58.7 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3949 in reviewboard: Diffs: Distinguish between light yellow nothing changed/whitespace changes and light yellow completely different lines

2015-08-19 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 3949 by alextfish: Diffs: Distinguish between light  
yellow nothing changed/whitespace changes and light yellow completely  
different lines

https://code.google.com/p/reviewboard/issues/detail?id=3949

  What version are you running?
2.0.18.1

  Describe the enhancement and the motivation for it.
The colour coding of lines in diffs is very helpful. Green is clearly lines  
that are added; red is clearly lines that are removed; white is clearly  
unchanged (or only indentation changes). Yellow, however, is an ambiguous  
colour with several possible meanings:


* If a line has merely had some trailing whitespace removed, or some  
internal whitespace removed, the line is highlighted in light yellow on  
both sides with no dark yellow. We generally don't actually care about  
these changes.
* If a line has had a tiny change, the whole line is highlighted in light  
yellow and the tiny changed bit is highlighted in dark yellow on both sides.
* If a line has been partly changed, the whole line is highlighted in light  
yellow and the medium-sized changed bit is highlighted in dark yellow on  
both sides.
* If a line has had some text added, the whole line is highlighted in light  
yellow and the new content is highlighted in dark yellow on the  
right-hand-side only.
* If a line has been wholesale replaced with a completely different line,  
the line is highlighted in LIGHT yellow and NOTHING is highlighted in dark  
yellow.


Reading down just the right-hand-side (new code), therefore, it's ambiguous  
what some code in light yellow means. Is this 1) a line that preexisted as  
and has just had some neglegibly small change made to it? 2) A line that's  
had some amount of text removed? Or 3) a line that's completely unrelated  
to whatever was there in the previous version?
Manually eyeballing the lines on the left and right looking for any dark  
yellow blocks helps distinguish case 2) from the others, but cases 1) and  
3) can only be resolved by looking at the text on the left and comparing it.


Fundamentally, it's not clear for any given line whether light yellow  
means unchanged text or very changed text.


See the example attachment rb_yellows.png. Looking at the new code, there  
are three lines on the right all of which are highlighted light yellow but  
with no dark yellow highlights. On line 5, this is a line where some code  
is deleted, and all the text there pre-existed. On line 13, this is a  
completely different line to what was there before. On line 11, ReviewBoard  
has decided this is a completely different line, though perhaps it should  
notice that half of the line pre-existed and the second half should be  
highlighted in dark yellow.


This is the frustration and the motivation for my proposed change. My  
actual proposal would be: In the case where a yellow line is completely  
different, don't leave it only highlighted in light yellow; highlight all  
non-whitespace characters on both sides in dark yellow. My example mockup  
of what this might look like is attached in rb_yellows_mine.png.



  What operating system are you using? What browser?
Chrome / Windows.


Attachments:
rb_yellows.png  19.4 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3949 in reviewboard: Diffs: Distinguish between light yellow nothing changed/whitespace changes and light yellow completely different lines

2015-08-19 Thread reviewboard


Comment #1 on issue 3949 by alextfish: Diffs: Distinguish between light  
yellow nothing changed/whitespace changes and light yellow completely  
different lines

https://code.google.com/p/reviewboard/issues/detail?id=3949

Second attachment (my mocked-up example of how this might look) is attached  
here.


Attachments:
rb_yellows_mine.png  20.8 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3949 in reviewboard: Diffs: Distinguish between light yellow nothing changed/whitespace changes and light yellow completely different lines

2015-08-19 Thread reviewboard


Comment #2 on issue 3949 by alextfish: Diffs: Distinguish between light  
yellow nothing changed/whitespace changes and light yellow completely  
different lines

https://code.google.com/p/reviewboard/issues/detail?id=3949

Second screenshot (my mocked-up example of what this might look like) is  
attached here.


Attachments:
rb_yellows_mine.png  20.6 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3949 in reviewboard: Diffs: Distinguish between light yellow nothing changed/whitespace changes and light yellow completely different lines

2015-08-19 Thread reviewboard


Comment #3 on issue 3949 by alextfish: Diffs: Distinguish between light  
yellow nothing changed/whitespace changes and light yellow completely  
different lines

https://code.google.com/p/reviewboard/issues/detail?id=3949

Second screenshot (my mocked-up example of what this might look like) is  
attached here.


Attachments:
rb_yellows_mine.png  20.1 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


  1   2   3   4   5   6   7   8   9   10   >