Issue 1121 in reviewboard: repository encoding setting work incorrect
Updates: Status: New Comment #3 on issue 1121 by trowbrds: repository encoding setting work incorrect http://code.google.com/p/reviewboard/issues/detail?id=1121 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1121 in reviewboard: repository encoding setting work incorrect
Comment #2 on issue 1121 by kohura12345678: repository encoding setting work incorrect http://code.google.com/p/reviewboard/issues/detail?id=1121 My repository is 'Shift_JIS' encoding. And show utf-8 in my browser. I felt like this. If argument 's' is unicode and utf-8, this function returns a unicode. However, if 's' is other encoding , this function returns utf-8 string. Function name 'convert_to_utf8' is not exact. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1121 in reviewboard: repository encoding setting work incorrect
Updates: Status: NeedInfo Comment #1 on issue 1121 by chipx86: repository encoding setting work incorrect http://code.google.com/p/reviewboard/issues/detail?id=1121 This is going to break a lot of setups out there. We do need to render it to utf-8. What's the encoding code that you're using? And what encoding mode does it show in your browser on that page? Make sure it's utf-8. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1121 in reviewboard: repository encoding setting work incorrect
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1121 by kohura12345678: repository encoding setting work incorrect http://code.google.com/p/reviewboard/issues/detail?id=1121 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0rc2 What's the URL of the page containing the problem? all View Diff pages like that. /r/6/diff/#index_header What steps will reproduce the problem? 1.View Diff 2. 3. What is the expected output? What do you see instead? If I set repository encoding setting correctly, but I saw broken character. Review source code is Japanese Encoding. What operating system are you using? What browser? CentOS 5.2 Firefox 3 Please provide any additional information below. attach patch Attachments: reviewboard-r1977-invalidencoding.patch 606 bytes -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
