Re: Issue 1939 in reviewboard: .sj Files are being displayed as binary files (despite being text format files) in review board
Updates: Status: SetupIssue Comment #5 on issue 1939 by trowb...@gmail.com: .sj Files are being displayed as binary files (despite being text format files) in review board http://code.google.com/p/reviewboard/issues/detail?id=1939 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1939 in reviewboard: .sj Files are being displayed as binary files (despite being text format files) in review board
Comment #2 on issue 1939 by rahulrst...@gmail.com: .sj Files are being displayed as binary files (despite being text format files) in review board http://code.google.com/p/reviewboard/issues/detail?id=1939 Yes. The repository looks fine to me. We use perforce as the repository... -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1939 in reviewboard: .sj Files are being displayed as binary files (despite being text format files) in review board
Comment #3 on issue 1939 by chip...@gmail.com: .sj Files are being displayed as binary files (despite being text format files) in review board http://code.google.com/p/reviewboard/issues/detail?id=1939 Review Board itself doesn't make the determination as to whether it's a text file or binary file, so it's definitely coming from your repository or your diff tool. You can verify this with 'post-review --output-diff changenum -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1939 in reviewboard: .sj Files are being displayed as binary files (despite being text format files) in review board
Comment #4 on issue 1939 by rahulrst...@gmail.com: .sj Files are being displayed as binary files (despite being text format files) in review board http://code.google.com/p/reviewboard/issues/detail?id=1939 I just verfied it.. Looks like there is a problem in the diff tool. The tool which we are using to generate the diff is P5. diff file doesn't contain the text for .sj files Thanks for the clarification.. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1939 in reviewboard: .sj Files are being displayed as binary files (despite being text format files) in review board
Updates: Status: NeedInfo Comment #1 on issue 1939 by trowb...@gmail.com: .sj Files are being displayed as binary files (despite being text format files) in review board http://code.google.com/p/reviewboard/issues/detail?id=1939 Typically this is because your SCM is reporting these files as being binary. Are you sure things are set up right in the repository? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1939 in reviewboard: .sj Files are being displayed as binary files (despite being text format files) in review board
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1939 by rahulrstogi: .sj Files are being displayed as binary files (despite being text format files) in review board http://code.google.com/p/reviewboard/issues/detail?id=1939 *NOTE: Do not post confidential information in this bug report.* What version are you running - 1.0.9 What's the URL of the page containing the problem - N/A What steps will reproduce the problem? 1. Submit any diff file which contains .sj files in the code 2. Go to View Diff 3. Review board shows that .sj files are binary files and code doesn't get displayed for these files What is the expected output - N/A What do you see instead - N/A What operating system are you using - All OS What browser - All Browsers Thanks Regards Rahul -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
