Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content
Updates: Labels: EasyFix Comment #12 on issue 3659 by trowb...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content
Comment #10 on issue 3659 by shahgunj...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 Any update on this ? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content
Updates: Status: Confirmed Labels: -Priority-Medium Priority-Low Component-RBTools Project-RBTools Comment #11 on issue 3659 by trowb...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 This is something that we'll fix eventually, but it's pretty low priority. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content
Comment #9 on issue 3659 by shahgunj...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 Yes Perforce. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content
Comment #8 on issue 3659 by trowb...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 OK, I think I understand. What version control system? Perforce? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content
Comment #7 on issue 3659 by marc.fo...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 When I do a review (using post-review) that contains only a single binary file the review is created and when looking at review board it says that one file has changed. When you go to view the diff for that file it states This is a binary file. The content cannot be displayed. The main point is that when a review is created that includes a binary file it at least shows up as a file that has changed. Using the newest version when you try and post a review that only contains binary file it errors out with ERROR: There don't seem to be any diffs!. Does this make sense? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content
Updates: Status: NeedInfo Comment #2 on issue 3659 by trowb...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content
Comment #3 on issue 3659 by marc.fo...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 Yes a jks file is binary. using an older version of rbt that supports post-review the review is still posted even when the only change is a binary file. It seems with the new version the review is not posted because it can't determine any diffs -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content
Comment #4 on issue 3659 by trowb...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 I don't see how this is a bug. You want a review request with no diffs? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content
Comment #5 on issue 3659 by shahgunj...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 We want review request with diffs, using RBTools 0.6.2. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content
Comment #6 on issue 3659 by trowb...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 I *really* don't understand what you mean. We've never done diffs of binary files. What behavior are you seeing with the older version (by which I mean what shows up in the View diff page?) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3659 in reviewboard: RBTools 0.6.2 not able to differentiate the binary content
Comment #1 on issue 3659 by trowb...@gmail.com: RBTools 0.6.2 not able to differentiate the binary content https://code.google.com/p/reviewboard/issues/detail?id=3659 I'm confused. Is .jks a text file that's being misinterpreted as binary? We've never been able to post changes to binary files. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
