Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #22 on issue 839 by elvst...@gmail.com: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 Comment #18 by Faller.G seems promising. Could this be a place to make a proper option for this? I'm working on an old code base now, where people have been sloppy about spaces/tabs in the past, and would love to be able to set the displayed tab width. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #21 on issue 839 by trowb...@gmail.com: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 Issue 3012 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #20 on issue 839 by satyava...@gmail.com: Option to convert tabs in
the diff to (n) spaces
http://code.google.com/p/reviewboard/issues/detail?id=839
To answer comment
https://code.google.com/p/reviewboard/issues/detail?id=839#c3 in the above,
I have been personally running
$('span.tb').html(' ') in the console of the browser to convert tabs into
spaces, until the actual feature comes in the reviewboard.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #18 on issue 839 by faller.g...@gmail.com: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 I made a change (ReviewBoard-1.0.5.1) in reviewboard\diffviewer\diffutils.py file and everything works: Line 358-359, you will find: old = convert_to_utf8(old, encoding) new = convert_to_utf8(new, encoding) change them to old = convert_to_utf8(old, encoding).expandtabs(4) new = convert_to_utf8(new, encoding).expandtabs(4) So write to the end of the lines: .expandtabs (4). That's all. Empty all cache (python, server and client), they can foul you. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #17 on issue 839 by adrianbo...@gmail.com: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 I wrote a userscript for google chrome and firefox w/greasemonkey that turns tabs into 4 spaces or anything you want. It integrates with reviewboard (it adds a button next to Hide Whitespace changes). Feel free to use or modify it. Attachments: replace_tabs.user.js 2.2 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Updates: Labels: -Priority-Low -Milestone-Release1.7 Priority-High Milestone-Release1.6 Comment #15 on issue 839 by chip...@gmail.com: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 I think we can do something for 1.6. I'll bump up the priority too. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #13 on issue 839 by d...@thompsonhome.org: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 Given that the purpose of this entire system is to facilitate code reviews I question why this feature/bug is low priority. Doing diffs of code where a combination of spaces and tabs is already present in millions of lines of code at four makes it much harder to read the diffs. I love the most recent diff version compared to older one we were using but looking at incorrectly indented code is quite tedious. Please raise this and possibly split into two features. Simple server side tab setting and then the various other options. Would love to see this in the next version and thanks. I will make a donation today just in case it helps make that a reality. We will try and move to tabs as much as possible specifically to make this great tool work for us. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #14 on issue 839 by paul.dubois: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 @13, No judgement on your priority argument but modifying the .css is a usable workaround to get server-side tab settings. I can confirm it works with firefox 4. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #10 on issue 839 by paul.dubois: Option to convert tabs in the diff
to (n) spaces
http://code.google.com/p/reviewboard/issues/detail?id=839
Same issue as max9219. We modified PerforceClient in postreview.py to do
tab-expansion before diffing, and got patch failures after/upon upload.
chipx86, when you suggest do[ing] it in postreview was there a
corresponding server-side change you had in mind to get around the patch
failure?
I can confirm that adding
pre {
-moz-tab-size: 4;
-o-tab-size: 4;
}
to diffviewer.css gives reasonable results in opera; moz4 is untested.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #8 on issue 839 by paul.dubois: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 This is biting us too. I think for now we'll work around by hacking postreview. FWIW, moz 4.0 has css for modifying tab width (and IIUC it looks like recent versions of opera do too). https://bugzilla.mozilla.org/show_bug.cgi?id=517882 -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #4 on issue 839 by chipx86: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 There's not. Any code going in to work around this might as well turn into a full patch. The problem is deciding where to support this. Doing it per-review sets a new precedent for review-specific settings, and I don't know about that just yet. Per-repository may not be sufficient in some setups. I'd almost say let's do this in post-review. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Comment #2 on issue 839 by lee.winder: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 Personally I see this as quite an important features. As much as people recommend against using tabs to format text documents, it happens a lot. We do all our development in Visual Studio and most people use tabs. This pretty much makes all our side-by-side diffs harder to read than they should be since a tab in VS is 4 spaces, and it seems like the diff viewer sees them as 9 spaces. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 839 by Vijairaj.R: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 Describe the enhancement and the motivation for it. Please provide a repository wide / per review configuration option to convert tabs in to space when viewed on side-by-side diff. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
