Re: Issue 921 in reviewboard: Add post-commit review submission to post-review for perforce
Comment #7 on issue 921 by erik.l...@gmail.com: Add post-commit review submission to post-review for perforce http://code.google.com/p/reviewboard/issues/detail?id=921 I don't think this change actually solves the problem. When you list a single CLN, it appears to treat it as a range of CLN-1 and CLN. In Perforce (unlike git) this is not the correct behavior as the two change lists can be completely unrelated. It looks like if you run the code with rbt post CLN CLN, it tries to do the right thing but for some reason isn't generating a diff for edit files, only added files (which p4 describe fails to do). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 921 in reviewboard: Add post-commit review submission to post-review for perforce
Updates: Status: Fixed Comment #6 on issue 921 by trowb...@gmail.com: Add post-commit review submission to post-review for perforce http://code.google.com/p/reviewboard/issues/detail?id=921 This is now implemented in rbtools master (9ba6c27). When we release rbtools 0.6, it'll be available in a release. The syntax will be one of these: rbt post CLN rbt post CLN1 CLN2 to post either a single submitted changelist or a range of changes between two submitted changelists. You can't mix submitted changelists and pending/shelved. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 921 in reviewboard: Add post-commit review submission to post-review for perforce
Updates: Status: PendingReview Owner: trowb...@gmail.com Comment #5 on issue 921 by trowb...@gmail.com: Add post-commit review submission to post-review for perforce http://code.google.com/p/reviewboard/issues/detail?id=921 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 921 in reviewboard: Add post-commit review submission to post-review for perforce
Comment #3 on issue 921 by trowb...@gmail.com: Add post-commit review submission to post-review for perforce http://code.google.com/p/reviewboard/issues/detail?id=921 Issue 1747 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 921 in reviewboard: Add post-commit review submission to post-review for perforce
Updates: Summary: Add post-commit review submission to post-review for perforce Labels: -Type-Defect Type-Enhancement Comment #2 on issue 921 by trowbrds: Add post-commit review submission to post-review for perforce http://code.google.com/p/reviewboard/issues/detail?id=921 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
