Re: Issue 2980 in reviewboard: Diff viewer has problems with control characters
Updates: Status: Fixed Comment #9 on issue 2980 by trowb...@gmail.com: Diff viewer has problems with control characters https://code.google.com/p/reviewboard/issues/detail?id=2980 Yes, this was fixed in 2.0.13 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2980 in reviewboard: Diff viewer has problems with control characters
Comment #8 on issue 2980 by pekka.t@gmail.com: Diff viewer has problems with control characters https://code.google.com/p/reviewboard/issues/detail?id=2980 This seems to be fixed in 2.0.13? Briefly tested - looking good now. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2980 in reviewboard: Diff viewer has problems with control characters
Comment #7 on issue 2980 by trowb...@gmail.com: Diff viewer has problems with control characters https://code.google.com/p/reviewboard/issues/detail?id=2980 We're working on it right now, but as you might expect, it's a pretty sticky problem. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2980 in reviewboard: Diff viewer has problems with control characters
Comment #6 on issue 2980 by dccar...@gmail.com: Diff viewer has problems with control characters https://code.google.com/p/reviewboard/issues/detail?id=2980 Any movement on this issue? This is a real bug, even if using ^L in source code is less common than it used to be. In our case, we have no choice, as the code in question is third-party code, not our own. Thanks. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2980 in reviewboard: Diff viewer has problems with control characters
Comment #5 on issue 2980 by dan.schw...@gmail.com: Diff viewer has problems with control characters https://code.google.com/p/reviewboard/issues/detail?id=2980 I believe this issue is the root cause of bug 3609. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2980 in reviewboard: Diff viewer has problems with control characters
Comment #4 on issue 2980 by alan.law...@gmail.com: Diff viewer has problems with control characters https://code.google.com/p/reviewboard/issues/detail?id=2980 There are a number of popular open-source repositories and projects with e.g. ^L form-feed in their sources. For example, GCC. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2980 in reviewboard: Diff viewer has problems with control characters
Comment #3 on issue 2980 by bart...@gmail.com: Diff viewer has problems with control characters http://code.google.com/p/reviewboard/issues/detail?id=2980 The cause is that splitlines() behaves differently for unicode vs regular strings. For unicode, it considers form-feed a line breaking character and splits on that. But for regular strings it does not. For example: 41 zara:~/> python -c 'print "A\n\f\nB\n".splitlines()' ['A', '\x0c', 'B'] # good 42 zara:~/> python -c 'print u"A\n\f\nB\n".splitlines()' [u'A', u'', u'', u'B'] # ate \f and added extra empty elem References: http://bugs.python.org/issue12855 http://stackoverflow.com/questions/24453713/python-string-splitlines-removes-certain-unicode-control-characters This means the lines will be off by the number of ^L chars above it in the diff and won't match the diff. The diff ends up getting stored in the DB w/o the ^L chars. Sometimes it won't patch, and sometimes it does but renders incorrectly. There are a few places where splitlines() is used on the diff. As an experiment I modified DiffParser, DiffChunkGenerator, TextBasedReviewUI, and filter_interdiff_opcodes to use a hacked splitlines() routine that first swaps ^L with NUL, splits, then swaps back and that makes things work (attached). Not sure that is the best strategy, but it ends up being a simple change. A similar approach would be to cons together a random number or UUID along with "reviewboard" and use that as the swap string, or use some other non-printable. It would be nice to see this fixed, but I'm aware that the group of Lisp-influenced Emacs-lovers who employ ^L in this manner might not be a growing population. However, if the RB developers think this is worth persuing I can spend more time on a fix. Attachments: 0001-diffviewer-handle-L-characters-in-diffs.patch 4.6 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2980 in reviewboard: Diff viewer has problems with control characters
Updates: Labels: Component-DiffViewer Comment #2 on issue 2980 by trowb...@gmail.com: Diff viewer has problems with control characters http://code.google.com/p/reviewboard/issues/detail?id=2980 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2980 in reviewboard: Diff viewer has problems with control characters
Comment #1 on issue 2980 by trivi...@gmail.com: Diff viewer has problems with control characters http://code.google.com/p/reviewboard/issues/detail?id=2980 Hi Team, We are also facing the same issue. Any input on this. The strange thing is it used to work on ReviewBoard 1.6.3. Thanks, Satish -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
