Issue 1028 in reviewboard: diffviewer does not show all comments
Updates: Status: Fixed Owner: chipx86 Comment #4 on issue 1028 by chipx86: diffviewer does not show all comments http://code.google.com/p/reviewboard/issues/detail?id=1028 Fixed in r1906. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1028 in reviewboard: diffviewer does not show all comments
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1028 by ksuszka: diffviewer does not show all comments http://code.google.com/p/reviewboard/issues/detail?id=1028 There is a serious bug in findLineNumRow/addCommentFlags java script functions in ReviewBoard Beta 2 which causes some comments not to appear on diff viewer page. (Almost 30% of all comments is not visible on my reviewboard web site) addCommentFlags calls findLineNumRow function and passes LINE numbers as second and third argument, but findLineNumRow treats second and thirds argument as ROW numbers. As the result, findLineNumRow function narrows the area of search to much. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1028 in reviewboard: diffviewer does not show all comments
Comment #1 on issue 1028 by ksuszka: diffviewer does not show all comments http://code.google.com/p/reviewboard/issues/detail?id=1028 I've just recreated the issue on review board demo page. You can see it: http://demo.review-board.org/r/1621/ There are two comments, click the second comment. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
