Re: Issue 2177 in reviewboard: git branch is not used

2011-09-23 Thread reviewboard
Updates: Status: Fixed Comment #9 on issue 2177 by trowb...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 Fixed in master (feeddca). Thanks! -- You received this message because you are subscribed to the Google Groups "reviewboard-issues"

Re: Issue 2177 in reviewboard: git branch is not used

2011-07-17 Thread reviewboard
Updates: Status: New Labels: Component-Docs Comment #8 on issue 2177 by trowb...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 (No comment was entered for this change.) -- You received this message because you are subscribed to the

Re: Issue 2177 in reviewboard: git branch is not used

2011-07-17 Thread reviewboard
Comment #7 on issue 2177 by maciek.b...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 I think I found source of the problem. The index line in git format-patch --full-index contains blobs rather than revisions. Then, the recommended cgit line: h

Re: Issue 2177 in reviewboard: git branch is not used

2011-07-17 Thread reviewboard
Comment #6 on issue 2177 by trowb...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 git diff --full-index branch..HEAD Which, again, assumes that 'branch' is present in the repo that reviewboard knows about. This is equivalent to `post-review --pa

Re: Issue 2177 in reviewboard: git branch is not used

2011-07-17 Thread reviewboard
Comment #5 on issue 2177 by maciek.b...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 Can you provide the parameters that I should use for git format-patch? -- You received this message because you are subscribed to the Google Groups "reviewboard-

Re: Issue 2177 in reviewboard: git branch is not used

2011-07-17 Thread reviewboard
Updates: Status: NotABug Comment #4 on issue 2177 by trowb...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 In general we recommend using post-review to create review requests. The diff has to be against a revision which is present in the

Re: Issue 2177 in reviewboard: git branch is not used

2011-07-16 Thread reviewboard
Comment #3 on issue 2177 by maciek.b...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 Just to be clear, it's not only about posting a review, but also being able to see the diff (that's where raw file url comes into play). I would really like to a

Re: Issue 2177 in reviewboard: git branch is not used

2011-07-16 Thread reviewboard
Comment #2 on issue 2177 by maciek.b...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 I'm using the new review request webpage. The patch was created with git format-patch --full-index. How can I submit a review for branch other than master? --

Re: Issue 2177 in reviewboard: git branch is not used

2011-07-16 Thread reviewboard
Updates: Status: NeedInfo Comment #1 on issue 2177 by trowb...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 How are you creating the review request? Via post-review? The "branch" field is just informational. It's not used in diff generatio

Issue 2177 in reviewboard: git branch is not used

2011-07-16 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2177 by maciek.b...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please