Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces

2013-06-26 Thread reviewboard
Comment #22 on issue 839 by elvst...@gmail.com: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 Comment #18 by Faller.G seems promising. Could this be a place to make a proper option for this? I'm working on an old code base now,

Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces

2013-06-20 Thread reviewboard
Comment #21 on issue 839 by trowb...@gmail.com: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 Issue 3012 has been merged into this issue. -- You received this message because this project is configured to send all issue

Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces

2013-05-10 Thread reviewboard
Comment #20 on issue 839 by satyava...@gmail.com: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 To answer comment https://code.google.com/p/reviewboard/issues/detail?id=839#c3 in the above, I have been personally running

Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces

2011-05-06 Thread reviewboard
Comment #18 on issue 839 by faller.g...@gmail.com: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 I made a change (ReviewBoard-1.0.5.1) in reviewboard\diffviewer\diffutils.py file and everything works: Line 358-359, you will

Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces

2011-04-26 Thread reviewboard
Comment #17 on issue 839 by adrianbo...@gmail.com: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 I wrote a userscript for google chrome and firefox w/greasemonkey that turns tabs into 4 spaces or anything you want. It integrates

Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces

2011-02-21 Thread reviewboard
Updates: Labels: -Priority-Low -Milestone-Release1.7 Priority-High Milestone-Release1.6 Comment #15 on issue 839 by chip...@gmail.com: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 I think we can do something for 1.6. I'll bump

Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces

2010-12-10 Thread reviewboard
Comment #13 on issue 839 by d...@thompsonhome.org: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 Given that the purpose of this entire system is to facilitate code reviews I question why this feature/bug is low priority. Doing

Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces

2010-12-10 Thread reviewboard
Comment #14 on issue 839 by paul.dubois: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 @13, No judgement on your priority argument but modifying the .css is a usable workaround to get server-side tab settings. I can confirm it

Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces

2010-07-12 Thread reviewboard
Comment #10 on issue 839 by paul.dubois: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 Same issue as max9219. We modified PerforceClient in postreview.py to do tab-expansion before diffing, and got patch failures after/upon

Re: Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces

2010-07-09 Thread reviewboard
Comment #8 on issue 839 by paul.dubois: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 This is biting us too. I think for now we'll work around by hacking postreview. FWIW, moz 4.0 has css for modifying tab width (and IIUC it

Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces

2009-06-12 Thread codesite-noreply
Comment #4 on issue 839 by chipx86: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 There's not. Any code going in to work around this might as well turn into a full patch. The problem is deciding where to support this. Doing it

Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces

2009-04-15 Thread codesite-noreply
Comment #2 on issue 839 by lee.winder: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 Personally I see this as quite an important features. As much as people recommend against using tabs to format text documents, it happens a lot.

Issue 839 in reviewboard: Option to convert tabs in the diff to (n) spaces

2009-02-01 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 839 by Vijairaj.R: Option to convert tabs in the diff to (n) spaces http://code.google.com/p/reviewboard/issues/detail?id=839 Describe the enhancement and the motivation for it. Please provide a repository wide / per review