Status: New Owner: ---- Labels: Type-Defect Priority-Medium New issue 1173 by jamesdlin: Binary files aren't listed in the diff? http://code.google.com/p/reviewboard/issues/detail?id=1173
*NOTE: Do not post confidential information in this bug report.* What version are you running? chipx86 says 1.0RC3. What's the URL of the page containing the problem? What steps will reproduce the problem? 1. Create a review that includes adds or edits to binary files. 2. View the diff. What is the expected output? What do you see instead? The binary files are listed among the "Files changed" momentarily with throbber icons, but after they're fetched, they're removed. Although we can't show diffs of binary files, listing them (and showing whether they're added, deleted, or edited) is important. (How else can you know if someone forgot to include a required binary file in their change?) What operating system are you using? What browser? Windows XP x64 SP2, Firefox 3.0.11 Please provide any additional information below. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~----------~----~----~----~------~----~------~--~---
