Status: New Owner: ---- Labels: Type-Defect Priority-Medium New issue 1309 by zoran.rajic: DashBoard: Using spaces for reviewers break review records http://code.google.com/p/reviewboard/issues/detail?id=1309
*NOTE: Do not post confidential information in this bug report.* What version are you running? ReviewBoard 1.0.1 What's the URL of the page containing the problem? [ sorry, not accessible, it's behind the company firewall ] What steps will reproduce the problem? 1. Publish review, add 2 reviewers 2. Edit reviewers -- remove first, but leave a space char before second 3. Click OK >> Result: everything appears to be fine, page rendered correctly; however, hitting the refresh on the browser produces TemplateSyntaxError What is the expected output? What do you see instead? The Dashboard for this review ID should render correctly. However, accessing the review ID (i.e. http://company.com/r/123/) will always produces the following exception: | TemplateSyntaxError at /r/123/ | Caught an exception while rendering: Reverse for 'reviewboard.user' with arguments '(<User: zoran.rajic>,)' and keyword arguments '{}' not found. .. furthermore, a brand new username seems to be inserted into the reviewboard's database (note the ' '-char in front of the e-mail: mysql> select * from auth_user where id=67 \G; *************************** 1. row *************************** id: 67 username: zoran.rajic first_name: Zoran last_name: Rajic email: zoran.ra...@company.com password: ! is_staff: 0 is_active: 1 is_superuser: 0 last_login: 2009-09-11 13:52:21 date_joined: 2009-09-11 13:52:21 1 row in set (0.01 sec) The new username is also reflected in the list of users - so one ends up with "username" and " username" in the list. What operating system are you using? What browser? ReviewBoard 1.0.1 running on OpenSuse v11.1 64bit Linux, Python v2.6.0, Apache v2.2.10, MySQL v5.0.67 Reproduced with Firefox 3.5 (Windows and Linux), also MS Internet Exploder 7 Please provide any additional information below. Exception stack-trace: Exception Type: TemplateSyntaxError Exception Value: Caught an exception while rendering: Reverse for 'reviewboard.user' with arguments '(<User: zoran.rajic>,)' and keyword arguments '{}' not found. Template error In template /usr/local/lib64/python2.6/site-packages/ReviewBoard-1.0.1-py2.6.egg/reviewboard/templates/reviews/review_request_box.html, error at line 49 Caught an exception while rendering: Reverse for 'reviewboard.user' with arguments '(<User: zoran.rajic>,)' and keyword arguments '{}' not found. 39 <td class="label"><label for="bugs_closed">{% trans "Bugs" %}:</label></td> 40 <td class="value"><span id="bugs_closed" class="editable comma-editable">{% spaceless %} 41 {% for bug in review_request_details.get_bug_list %} 42 {% with bug|bug_url:review_request as bug_url %} 43 {% if bug_url %}<a href="{{bug_url}}">{{bug}}</a>{% else %}{{bug}}{% endif %}{% if not forloop.last %}, {% endif %} 44 {% endwith %} 45 {% endfor %} 46 {% endspaceless %}</span></td> 47 <td class="indented label"><label for="target_people">{% trans "People" %}:</label></td> 48 <td class="value"><span id="target_people" class="editable comma-editable">{% spaceless %} 49 {% for person in review_request_details.target_people.all %} 50 <a href="{% url user person %}"{% if not person.is_active %} class="inactive"{% endif %}>{{person}}</a>{% if not forloop.last %}, {% endif %} 51 {% endfor %} 52 {% endspaceless %}</span></td> 53 </tr> 54 <tr> 55 <td class="label"><label for="changenum">{% trans "Change Number" %}:</label></td> 56 <td class="value"><span id="changenum">{{review_request.changenum}}</span></td> 57 <td class="label"><label for="repository">{% trans "Repository" %}:</label></td> 58 <td class="value"><span id="repository">{{review_request.repository}}</span></td> 59 </tr> Attachments: reproducing_defect.png 7.2 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~----------~----~----~----~------~----~------~--~---
