Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 2419 by tif...@gmail.com: Deleting 2 binary files using diff
--git: only the second deleted file is seen in the review
http://code.google.com/p/reviewboard/issues/detail?id=2419
Review board 1.6.3
When removing two binary files using the following diff:
----------
diff --git a/app1.exe b/app1.exe
deleted file mode 100644
Binary file app1.exe has changed
diff --git a/app2.exe b/app2.exe
deleted file mode 100644
Binary file app2.exe has changed
----------
Only the second file gets removed. The first one is not seen by reviewboard
and has been removed from the diff when downloading the diff from
reviewboard.
When adding an empty line between the two removals in the diff. The diff
gets parsed correctly by reviewboard:
----------
diff --git a/app1.exe b/app1.exe
deleted file mode 100644
Binary file app1.exe has changed
diff --git a/app2.exe b/app2.exe
deleted file mode 100644
Binary file app2.exe has changed
----------
The diff parsing of reviewboard is probably too strict. Related to this
problem: why does reviewboard modify the diffs I upload to it? I don't see
any reason to tamper with the diffs uploaded to reviewboard.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.