Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 3844 by dumont....@gmail.com: SVN Post : doesn't support commit
log with special characters
https://code.google.com/p/reviewboard/issues/detail?id=3844
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.
What version are you running?
RBTools 0.7.2
What's the URL of the page containing the problem?
svn.py
What steps will reproduce the problem?
1. Use SVN as repository
2. Commit a modification with 'accented' characters (like à é è, etc.)
3. Try to push a post commit review with rbt post 'revision_number'
What is the expected output? What do you see instead?
RBTool must manage to parse the log to find the revision, even the log
comment contains accented characters.
What operating system are you using? What browser?
Win 7. Mozilla.
Please provide any additional information below.
I managed to correct this issue with a DRAFT modification on svn.py, in the
function _convert_symbolic_revision :
line 183 :
root = ElementTree.fromstring(log)
modified to :
root = ElementTree.fromstring(log.encode('utf-8'))
I haven't put a patch on review as it's certainly not the best way to
correct this problem, but it confirms that the problem comes from here.
Regards,
Jonathan
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
