Issue 1173 in reviewboard: Binary files aren't listed in the diff?

Updates: Status: Fixed Owner: chipx86 Comment #5 on issue 1173 by chipx86: Binary files aren't listed in the diff? http://code.google.com/p/reviewboard/issues/detail?id=1173 Fixed in master (reb80a58) and release-1.0.x (reb80a58) -- You received this message because you are

Issue 1173 in reviewboard: Binary files aren't listed in the diff?

Comment #2 on issue 1173 by erichuss: Binary files aren't listed in the diff? http://code.google.com/p/reviewboard/issues/detail?id=1173 I looked at this briefly. The diff fragment URL is telling it to remove the entry. From a URL like this:

Issue 1173 in reviewboard: Binary files aren't listed in the diff?

Updates: Status: Confirmed Labels: Milestone-Release1.0.x Component-DiffViewer Comment #3 on issue 1173 by chipx86: Binary files aren't listed in the diff? http://code.google.com/p/reviewboard/issues/detail?id=1173 That seems to be the problem. We should get this in for 1.0.5.

Issue 1173 in reviewboard: Binary files aren't listed in the diff?

Updates: Labels: -Priority-Medium Priority-High Comment #4 on issue 1173 by chipx86: Binary files aren't listed in the diff? http://code.google.com/p/reviewboard/issues/detail?id=1173 (No comment was entered for this change.) -- You received this message because you are listed in the

Issue 1173 in reviewboard: Binary files aren't listed in the diff?

Comment #1 on issue 1173 by m...@roboss.com: Binary files aren't listed in the diff? http://code.google.com/p/reviewboard/issues/detail?id=1173 Unicode encoded files don't diff and are treated as binary files. Not seeing them in the diff can be dangerous. It's good to know what's touched