Re: Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache
Updates: Status: Duplicate Mergedinto: 387 Comment #11 on issue 1183 by trowb...@gmail.com: Viewing diff in review request causes traceback involving memcache http://code.google.com/p/reviewboard/issues/detail?id=1183 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache
Updates: Status: New Comment #10 on issue 1183 by trowbrds: Viewing diff in review request causes traceback involving memcache http://code.google.com/p/reviewboard/issues/detail?id=1183 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache
Comment #9 on issue 1183 by Karrde712: Viewing diff in review request causes traceback involving memcache http://code.google.com/p/reviewboard/issues/detail?id=1183 I'm seeing this same issue on ReviewBoard 1.5. The diff (downloading the raw works fine): https://fedorahosted.org/reviewboard/r/87/diff/raw/ (Note, this diff is only adding a blank line) The error page: https://fedorahosted.org/reviewboard/r/87/diff/#index_header There are no unusual characters in the diff. We are using ReviewBoard 1.5 on python 2.4.3 on Red Hat Enterprise Linux. Bazaar is version 2.1.1 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache
Updates: Labels: Component-DiffViewer Comment #8 on issue 1183 by trowbrds: Viewing diff in review request causes traceback involving memcache http://code.google.com/p/reviewboard/issues/detail?id=1183 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache
Comment #7 on issue 1183 by eero.temp: Viewing diff in review request causes traceback involving memcache http://code.google.com/p/reviewboard/issues/detail?id=1183 Here's the original diff... Attachments: test.diff 288 bytes -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache
Updates: Status: NeedInfo Comment #6 on issue 1183 by chipx86: Viewing diff in review request causes traceback involving memcache http://code.google.com/p/reviewboard/issues/detail?id=1183 Can you give me the names of the files in the diff? Or at least, let me know if there's any non-alphanumeric characters in there (spaces, colons, non-English letters, etc.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache
Comment #5 on issue 1183 by eero.temp: Viewing diff in review request causes traceback involving memcache http://code.google.com/p/reviewboard/issues/detail?id=1183 Got this problem with a fresh install of version 1.0.9. Did anyone ever find a solution for this? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache
Updates: Status: Fixed Comment #4 on issue 1183 by trowbrds: Viewing diff in review request causes traceback involving memcache http://code.google.com/p/reviewboard/issues/detail?id=1183 If 1.0 works, I'm gonna close this out. Please update if it's still a problem. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache
Comment #3 on issue 1183 by ksee.zelgadis: Viewing diff in review request causes traceback involving memcache http://code.google.com/p/reviewboard/issues/detail?id=1183 Ah, upgrade to 1.0 helped. Thanks. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache
Updates: Status: NeedInfo Comment #1 on issue 1183 by chipx86: Viewing diff in review request causes traceback involving memcache http://code.google.com/p/reviewboard/issues/detail?id=1183 Definitely never seen that before. Any chance you can provide us with a diff that reproduces this problem for our unit tests? Ideally, provide a dummy repository with some files, and a diff against that, so we can bundle it and make sure this doesn't happen again. If it even is in our control. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1183 in reviewboard: Viewing diff in review request causes traceback involving memcache
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1183 by robwalker01: Viewing diff in review request causes traceback involving memcache http://code.google.com/p/reviewboard/issues/detail?id=1183 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0 Final What's the URL of the page containing the problem? http://10.0.0.9/r/2/diff/#index_header What steps will reproduce the problem? 1. Set up a Bazaar branch as the repository. 2. Create a diff using the windows command console, something to the effect of "bzr diff > foo.diff". 3. Create a review request in Review Board, uploading the diff file, and using "/" as the base path (the diff was the same directory as the branch/repo). What is the expected output? What do you see instead? I expect to see a diff. Instead I see a traceback. What operating system are you using? What browser? Windows XP 32bit SP2. Mozilla Firefox 3.0.11 Please provide any additional information below. This is the actual output of the traceback: Traceback (most recent call last): File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0-py2.6.egg/reviewboard/diffviewer/views.py", line 152, in view_diff interdiffset, highlighting, True) File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 623, in get_diff_files large_data=True) File "/usr/local/lib/python2.6/dist-packages/Djblets-0.5-py2.6.egg/djblets/util/misc.py", line 143, in cache_memoize data = lookup_callable() File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 622, in enable_syntax_highlighting), File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 344, in get_chunks old = get_original_file(filediff) File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 251, in get_original_file large_data=True)[0] File "/usr/local/lib/python2.6/dist-packages/Djblets-0.5-py2.6.egg/djblets/util/misc.py", line 134, in cache_memoize if not force_overwrite and cache.has_key(key): File "/usr/local/lib/python2.6/dist-packages/Django-1.0.2_final-py2.6.egg/django/core/cache/backends/base.py", line 66, in has_key return self.get(key) is not None File "/usr/local/lib/python2.6/dist-packages/Django-1.0.2_final-py2.6.egg/django/core/cache/backends/memcached.py", line 25, in get val = self._cache.get(smart_str(key)) File "/var/lib/python-support/python2.6/memcache.py", line 619, in get check_key(key) File "/var/lib/python-support/python2.6/memcache.py", line 888, in check_key raise Client.MemcachedKeyCharacterError, "Control characters not allowed" MemcachedKeyCharacterError: Control characters not allowed -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
