Comment #1 on issue 1217 by madcoder: Enhanced error detection when
uploading diff
http://code.google.com/p/reviewboard/issues/detail?id=1217
Here's one example that's not exactly what is described above, but is kind
of
related. It's due to subsequent diffs adding files that didn't exist in
the original
diff. E.g.:
$ vi foo.txt # new file
$ svn add foo.txt
$ svn diff > rb-1.diff
$ vi foo.txt # edit
$ vi bar.txt # new file
$ svn add bar.txt
$ svn diff > rb-2.diff
Because bar.txt didn't exist in the original diff, adding it in rb-2.diff
results in
an exception when viewing the differences between r1 and r2:
Traceback (most recent call last):
File
"/usr/local/lib/python2.6/site-packages/ReviewBoard-1.0alpha4-py2.6.egg/reviewboard/diffviewer/views.py",
line 145, in view_diff
interdiffset, highlighting, True)[0]
IndexError: list index out of range
The desired behavior would be that is shows the modification to foo.txt,
and the
addition of bar.txt.
Attachments:
rb-1.diff 341 bytes
rb-2.diff 710 bytes
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---
