Issue 1280 in reviewboard: os.uname doesn't exist on windows
Comment #4 on issue 1280 by chipx86: os.uname doesn't exist on windows http://code.google.com/p/reviewboard/issues/detail?id=1280 Just trunk. This is in rbtools, not Review Board. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1280 in reviewboard: os.uname doesn't exist on windows
Comment #3 on issue 1280 by trowbrds: os.uname doesn't exist on windows http://code.google.com/p/reviewboard/issues/detail?id=1280 Christian, did you commit to 1.0.x as well or just trunk? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1280 in reviewboard: os.uname doesn't exist on windows
Updates: Status: Fixed Owner: chipx86 Labels: -Priority-Medium Priority-High Component-RBTools OpSys-Windows Comment #2 on issue 1280 by chipx86: os.uname doesn't exist on windows http://code.google.com/p/reviewboard/issues/detail?id=1280 Committed in r2111. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1280 in reviewboard: os.uname doesn't exist on windows
Comment #1 on issue 1280 by jeamland: os.uname doesn't exist on windows http://code.google.com/p/reviewboard/issues/detail?id=1280 I posted a review to the reviewboard reviewboard (my first! if I did something wrong, let me know!) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1280 in reviewboard: os.uname doesn't exist on windows
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1280 by jeamland: os.uname doesn't exist on windows http://code.google.com/p/reviewboard/issues/detail?id=1280 *NOTE: Do not post confidential information in this bug report.* What version are you running? rbtools nightly 0.2beta2.dev-20090819 What's the URL of the page containing the problem? N/A What steps will reproduce the problem? 1. Install rbtools nightly (version above) on windows 2. run post-review -d 3. error will appear What is the expected output? What do you see instead? should upload the new review and give the url. instead, complains about "module' object has no attribute 'uname' What operating system are you using? What browser? Windows Vista, browser N/A Please provide any additional information below. This has a trivial solution: issue 646 changed line 1632 of postreview.py to check uname for Solaris. uname doesn't exist on windows, so line should read instead: if hasattr(os,'uname') and os.uname()[0] == 'SunOS': I really need to get installed so that I can just post reviews to the review board review board :) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
