Re: Issue 1343 in reviewboard: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation
Comment #10 on issue 1343 by chris.a@gmail.com: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation http://code.google.com/p/reviewboard/issues/detail?id=1343 I'm still having issues with this on ReviewBoard 1.6.5. Our company uses a hosted MS Outlook service. Here's the trace from the logfile (with subject and email addresses changed): Error sending e-mail notification with subject 'Re: Review Request: Subject' on behalf of '"John Doe" ' to '"Joe Blow" ': (550, '5.7.1 Client does not have permissions to send on behalf of the from address') Traceback (most recent call last): File "/usr/lib/python2.5/site-packages/ReviewBoard-1.6.5-py2.5.egg/reviewboard/notifications/email.py", line 231, in send_review_mail message.send() File "/usr/lib/python2.5/site-packages/Django-1.3.1-py2.5.egg/django/core/mail/message.py", line 251, in send return self.get_connection(fail_silently).send_messages([self]) File "/usr/lib/python2.5/site-packages/Django-1.3.1-py2.5.egg/django/core/mail/backends/smtp.py", line 86, in send_messages sent = self._send(message) File "/usr/lib/python2.5/site-packages/Django-1.3.1-py2.5.egg/django/core/mail/backends/smtp.py", line 104, in _send email_message.message().as_string()) File "/usr/lib/python2.5/smtplib.py", line 707, in sendmail raise SMTPDataError(code, resp) SMTPDataError: (550, '5.7.1 Client does not have permissions to send on behalf of the from address') The "Sender e-mail address" in the admin settings is reviewbo...@example.com. In the past I've had to "get around" this by setting every user's email address to match that, and just tell everyone to make sure they include the group mailing list on their reviews, but obviously that sucks. Is there a way to configure reviewboard such that it just does a standard From using that value and does not use "sender" headers to make it "on behalf of" the users? Setting up the mail servers to allow sending on behalf of other accounts is beyond my control. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1343 in reviewboard: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation
Comment #9 on issue 1343 by sourto...@gmail.com: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation http://code.google.com/p/reviewboard/issues/detail?id=1343 I have now sent a patch to the mailing list which fixes SPF compliance, and thus comment #8's issue. Please find it attached here as well. Attachments: fix-reviewboard-spf-compliance.patch 791 bytes -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1343 in reviewboard: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation
Comment #8 on issue 1343 by truan.h...@gmail.com: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation http://code.google.com/p/reviewboard/issues/detail?id=1343 I had hoped this would fix an issue we have whereby emails don't get sent because Exchange will only accept emails with a From field that matches the account you log into it as. I thought the setting would allow the override of the From field, however it seems to still use the ReviewBoard user as the From field and use the override as the Sender ( I thought it would be the other way round). Have I misunderstood, or is it broken? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1343 in reviewboard: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation
Comment #7 on issue 1343 by volution...@gmail.com: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation http://code.google.com/p/reviewboard/issues/detail?id=1343 thankyou -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1343 in reviewboard: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation
Updates: Status: Fixed Owner: chipx86 Labels: Milestone-Release1.6 Comment #6 on issue 1343 by chip...@gmail.com: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation http://code.google.com/p/reviewboard/issues/detail?id=1343 This has been implemented for 1.6. It's not an option. Maybe it can be made eventually, but for now we're going forward with it. I know it's annoying, but I know in your case you'll be using Zimbra before long ;) Hopefully they don't do it or can change it. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1343 in reviewboard: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation
Comment #5 on issue 1343 by trowbrds: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation http://code.google.com/p/reviewboard/issues/detail?id=1343 Issue 1646 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1343 in reviewboard: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation
Comment #4 on issue 1343 by bernard3000: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation http://code.google.com/p/reviewboard/issues/detail?id=1343 Whatever you do here -- make it an option. For us, it works well (Microsoft Exchange Server). I prefer to "fake" that the email really came from me (because, in reality, it is almost true, I wrote almost all of it). In Outlook, it looks weird when you use the From:/Sender: field stuff: The wording "on behalf of" appears in the user's list, a bit annoying. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1343 in reviewboard: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation
Updates: Status: NeedInfo Comment #1 on issue 1343 by chipx86: forging a user's 'From:' address in email notifications is incompatible with DKIM/mail filtering/review list moderation http://code.google.com/p/reviewboard/issues/detail?id=1343 I know very little about DKIM, but am reading up on it now. So to solve this, would I instead be able to have RB set the From address as "Author's Name " and then change Sender: and Reply-to: to be the value we previously were setting as the From: address? Signing happens on the mail server, but not at all on our end, right? As for the From: address we choose, will we have the same problem if we were to generate a dummy e-mail address, and send it through a server with DKIM support? In other words, it's important to allow for specifying the e-mail address, right? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
