Issue 1353 in reviewboard: Change selection frame sticks to screen position when expanding unchanged lines

2009-10-13 Thread codesite-noreply

Updates:
Status: Fixed
Owner: chipx86
Labels: Component-DiffViewer Milestone-Release1.0.x

Comment #1 on issue 1353 by chipx86: Change selection frame sticks to  
screen position when expanding unchanged lines
http://code.google.com/p/reviewboard/issues/detail?id=1353

Fixed on master and release-1.0.x (rddfc9bd)

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 1353 in reviewboard: Change selection frame sticks to screen position when expanding unchanged lines

2009-10-09 Thread codesite-noreply

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1353 by OliverCGoetz: Change selection frame sticks to screen  
position when expanding unchanged lines
http://code.google.com/p/reviewboard/issues/detail?id=1353

*NOTE: Do not post confidential information in this bug report.*

What version are you running?
1.0.4

What's the URL of the page containing the problem?
internal system: view diffs

What steps will reproduce the problem?
1. Find a review request with collapsed lines above the first diff.
2. Go to "View Diff"
3. Select the first diff by clicking on it; a rectangular frame will appear
around it.
4. Expand collapsed text above the change.

What is the expected output? What do you see instead?

I would expect that the frame indicating the selected diff moves down the
page with the diff. Instead the frame stays on the screen position where
the diff was before expanding the hidden lines.

What operating system are you using? What browser?
OS: Windows XP
Browser: Firefox 3.5.3

Please provide any additional information below.
I just checked the issue with Internet Explorer 7.0.5730.13, and there it
does not occur: instead the frame moved with the selected diff as expected.


Attachments:
stickyframe1.png  46.2 KB
stickyframe2.png  52.1 KB
stickyframe3.png  53.8 KB

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---