Status: New Owner: ---- Labels: Type-Defect Priority-Medium New issue 1378 by p...@swooby.com: RBTools: More friendly handling of error when diff utility not in path http://code.google.com/p/reviewboard/issues/detail?id=1378
*NOTE: Do not post confidential information in this bug report.* Opening this bug per Christian Hammond. What version are you running? RBTools 0.2beta2 What's the URL of the page containing the problem? n/a What steps will reproduce the problem? 1. Don't have diff[.exe] in the path 2. Run a post-review What is the expected output? More friendly error reporting of the missing diff utility. It should be pretty easy to detect "svn: Can't start process 'diff': The system cannot find the file specified." and highlight that in the output (and ideally a quick "Check your PATH" hint). What do you see instead? >>> svn info >>> repository info: Path: svn://devsrvsea01/svnroot, Base path: /trunk/StopProcess, Supports changesets: False >>> svn propget reviewboard:url C:\src\trunk\StopProcess >>> svn propget reviewboard:url C:\src\trunk\ >>> svn diff --diff-cmd=diff -r 24506 Failed to execute command: ['svn', 'diff', '--diff-cmd=diff', '-r', '24506'] ['Index: StopProcess/obj/Debug/StopProcess.exe\n', '=================================================================== \n', 'Cannot display: file marked as a binary type.\n', 'svn:mime-type = application/octet-stream\n', 'Index: StopProcess/obj/Debug/ StopProcess.pdb\n', '=================================================================== \n', 'Cannot display: file marked as a binary type.\n', 'svn:mime-type = application/octet-stream\n', 'Index: StopProcess/obj/Debug/StopProcess.csproj.FileListAbsolute.txt\n', '============================================================ =======\n', "svn: Can't start process 'diff': The system cannot find the file specified. \n"] What operating system are you using? What browser? n/a Please provide any additional information below. n/a -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~----------~----~----~----~------~----~------~--~---
