Re: Issue 1673 in reviewboard: post-review revision-range doesn't handle single revision as advertised
Updates: Status: Fixed Comment #5 on issue 1673 by trowb...@gmail.com: post-review revision-range doesn't handle single revision as advertised http://code.google.com/p/reviewboard/issues/detail?id=1673 This is fixed in rbtools master (which will ship as 0.6) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1673 in reviewboard: post-review revision-range doesn't handle single revision as advertised
Comment #4 on issue 1673 by jo...@radius.com: post-review revision-range doesn't handle single revision as advertised http://code.google.com/p/reviewboard/issues/detail?id=1673 I have noticed the same thing with Git in v. 0.5. Reading the docs I would expect this flag to be useful for posting a commit of a specific commit, even if it has not yet been pushed to the remote repository. The expectation for me is rbt post --revision-range=HEAD would post only the changes between HEAD^ and HEAD, e. g. create a parent diff between origin/HEAD and local HEAD^ and the a diff between HEAD^ and HEAD. Instead rbt post --revision-range=HEAD generates a parent diff between origin/HEAD local HEAD, and an empty diff for the review diff. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1673 in reviewboard: post-review revision-range doesn't handle single revision as advertised
Comment #3 on issue 1673 by phillipb30: post-review revision-range doesn't handle single revision as advertised http://code.google.com/p/reviewboard/issues/detail?id=1673 I've noticed this as well. With SVN it looks like its running svn diff --diff-cmd=diff -r 24 when it should run svn diff --diff-cmd=diff -c 24 or svn diff --diff-cmd=diff -r 23:24 -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1673 in reviewboard: post-review revision-range doesn't handle single revision as advertised
Updates: Labels: Component-RBTools Comment #2 on issue 1673 by trowbrds: post-review revision-range doesn't handle single revision as advertised http://code.google.com/p/reviewboard/issues/detail?id=1673 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1673 in reviewboard: post-review revision-range doesn't handle single revision as advertised
Comment #1 on issue 1673 by l.holst: post-review revision-range doesn't handle single revision as advertised http://code.google.com/p/reviewboard/issues/detail?id=1673 I can confirm this issue. I’m using post-review on a Mercurial repository. I wonder if there’s a workaround. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1673 in reviewboard: post-review revision-range doesn't handle single revision as advertised
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1673 by gordon.morehouse: post-review revision-range doesn't
handle single revision as advertised
http://code.google.com/p/reviewboard/issues/detail?id=1673
What version are you running?
RBTools 0.2
What steps will reproduce the problem?
1. Enter a command line with a single revision: 'post-review --revision-
range=20397'
What is the expected output? What do you see instead?
The docs at http://www.reviewboard.org/docs/manual/dev/users/tools/post-
review/#posting-committed-code state that this should work. Instead, I
get:
Traceback (most recent call last):
File /usr/local/bin/post-review, line 9, in module
load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')()
File /usr/local/lib/python2.6/dist-packages/rbtools/postreview.py, line
2830, in main
repository_info)
File /usr/local/lib/python2.6/dist-packages/rbtools/postreview.py, line
2034, in diff_between_revisions
r1, r2 = revision_range.split(':')
ValueError: need more than 1 value to unpack
What operating system are you using? What browser?
Ubuntu 10.04 LTS.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
