Re: Issue 1742 in reviewboard: Awkward workflow when reviewing code.

2011-03-20 Thread reviewboard

Updates:
Status: Fixed

Comment #5 on issue 1742 by trowb...@gmail.com: Awkward workflow when  
reviewing code.

http://code.google.com/p/reviewboard/issues/detail?id=1742

I think the one-click ship-it that's in 1.6 addresses this.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1742 in reviewboard: Awkward workflow when reviewing code.

2010-10-30 Thread reviewboard


Comment #3 on issue 1742 by rv.nath: Awkward workflow when reviewing code.
http://code.google.com/p/reviewboard/issues/detail?id=1742

As a first time user, it was a frustrating experience :).

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1742 in reviewboard: Awkward workflow when reviewing code.

2010-10-08 Thread reviewboard


Comment #2 on issue 1742 by earthling: Awkward workflow when reviewing code.
http://code.google.com/p/reviewboard/issues/detail?id=1742

The problem is that it isn't clear which button you're supposed to click at  
a given time. The labels don't make sense. And it isn't clear from the UI  
that there is a preferred workflow.


I do like and use the inline commenting. And yes, the first time user  
experience is very confusing. But so is the repeat user experience.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1742 in reviewboard: Awkward workflow when reviewing code.

2010-10-07 Thread reviewboard

Updates:
Labels: -Type-Defect Type-Enhancement

Comment #1 on issue 1742 by trowbrds: Awkward workflow when reviewing code.
http://code.google.com/p/reviewboard/issues/detail?id=1742

Hmm. That's kind of skipping out on a lot of review board's functionality  
(the power is truly in inline commenting), but I can see how it might be  
bewildering what to do if you're a first time user. We should definitely  
see what we can do to make things more discoverable.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1742 in reviewboard: Awkward workflow when reviewing code.

2010-07-29 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1742 by earthling: Awkward workflow when reviewing code.
http://code.google.com/p/reviewboard/issues/detail?id=1742

What version are you running?
1.0.9

What's the URL of the page containing the problem?
It starts by clicking the link in the review request.

What steps will reproduce the problem?
1. Click the link in the review request.
2. It's completely unapparent what you're supposed to do.

What is the expected output? What do you see instead?
I usually click the review button. But then you're taken to an overlay  
that has a checkbox ship it and an unlabeled text area. Clicking the back  
button doesn't work, so you have to go back to your email and click the  
request link again or navigate there some other way.


Clicking the view diff button is actually what you want. When you do  
that, the diff shows up, but then there's no obvious way to approve the  
diff. A big approve or diff button that looks like a submit button  
would really help. Instead, you have to click on a little tab in the upper  
right that says review.



What operating system are you using? What browser?


Please provide any additional information below.

One possible quick and dirty solution might be to go straight to the diff  
from the email link. Then a prominent way to approve the diff would make  
the whole process more obvious.



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.