Re: Issue 1756 in reviewboard: Download Diff button doesn't download the diff file in Safari

2010-08-30 Thread reviewboard 

Updates:
Status: ThirdParty

Comment #1 on issue 1756 by trowbrds: Download Diff button doesn't download  
the diff file in Safari

http://code.google.com/p/reviewboard/issues/detail?id=1756

We give the file type as text/x-patch (which is correct). If safari wants  
to display that, there's not much we can do about that.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Issue 1756 in reviewboard: Download Diff button doesn't download the diff file in Safari

2010-08-10 Thread reviewboard 

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1756 by email.app: Download Diff button doesn't download the diff  
file in Safari

http://code.google.com/p/reviewboard/issues/detail?id=1756

*NOTE: Do not post confidential information in this bug report.*

What version are you running?
1.0.9

What's the URL of the page containing the problem?
http://private/codereviews/r/1/

What steps will reproduce the problem?
1. View a review in Safari 5.0.1 on Mac OS X 10.6.4.
2. Click the Download Diff button.

What is the expected output? What do you see instead?
I expected Safari to download the diffs as a file, and not change the  
viewed page.  Instead, the viewed page changes to  
http://private/codereviews/r/1/diff/raw/ , and the diffs are viewed as a  
text file in Safari.


What operating system are you using? What browser?
Mac OS X 10.6.4, Safari 5.0.1.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.