Re: Issue 1870 in reviewboard: base path does not work with svn-hook-postcommit-review
Updates: Status: Fixed Comment #3 on issue 1870 by trowbrds: base path does not work with svn-hook-postcommit-review http://code.google.com/p/reviewboard/issues/detail?id=1870 Fixed in master as e28acf0. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1870 in reviewboard: base path does not work with svn-hook-postcommit-review
Comment #2 on issue 1870 by Xomenn: base path does not work with svn-hook-postcommit-review http://code.google.com/p/reviewboard/issues/detail?id=1870 Submitted http://reviews.reviewboard.org/r/1875 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1870 in reviewboard: base path does not work with svn-hook-postcommit-review
Updates: Labels: Component-Scripts Comment #1 on issue 1870 by chipx86: base path does not work with svn-hook-postcommit-review http://code.google.com/p/reviewboard/issues/detail?id=1870 Thanks. Can you post this up on http://reviews.reviewboard.org/? We don't do patch review on the bug tracker. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1870 in reviewboard: base path does not work with svn-hook-postcommit-review
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1870 by Xomenn: base path does not work with svn-hook-postcommit-review http://code.google.com/p/reviewboard/issues/detail?id=1870 I realize this is a contributed script and probably isn't all that supported but the base path parameter in /contrib/tools/svn-hook-postcommit-review is not functioning. I get an error from post-review showing that it included the quotes in the paths it passed to svn diff and other commands (forgot to copy/paste). I attached a patch to not pass the quotes to those commands (first time creating a git patch). Attachments: svn-hook base path.diff 647 bytes -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
