Re: Issue 1987 in reviewboard: Summary containing newline fails to send email

2011-03-20 Thread reviewboard 

Updates:
Status: Duplicate
Mergedinto: 1689

Comment #4 on issue 1987 by trowb...@gmail.com: Summary containing newline  
fails to send email

http://code.google.com/p/reviewboard/issues/detail?id=1987

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Re: Issue 1987 in reviewboard: Summary containing newline fails to send email

2011-03-13 Thread reviewboard 

Updates:
Status: New

Comment #3 on issue 1987 by trowb...@gmail.com: Summary containing newline  
fails to send email

http://code.google.com/p/reviewboard/issues/detail?id=1987

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Re: Issue 1987 in reviewboard: Summary containing newline fails to send email

2011-02-16 Thread reviewboard 


Comment #2 on issue 1987 by adj...@gmail.com: Summary containing newline  
fails to send email

http://code.google.com/p/reviewboard/issues/detail?id=1987

when a review covers several commits, and I use post-review's  
--guess-summary option, it generates a summary with all commit summaries  
separated by newlines


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Re: Issue 1987 in reviewboard: Summary containing newline fails to send email

2011-02-16 Thread reviewboard 

Updates:
Status: NeedInfo

Comment #1 on issue 1987 by chip...@gmail.com: Summary containing newline  
fails to send email

http://code.google.com/p/reviewboard/issues/detail?id=1987

What are you doing that's causing a newline to appear?

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Issue 1987 in reviewboard: Summary containing newline fails to send email

2011-02-16 Thread reviewboard 

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1987 by adj...@gmail.com: Summary containing newline fails to  
send email

http://code.google.com/p/reviewboard/issues/detail?id=1987

What version are you running?


What's the URL of the page containing the problem?


What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.
ERROR:root:Error sending e-mail notification with subject 'Re: Review  
Request:summary with a
new line' on behalf of '"xyz" ' to '"a" ,"p"  
': Header values can't contain newlines (got u'Re: Review Request:  
summary with a \n newline' for header 'Subject')

Traceback (most recent call last):
   
File "/usr/lib/python2.5/site-packages/ReviewBoard-1.5.3.1-py2.5.egg/reviewboard/notifications/email.py",  
line 177, in send_review_mail

message.send()
   
File "/usr/lib/python2.5/site-packages/Django-1.2.3-py2.5.egg/django/core/mail/message.py",  
line 175, in send

return self.get_connection(fail_silently).send_messages([self])
   
File "/usr/lib/python2.5/site-packages/Django-1.2.3-py2.5.egg/django/core/mail/backends/smtp.py",  
line 85, in send_messages

sent = self._send(message)
   
File "/usr/lib/python2.5/site-packages/Django-1.2.3-py2.5.egg/django/core/mail/backends/smtp.py",  
line 101, in _send

email_message.message().as_string())
   
File "/usr/lib/python2.5/site-packages/ReviewBoard-1.5.3.1-py2.5.egg/reviewboard/notifications/email.py",  
line 93, in message

msg = super(SpiffyEmailMessage, self).message()
   
File "/usr/lib/python2.5/site-packages/Django-1.2.3-py2.5.egg/django/core/mail/message.py",  
line 145, in message

msg['Subject'] = self.subject
   
File "/usr/lib/python2.5/site-packages/Django-1.2.3-py2.5.egg/django/core/mail/message.py",  
line 96, in __setitem__

name, val = forbid_multi_line_headers(name, val, self.encoding)
   
File "/usr/lib/python2.5/site-packages/Django-1.2.3-py2.5.egg/django/core/mail/message.py",  
line 62, in forbid_multi_line_headers
raise BadHeaderError("Header values can't contain newlines (got %r for  
header %r)" % (val, name))
BadHeaderError: Header values can't contain newlines (got u'Re: Review  
Request: summary with a newline' for header 'Subject')




--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.