Re: Issue 2177 in reviewboard: git branch is not used
Updates: Status: Fixed Comment #9 on issue 2177 by trowb...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 Fixed in master (feeddca). Thanks! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2177 in reviewboard: git branch is not used
Comment #2 on issue 2177 by maciek.b...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 I'm using the new review request webpage. The patch was created with git format-patch --full-index. How can I submit a review for branch other than master? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2177 in reviewboard: git branch is not used
Comment #3 on issue 2177 by maciek.b...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 Just to be clear, it's not only about posting a review, but also being able to see the diff (that's where raw file url comes into play). I would really like to avoid creating a reviewboard repository for each project branch (then I can easily pass a different raw file url with branch indicated correctly). -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2177 in reviewboard: git branch is not used
Updates: Status: NotABug Comment #4 on issue 2177 by trowb...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 In general we recommend using post-review to create review requests. The diff has to be against a revision which is present in the repository that reviewboard knows about. You can then use --parent with post-review (or format-patch against something other than master) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2177 in reviewboard: git branch is not used
Comment #5 on issue 2177 by maciek.b...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 Can you provide the parameters that I should use for git format-patch? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2177 in reviewboard: git branch is not used
Comment #6 on issue 2177 by trowb...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 git diff --full-index branch..HEAD Which, again, assumes that 'branch' is present in the repo that reviewboard knows about. This is equivalent to `post-review --parent=branch` Every diff has the revision of the file(s) that that particular diff was created from. format-patch will save one patch per commit between the selected revisions. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2177 in reviewboard: git branch is not used
Comment #7 on issue 2177 by maciek.b...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 I think I found source of the problem. The index line in git format-patch --full-index contains blobs rather than revisions. Then, the recommended cgit line: http://git.gnome.org/browse/gtk+/plain/filename?id2=revision is incorrect as a commit sha is expected. It needs to be updated to: http://git.gnome.org/browse/gtk+/blob/filename?id=revision -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2177 in reviewboard: git branch is not used
Updates: Status: New Labels: Component-Docs Comment #8 on issue 2177 by trowb...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2177 in reviewboard: git branch is not used
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2177 by maciek.b...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.5.5 What's the URL of the page containing the problem? What steps will reproduce the problem? 1. commit a change to non-master branch 2. open a review for the change, specify branch name 3. try to view the diff What is the expected output? What do you see instead? Instead of showing the diff applied to the specified branch, the diff is applied to the master branch, or failed to apply if the master branch and the branch that the diff came from have divered significantly What operating system are you using? What browser? Please provide any additional information below. Although the review request contains branch field, it happens not to be used for fetching the file from raw file URL. The fields which can be passed are revision and filename. With this information, for instance cgit will output file from the default (master) branch. Additional field branch could be used in raw file url. Hence the url for cgit would look like: http://servername/browse/gtk+/plain/filename?id2=revisionh=branch -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2177 in reviewboard: git branch is not used
Updates: Status: NeedInfo Comment #1 on issue 2177 by trowb...@gmail.com: git branch is not used http://code.google.com/p/reviewboard/issues/detail?id=2177 How are you creating the review request? Via post-review? The branch field is just informational. It's not used in diff generation at all. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
