Re: Issue 2264 in reviewboard: Updating a diff when not owner causes problems

2012-12-23 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 2180

Comment #2 on issue 2264 by trowb...@gmail.com: Updating a diff when not  
owner causes problems

http://code.google.com/p/reviewboard/issues/detail?id=2264

I think this is similar enough to 2180 to merge.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2264 in reviewboard: Updating a diff when not owner causes problems

2012-02-14 Thread reviewboard


Comment #1 on issue 2264 by trowb...@gmail.com: Updating a diff when not  
owner causes problems

http://code.google.com/p/reviewboard/issues/detail?id=2264

Issue 2487 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2264 in reviewboard: Updating a diff when not owner causes problems

2011-08-29 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2264 by carl.van...@gmail.com: Updating a diff when not owner  
causes problems

http://code.google.com/p/reviewboard/issues/detail?id=2264

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.6 RC2

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Create a review 1234 (submitter: john)
2. Different user (peter) clicks "Update Diff" on 1234
3. Upload a file

What is the expected output? What do you see instead?

Expected: Diff is updated, or error "not submitter" is produced

Instead: Goes straight back to the review without completing the diff-add  
(i.e. the stage of adding info about the changes)
A pending-review-request is left lying around in the database, which needs  
to be manually removed via Admin interface.
Submitter has to be changed via Admin interface before peter can upload the  
review.
On older reviewboards, this may corrupt the database, but seems not to on  
1.6.


What operating system are you using? What browser?
Linux host, Windows+chrome client

Please provide any additional information below.

peter has admin rights. I don't know if this is part of the issue.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.